Skip to content

Commit d03780a

Browse files
author
Lucas McDonald
committed
fix(ci): fix VERSION_BUMP scoping and remove unused NPM token from publish job
Move VERSION_BUMP env var to the Version packages step where it is actually used, and remove it from Configure git where it was unused. Remove AWS credentials and NPM token fetch from the publish job since OIDC trusted publishing handles auth via id-token.
1 parent f11b277 commit d03780a

1 file changed

Lines changed: 2 additions & 14 deletions

File tree

.github/workflows/prod-release.yml

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -74,13 +74,14 @@ jobs:
7474
- name: Configure git
7575
env:
7676
BRANCH: ${{ github.event.inputs.branch }}
77-
VERSION_BUMP: ${{ github.event.inputs.version_bump }}
7877
run: |
7978
git config --global user.name "aws-crypto-tools-ci-bot"
8079
git config --global user.email "no-reply@noemail.local"
8180
git checkout $BRANCH
8281
8382
- name: Version packages
83+
env:
84+
VERSION_BUMP: ${{ github.event.inputs.version_bump }}
8485
run: |
8586
# Generate new version and CHANGELOG entry and push it
8687
npx lerna version --conventional-commits --git-remote origin --yes ${VERSION_BUMP:+$VERSION_BUMP --force-publish}
@@ -100,19 +101,6 @@ jobs:
100101
node-version: '22'
101102
registry-url: 'https://registry.npmjs.org'
102103

103-
- name: Configure AWS Credentials for Publish
104-
uses: aws-actions/configure-aws-credentials@v5
105-
with:
106-
aws-region: us-west-2
107-
role-to-assume: arn:aws:iam::587316601012:role/GitHub-CI-CI-Bot-Credential-Access-Role-us-west-2
108-
role-session-name: CI_Bot_Publish
109-
110-
- name: Get NPM Token
111-
uses: aws-actions/aws-secretsmanager-get-secrets@v2
112-
with:
113-
secret-ids: npm/aws-crypto-tools-ci-bot/2FA
114-
parse-json-secrets: true
115-
116104
# Ensure npm 11.5.1 or later is installed
117105
- name: Update npm
118106
run: npm install -g npm@latest

0 commit comments

Comments
 (0)