Fix P2P upload queue updates and GitHub Pages asset paths.

Deliver broadcasts to the local peer (Trystero does not echo), prefix flags/kick with basePath, and only log NTP probes when drift exceeds tolerance.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: lmangani

apps/client/src/components/dashboard/Metronome.tsx

@@ -2,12 +2,13 @@
 
 import { useBeatTiming } from "@/hooks/useBeatTiming";
 import { audioContextManager } from "@/lib/audioContextManager";
+import { publicAssetPath } from "@/lib/paths";
 import { cn } from "@/lib/utils";
 import { useGlobalStore } from "@/store/global";
 import { Metronome as MetronomeIcon } from "lucide-react";
 import { useCallback, useEffect, useRef } from "react";
 
-const KICK_URL = "/kick.wav";
+const KICK_URL = publicAssetPath("/kick.wav");
 
 /** Lazily fetch + decode the kick sample once, then cache it. Clears cache on failure so retries work. */
 let kickBufferPromise: Promise<AudioBuffer> | null = null;
@@ -52,9 +53,13 @@ export const MetronomeButton = () => {
     const ctx = audioContextManager.getContext();
     let cancelled = false;
 
-    getKickBuffer(ctx).then((buffer) => {
-      if (!cancelled) kickBufferRef.current = buffer;
-    });
+    getKickBuffer(ctx)
+      .then((buffer) => {
+        if (!cancelled) kickBufferRef.current = buffer;
+      })
+      .catch(() => {
+        // kick.wav is optional (may be absent on static deploy)
+      });
 
     return () => {
       cancelled = true;

apps/client/src/lib/api.ts

@@ -26,12 +26,17 @@ export const uploadAudioFile = async (data: { file: File; roomId: string }) => {
 
   await saveLocalTrack(record);
 
-  useP2PConnectionStore.getState().sendRequest({
+  const p2p = useP2PConnectionStore.getState();
+  if (!p2p.isReady) {
+    throw new Error("Room connection is still starting — try again in a moment");
+  }
+
+  p2p.sendRequest({
     type: ClientActionEnum.enum.REGISTER_AUDIO_SOURCE,
     source: { url },
   });
 
-  const room = useP2PConnectionStore.getState().room;
+  const room = p2p.room;
   if (room) {
     void broadcastLocalTrackToRoom(room, record);
   }

apps/client/src/lib/ip.ts

@@ -1,4 +1,5 @@
 import { countryCodeEmoji } from "@/lib/country/countryCode";
+import { publicAssetPath } from "@/lib/paths";
 import { LocationSchema, MAX_LOCATION_QUALITY, sanitizeLocationFields, scoreLocationQuality } from "@beatsync/shared";
 import { z } from "zod";
 import { getCountryName } from "./country/codeToName";
@@ -62,7 +63,7 @@ const getFlagSvgURLFromCountryCode = (countryCode: string) => {
     throw new Error(`Country code must be exactly 2 characters, got: ${countryCode}`);
   }
 
-  return `/flags/${countryCode.toLowerCase()}.svg`;
+  return publicAssetPath(`/flags/${countryCode.toLowerCase()}.svg`);
 };
 
 // https://www.geojs.io — Cloudflare-backed, full CORS, no key, unlimited

apps/client/src/store/p2pConnection.ts

@@ -115,6 +115,13 @@ export const useP2PConnectionStore = create<P2PConnectionState>()((set, get) =>
 
     const broadcastEnvelope = (envelope: P2PEnvelope) => {
       void sendEnvelopeAction(envelope, null);
+      // Trystero does not echo broadcasts to the initiator — apply room events locally.
+      if (envelope.kind !== "broadcast") return;
+      const payload = envelope.payload;
+      if (payload.type === "ROOM_EVENT" && payload.event.type === "CLIENT_CHANGE") {
+        return;
+      }
+      deliverLocalRoomMessage(payload);
     };
 
     const deliverLocalRoomMessage = (message: WSResponseType) => {

apps/client/src/utils/ntp.ts

@@ -138,20 +138,18 @@ export const validateProbePair = (data: {
 
   const total = pureCount + impureCount;
   const pureRate = total > 0 ? ((pureCount / total) * 100).toFixed(0) : "0";
+  const significantDrift = gapDrift > NTP_CONSTANTS.PROBE_GAP_TOLERANCE_MS;
 
-  if (!isPure) {
-    console.log(
-      `[CodedProbe] IMPURE #${probeGroupId} | clientGap=${clientGap.toFixed(1)}ms serverGap=${serverGap.toFixed(1)}ms drift=${gapDrift.toFixed(1)}ms | pure: ${pureCount}/${total} (${pureRate}%) | sent: ${probeGroupCounter}`
+  if (!isPure || significantDrift) {
+    const label = isPure ? "DRIFT" : "IMPURE";
+    console.warn(
+      `[NTP] ${label} probe #${probeGroupId} | clientGap=${clientGap.toFixed(1)}ms serverGap=${serverGap.toFixed(1)}ms drift=${gapDrift.toFixed(1)}ms | pure: ${pureCount}/${total} (${pureRate}%)`
     );
-    return null;
+    if (!isPure) return null;
   }
 
   const best = first.roundTripDelay <= measurement.roundTripDelay ? first : measurement;
 
-  console.log(
-    `[CodedProbe] PURE #${probeGroupId} | clientGap=${clientGap.toFixed(1)}ms serverGap=${serverGap.toFixed(1)}ms drift=${gapDrift.toFixed(1)}ms | bestRTT=${best.roundTripDelay.toFixed(1)}ms offset=${best.clockOffset.toFixed(1)}ms | pure: ${pureCount}/${total} (${pureRate}%) | sent: ${probeGroupCounter}`
-  );
-
   return best;
 };