[Bug]: The buildx_rule generate a lockfile that has a platform specific dependency

[farcop]

What happened?

I have tested this PR merged #1 and the issue persists.
If we generate MODULE.bazel.lock on one platform, it will not work on another.

INFO: Repository aspect_rules_buildx++buildx+buildx_configuration instantiated at:
  <builtin>: in <toplevel>
Repository rule configure_buildx defined at:
  /private/var/tmp/_bazel_farcop/e66529431dbede3bc951f821053136ab/external/aspect_rules_buildx+/buildx/repositories.bzl:80:35: in <toplevel>
ERROR: /private/var/tmp/_bazel_farcop/e66529431dbede3bc951f821053136ab/external/aspect_rules_buildx+/buildx/repositories.bzl:65:21: An error occurred during the fetch of repository 'aspect_rules_buildx++buildx+buildx_configuration':
   Traceback (most recent call last):
        File "/private/var/tmp/_bazel_farcop/e66529431dbede3bc951f821053136ab/external/aspect_rules_buildx+/buildx/repositories.bzl", line 65, column 21, in _impl_configure_buildx
                fail("Failed to create buildx driver %s: \nSTDERR:\n%s\nsSTDOUT:\n%s" % (builder_name, r.stderr, r.stdout))
Error in fail: Failed to create buildx driver rules_buildx_builder: 
STDERR:
/private/var/tmp/_bazel_farcop/e66529431dbede3bc951f821053136ab/external/aspect_rules_buildx++buildx+buildx_linux-amd64/buildx: /private/var/tmp/_bazel_farcop/e66529431dbede3bc951f821053136ab/external/aspect_rules_buildx++buildx+buildx_linux-amd64/buildx: cannot execute binary file

sSTDOUT:
ERROR: no such package '@@aspect_rules_buildx++buildx+buildx_configuration//': Failed to create buildx driver rules_buildx_builder: 
STDERR:
/private/var/tmp/_bazel_farcop/e66529431dbede3bc951f821053136ab/external/aspect_rules_buildx++buildx+buildx_linux-amd64/buildx: /private/var/tmp/_bazel_farcop/e66529431dbede3bc951f821053136ab/external/aspect_rules_buildx++buildx+buildx_linux-amd64/buildx: cannot execute binary file

sSTDOUT:
ERROR: /private/var/tmp/_bazel_farcop/e66529431dbede3bc951f821053136ab/external/aspect_rules_buildx+/buildx/BUILD.bazel:15:19: @@aspect_rules_buildx+//buildx:resolved_toolchain depends on @@aspect_rules_buildx++buildx+buildx_darwin-arm64//:buildx_toolchain in repository @@aspect_rules_buildx++buildx+buildx_darwin-arm64 which failed to fetch. no such package '@@aspect_rules_buildx++buildx+buildx_configuration//': Failed to create buildx driver rules_buildx_builder: 
STDERR:
/private/var/tmp/_bazel_farcop/e66529431dbede3bc951f821053136ab/external/aspect_rules_buildx++buildx+buildx_linux-amd64/buildx: /private/var/tmp/_bazel_farcop/e66529431dbede3bc951f821053136ab/external/aspect_rules_buildx++buildx+buildx_linux-amd64/buildx: cannot execute binary file

sSTDOUT:
ERROR: Analysis of target '//nonhermetic/os-cert-generator:image' failed; build aborted: Analysis failed
INFO: Elapsed time: 1.691s, Critical Path: 0.82s
INFO: 1 process: 1 internal.

Version

Development (host) and target OS/architectures:

Output of bazel --version: 8.3.1

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file: 0.0.1

Language(s) and/or frameworks involved:

How to reproduce

1. Using aspect_rules_buildx generate MODULE.bazel.lock on darwin_arm64
2. Try to build target on the linux_amd64 PC.

Any other information?

MODULE.bazel.lock still contains that platform specific block:

          "buildx_configuration": {
            "repoRuleId": "@@aspect_rules_buildx+//buildx:repositories.bzl%configure_buildx",
            "attributes": {
              "buildx": "@@aspect_rules_buildx++buildx+buildx_linux-amd64//:buildx"
            }
          },

[arrdem]

I suspect that you pulled the "wrong" 0.0.1 archive. This being a prerelease ruleset and there being some deploy teething pains the 0.0.1 tag was force-moved today, and the earliest state of the tag predated the #1 merge. Can you confirm what archive state / commit you were using?

[farcop]

I use it like this

bazel_dep(name = "aspect_rules_buildx")

archive_override(
    module_name = "aspect_rules_buildx",
    integrity = "sha256-PVRQaniGFgIAiHbjM9fOavMVdY3HJCFHDKzl1+O3g+g=",
    strip_prefix = "rules_buildx-0.0.1",
    urls = ["https://github.com/aspect-build/rules_buildx/releases/download/v0.0.1/rules_buildx-v0.0.1.tar.gz"],
)

UPD: You can see the platform specific block generated in e2e-tests https://github.com/aspect-build/rules_buildx/blob/main/e2e/smoke/MODULE.bazel.lock#L218-L223

[pulasthibandara]

I should have been more clear on the PR (#1). This still generates a lock entry, it will generate a lock entry per platform that you generate a lock in (ex: darwin_arm, linux_aarch64).

This allows building on any platform, but you will have to check in the generated lock entries each time a new platform is used.

ex:

 "@@rules_buildx+//buildx:extensions.bzl%buildx": {
      "os:linux,arch:aarch64": {
        "bzlTransitiveDigest": "UBkkYnXiTTdOjhNW1sfRYBRgSc17c97+xx1dF2ZP1GA=",
        "usagesDigest": "OnGUa3RzsH74cJ83Ex9tIGCDE3eYmSyqZkazzcJKs2E=",
        "recordedFileInputs": {},
        "recordedDirentsInputs": {},
        "envVariables": {},
        "generatedRepoSpecs": {
          "buildx_darwin-amd64": {
            "repoRuleId": "@@rules_buildx+//buildx:repositories.bzl%buildx_repo",
            "attributes": {
              "platform": "darwin-amd64",
              "buildx_version": "0.22.0"
            }
          },
          "buildx_darwin-arm64": {
            "repoRuleId": "@@rules_buildx+//buildx:repositories.bzl%buildx_repo",
            "attributes": {
              "platform": "darwin-arm64",
              "buildx_version": "0.22.0"
            }
          },
          "buildx_linux-arm64": {
            "repoRuleId": "@@rules_buildx+//buildx:repositories.bzl%buildx_repo",
            "attributes": {
              "platform": "linux-arm64",
              "buildx_version": "0.22.0"
            }
          },
          "buildx_linux-amd64": {
            "repoRuleId": "@@rules_buildx+//buildx:repositories.bzl%buildx_repo",
            "attributes": {
              "platform": "linux-amd64",
              "buildx_version": "0.22.0"
            }
          },
+          "buildx_configuration": {
+          "repoRuleId": "@@rules_buildx+//buildx:repositories.bzl%configure_buildx",
+          "attributes": {
+             "buildx": "@@rules_buildx++buildx+buildx_linux-arm64//:buildx"
+          }
          },
          "buildx_toolchains": {
            "repoRuleId": "@@rules_buildx+//buildx/private:toolchains_repo.bzl%toolchains_repo",
            "attributes": {
              "user_repository_name": "buildx"
            }
          }
        },
        "moduleExtensionMetadata": {
          "explicitRootModuleDirectDeps": [
            "buildx_toolchains",
            "buildx_configuration"
          ],
          "explicitRootModuleDirectDevDeps": [],
          "useAllRepos": "NO",
          "reproducible": false
        },
        "recordedRepoMappingEntries": [
          [
            "rules_buildx+",
            "aspect_bazel_lib",
            "aspect_bazel_lib+"
          ]
        ]
      },
      "os:linux,arch:amd64": {
        "bzlTransitiveDigest": "UBkkYnXiTTdOjhNW1sfRYBRgSc17c97+xx1dF2ZP1GA=",
        "usagesDigest": "OnGUa3RzsH74cJ83Ex9tIGCDE3eYmSyqZkazzcJKs2E=",
        "recordedFileInputs": {},
        "recordedDirentsInputs": {},
        "envVariables": {},
        "generatedRepoSpecs": {
          "buildx_darwin-amd64": {
            "repoRuleId": "@@rules_buildx+//buildx:repositories.bzl%buildx_repo",
            "attributes": {
              "platform": "darwin-amd64",
              "buildx_version": "0.22.0"
            }
          },
          "buildx_darwin-arm64": {
            "repoRuleId": "@@rules_buildx+//buildx:repositories.bzl%buildx_repo",
            "attributes": {
              "platform": "darwin-arm64",
              "buildx_version": "0.22.0"
            }
          },
          "buildx_linux-arm64": {
            "repoRuleId": "@@rules_buildx+//buildx:repositories.bzl%buildx_repo",
            "attributes": {
              "platform": "linux-arm64",
              "buildx_version": "0.22.0"
            }
          },
          "buildx_linux-amd64": {
            "repoRuleId": "@@rules_buildx+//buildx:repositories.bzl%buildx_repo",
            "attributes": {
              "platform": "linux-amd64",
              "buildx_version": "0.22.0"
            }
          },
+          "buildx_configuration": {
+            "repoRuleId": "@@rules_buildx+//buildx:repositories.bzl%configure_buildx",
+            "attributes": {
+              "buildx": "@@rules_buildx++buildx+buildx_linux-amd64//:buildx"
+            }
          },
          "buildx_toolchains": {
            "repoRuleId": "@@rules_buildx+//buildx/private:toolchains_repo.bzl%toolchains_repo",
            "attributes": {
              "user_repository_name": "buildx"
            }
          }
        },
        "moduleExtensionMetadata": {
          "explicitRootModuleDirectDeps": [
            "buildx_toolchains",
            "buildx_configuration"
          ],
          "explicitRootModuleDirectDevDeps": [],
          "useAllRepos": "NO",
          "reproducible": false
        },
        "recordedRepoMappingEntries": [
          [
            "rules_buildx+",
            "aspect_bazel_lib",
            "aspect_bazel_lib+"
          ]
        ]
      },
      "os:osx,arch:aarch64": {
        "bzlTransitiveDigest": "UBkkYnXiTTdOjhNW1sfRYBRgSc17c97+xx1dF2ZP1GA=",
        "usagesDigest": "OnGUa3RzsH74cJ83Ex9tIGCDE3eYmSyqZkazzcJKs2E=",
        "recordedFileInputs": {},
        "recordedDirentsInputs": {},
        "envVariables": {},
        "generatedRepoSpecs": {
          "buildx_darwin-amd64": {
            "repoRuleId": "@@rules_buildx+//buildx:repositories.bzl%buildx_repo",
            "attributes": {
              "platform": "darwin-amd64",
              "buildx_version": "0.22.0"
            }
          },
          "buildx_darwin-arm64": {
            "repoRuleId": "@@rules_buildx+//buildx:repositories.bzl%buildx_repo",
            "attributes": {
              "platform": "darwin-arm64",
              "buildx_version": "0.22.0"
            }
          },
          "buildx_linux-arm64": {
            "repoRuleId": "@@rules_buildx+//buildx:repositories.bzl%buildx_repo",
            "attributes": {
      }
    },