fix: #2415 Revert "feat: Add "Only Important" filter to Spell Cast icon type (#2412)"

This reverts commit 69661ee.

Author: ascott18

CHANGELOG.md

@@ -1,5 +1,4 @@
 ## v12.0.12
-* Added Only Important filter to Spell Cast icon type
 * Added "Addon Restriction Active" condition (#2414) - checks if any selected restriction types (Combat, Encounter, Challenge Mode, PvP, Map, Chat) are active.
 * Fix #2410 - Buff/Debuff icons rarely failing to emit a duration object
 * Fix #2423 - Player stats and similar are now secret

Components/IconTypes/IconType_cast/cast.lua

@@ -63,9 +63,6 @@ Type:RegisterIconDefaults{
 
 	-- True if the icon should display blanks instead of the pocketwatch texture.
 	NoPocketwatch			= false,
-
-	-- True if the icon should only check casts of spells flagged as important.
-	OnlyImportant			= false,
 }
 
 if not TMW.clientHasSecrets then
@@ -98,20 +95,13 @@ Type:RegisterConfigPanel_ConstructorFunc(150, "TellMeWhen_CastSettings", functio
 			noPocketwatch,
 		})
 	else
-		local checks = {
+		self:BuildSimpleCheckSettingFrame({
 			function(check)
 				check:SetTexts(L["ICONMENU_ONLYINTERRUPTIBLE"], L["ICONMENU_ONLYINTERRUPTIBLE_DESC"])
 				check:SetSetting("Interruptible")
 			end,
 			noPocketwatch,
-		}
-		if TMW.clientHasSecrets then
-			checks[#checks + 1] = function(check)
-				check:SetTexts(L["ICONMENU_ONLYIMPORTANT"], L["ICONMENU_ONLYIMPORTANT_DESC"])
-				check:SetSetting("OnlyImportant")
-			end
-		end
-		self:BuildSimpleCheckSettingFrame(checks)
+		})
 	end
 end)
 
@@ -154,10 +144,9 @@ end
 
 local Cast_OnUpdate
 if TMW.clientHasSecrets then
-	local IsSpellImportant = C_Spell.IsSpellImportant
 	function Cast_OnUpdate_Secrets(icon, time)
 		-- Upvalue things that will be referenced a lot in our loops.
-		local Units, Interruptible, OnlyImportant = icon.Units, icon.Interruptible, icon.OnlyImportant
+		local Units, Interruptible = icon.Units, icon.Interruptible
 
 		for u = 1, #Units do
 			local unit = Units[u]
@@ -166,21 +155,20 @@ if TMW.clientHasSecrets then
 			local GUID = UnitGUID(unit)
 			if GUID then
 
-				local name, _, iconTexture, start, endTime, _, _, notInterruptible, castingSpellID = UnitCastingInfo(unit)
+				local name, _, iconTexture, start, endTime, _, _, notInterruptible = UnitCastingInfo(unit)
 				local durObj = name and UnitCastingDuration(unit)
 				-- Reverse is used to reverse the timer sweep masking behavior. Regular casts should have it be false.
 				local reverse = false
 
 				-- There is no regular spellcast. Check for a channel.
 				if not name then
-					name, _, iconTexture, start, endTime, _, notInterruptible, castingSpellID = UnitChannelInfo(unit)
+					name, _, iconTexture, start, endTime, _, notInterruptible = UnitChannelInfo(unit)
 					durObj = name and UnitChannelDuration(unit)
 					-- Channeled casts should reverse the timer sweep behavior.
 					reverse = true
 				end
 
-				local isImportant = not OnlyImportant or (castingSpellID and IsSpellImportant(castingSpellID))
-				if name and isImportant then
+				if name then
 					icon.LastTexture = iconTexture
 
 					local state

Localization/TellMeWhen-enUS.lua

@@ -538,9 +538,6 @@ L["ICONMENU_ONSUCCEED"] = "On Succeed"
 L["ICONMENU_ONLYINTERRUPTIBLE"] = "Only Interruptible"
 L["ICONMENU_ONLYINTERRUPTIBLE_DESC"] = "Check this box to only show spell casts that are interruptible"
 
-L["ICONMENU_ONLYIMPORTANT"] = "Only Important"
-L["ICONMENU_ONLYIMPORTANT_DESC"] = "Check this box to only show spell casts that Blizzard flags as important"
-
 L["ICONMENU_NOPOCKETWATCH"] = "Blank Texture for Unknown"
 L["ICONMENU_NOPOCKETWATCH_DESC"] = "Check this box to show no texture instead of the Pocketwatch texture."
 

Options/CHANGELOG.lua

@@ -4,7 +4,6 @@ TMW.CHANGELOG_LASTVER="10.0.0"
 
 TMW.CHANGELOG = [==[
 ## v12.0.12
-* Added Only Important filter to Spell Cast icon type
 * Added "Addon Restriction Active" condition (#2414) - checks if any selected restriction types (Combat, Encounter, Challenge Mode, PvP, Map, Chat) are active.
 * Fix #2410 - Buff/Debuff icons rarely failing to emit a duration object
 * Fix #2423 - Player stats and similar are now secret