fix: #2410 - Buff/Debuff icons rarely failing to emit a duration object

Author: ascott18

CHANGELOG.md

@@ -1,3 +1,6 @@
+## v12.0.12
+* Fix #2410 - Buff/Debuff icons rarely failing to emit a duration object
+
 ## v12.0.11
 * Fix #2401 - Lua Value icon type to not break when the user code returns secrets.
 * Fix #2381 - Icon sometimes has a delay in showing as ready.

Components/IconModules/IconModule_CooldownSweep/CooldownSweep.lua

@@ -333,9 +333,10 @@ if TMW.clientHasSecrets then
 			cd:SetCooldownFromDurationObject(self.durObj)
 		else
 			if issecretvalue(mainStart) or issecretvalue(mainDuration) or issecretvalue(self.modRate) then
-				error(("TMW %s: Unexpected secret to SetCooldown. %s, %s, %s, %s, %s"):format(TELLMEWHEN_VERSIONNUMBER, tostring(self.icon), self.icon.Type, tostring(issecretvalue(mainStart)), tostring(issecretvalue(mainDuration)), tostring(issecretvalue(self.modRate))))
+				TMW:Error(("Unexpected secret to SetCooldown. %s, %s, %s, %s, %s"):format(tostring(self.icon), self.icon.Type, tostring(issecretvalue(mainStart)), tostring(issecretvalue(mainDuration)), tostring(issecretvalue(self.modRate))))
+			else
+				cd:SetCooldown(mainStart, mainDuration, self.modRate)
 			end
-			cd:SetCooldown(mainStart, mainDuration, self.modRate)
 		end
 
 		-- Handle charges of spells that aren't completely depleted.

Components/IconTypes/IconType_buff/buff.lua

@@ -872,6 +872,8 @@ function Type:HandleYieldedInfo(icon, iconToSet, unit, instance)
 				if issecretvalue(instance.duration) then
 					-- Match secret state of unknown start so secret tests don't mismatch between start + duration
 					start = secretwrap(start)
+					-- Ensure non-nil durObj so we don't attempt SetCooldown with secrets.
+					durObj = C_DurationUtil.CreateDuration()
 				end
 			end
 

Components/IconTypes/IconType_buffcheck/buffcheck.lua

@@ -338,6 +338,8 @@ function Type:HandleYieldedInfo(icon, iconToSet, unit, instance)
 				if issecretvalue(instance.duration) then
 					-- Match secret state of unknown start so secret tests don't mismatch between start + duration
 					start = secretwrap(start)
+					-- Ensure non-nil durObj so we don't attempt SetCooldown with secrets.
+					durObj = C_DurationUtil.CreateDuration()
 				end
 			end
 		else

Options/CHANGELOG.lua

@@ -3,6 +3,9 @@ if not TMW then return end
 TMW.CHANGELOG_LASTVER="10.0.0"
 
 TMW.CHANGELOG = [==[
+## v12.0.12
+* Fix #2410 - Buff/Debuff icons rarely failing to emit a duration object
+
 ## v12.0.11
 * Fix #2401 - Lua Value icon type to not break when the user code returns secrets.
 * Fix #2381 - Icon sometimes has a delay in showing as ready.

TellMeWhen.toc

@@ -18,7 +18,7 @@
 ## X-WoWI-ID: 10855
 ## X-Wago-ID: ZQ6aZqKW
 
-## Version: 12.0.11
+## Version: 12.0.12
 ## Author: Cybeloras of Aerie Peak
 ## IconTexture: Interface\Addons\TellMeWhen\Textures\LDB Icon
 ## AddonCompartmentFunc: TellMeWhen_OnAddonCompartmentClick