Skip to content

Commit ded7a42

Browse files
committed
ACL: fix suggestion commit
1 parent 17fbaae commit ded7a42

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

contracts/acl/ACL.sol

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -315,13 +315,13 @@ contract ACL is IACL, TimeHelpers, AragonApp, ACLHelpers {
315315
function _saveParams(uint256[] _encodedParams) internal returns (bytes32) {
316316
bytes32 paramHash = keccak256(abi.encodePacked(_encodedParams));
317317

318-
// Note: EMPTY_PARAM_HASH has been miscalculated since aragonOS@4.0.0.
318+
// Note: EMPTY_PARAM_HASH has been miscalculated since aragonOS@3.0.0.
319319
// Its value is actually `keccak256([ uint256(0) ])` (mapping to a single empty param with
320320
// Op.None) and not the intended `keccak256("")`.
321321
// To not be confusing for users who attempt to use Op.None, we're now left with this
322322
// historical artifact to keep compatibility with old state from ACLs created with
323323
// aragonOS@4.0.0's ACL.
324-
// Note: EMPTY_PARAM_HASH has been miscalculated since aragonOS@3.0.0.
324+
require(paramHash != EMPTY_PARAM_HASH, ERROR_SAVE_EMPTY_HASH);
325325

326326
Param[] storage params = permissionParams[paramHash];
327327

0 commit comments

Comments
 (0)