From 18df8fbaa9d36244558086061118a08e2ed89901 Mon Sep 17 00:00:00 2001 From: Laurent Martelli Date: Mon, 28 Sep 2026 15:29:48 +0200 Subject: [PATCH] Fix NPE Stacktrace from version 23.1.0 : java.lang.NullPointerException: Cannot invoke "java.util.List.contains(Object)" because "validExtensionsWithDot" is null at org.approvaltests.reporters.GenericDiffReporter.isFileExtensionValid(GenericDiffReporter.java:122) at org.approvaltests.reporters.GenericDiffReporter.isFileExtensionHandled(GenericDiffReporter.java:117) at org.approvaltests.reporters.GenericDiffReporter.isWorkingInThisEnvironment(GenericDiffReporter.java:104) at org.approvaltests.reporters.GenericDiffReporter.report(GenericDiffReporter.java:56) at org.approvaltests.reporters.FirstWorkingReporter.report(FirstWorkingReporter.java:21) at org.approvaltests.reporters.FirstWorkingReporter.report(FirstWorkingReporter.java:21) at org.approvaltests.reporters.FirstWorkingReporter.report(FirstWorkingReporter.java:21) at org.approvaltests.reporters.FirstWorkingReporter.report(FirstWorkingReporter.java:21) at org.approvaltests.approvers.FileApprover.reportFailure(FileApprover.java:49) at org.approvaltests.Approvals.verify(Approvals.java:220) at org.approvaltests.Approvals.verify(Approvals.java:183) at org.approvaltests.Approvals.verify(Approvals.java:191) at org.approvaltests.Approvals.verify(Approvals.java:50) --- .../java/org/approvaltests/reporters/GenericDiffReporter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/approvaltests/src/main/java/org/approvaltests/reporters/GenericDiffReporter.java b/approvaltests/src/main/java/org/approvaltests/reporters/GenericDiffReporter.java index a725b669..14634063 100644 --- a/approvaltests/src/main/java/org/approvaltests/reporters/GenericDiffReporter.java +++ b/approvaltests/src/main/java/org/approvaltests/reporters/GenericDiffReporter.java @@ -47,7 +47,7 @@ public GenericDiffReporter(String diffProgram, String argumentsFormat, String di this.diffProgram = diffProgram; this.arguments = argumentsFormat; this.diffProgramNotFoundMessage = diffProgramNotFoundMessage; - validExtensions = validFileExtensions; + this.validExtensions = validFileExtensions; } public GenericDiffReporter(DiffInfo info)