java 22 eol

[betaboon]

Hello there,
I'm not a java person, but currently trying to package this for nixos.

as 22 has been eol for over 8 months, it has been removed in nixos, thus making it impossible to package this.
apple/pkl uses 23 (which is eol since over 2months) which is still available in nixos, but also builds with 21.

would it be possible to make pkl-lsp build with 21 which is lts?

[bioball]

We depend on project panama, which requires JDK22 or newer. You should be able to use JDK24 with pkl-lsp just fine.

[jedesroches]

Hey @bioball :) Attempted the same thing as @betaboon, and got something partially working. However, NixOS (and more and more other distros) are aiming at reproducible builds and therefore require the package to be built in a sandbox. Providing the various gradle-related dependencies in this sandbox is covered by the packaging tooling, but working around the "download our own copy of zig" part is a bit complicated - that's far from reproducible / easy to sandbox.

Would you consider modifying the build to:

a) simply depend on zig being available in the environment (with appropriate documentation ?)
b) checking if a version-compatible zig already exists in PATH before downloading one ?

In the meantime, I'll see if I build a package from the JAR you publish with your releases 🤔

(As a first approximation, nix users finding themselves here can use this flake. Next steps are getting the lsp package into nixpkgs and finding a fix for NixOS/nixpkgs#462850)

[matdibu]

@bioball do you foresee any potential breakage if someone was to force JDK25 by setting val jdkVersion: Int = 25 in buildSrc/src/main/kotlin/BuildInfo.kt (in a 3rd party package defnition, not directly in this project) ?

@betaboon @jedesroches I have opened a PR at NixOS/nixpkgs#497181 based on @ryota2357's work in NixOS/nixpkgs#474002