Add tests for TryNodeCount/TryApplicationCount metrics and fix coverage gaps

- Add TestTryNodeCount covering AddTryNodeCount, GetTryNodeCount, ResetTryNodeCount
- Add TestTryApplicationCount covering AddTryApplicationCount, ResetTryApplicationCount
- Fix unregisterMetrics to also unregister tryApplicationCount
- Add ApplicationsTried assertion to TestApplicationsTriedCount
- Fix stale comments in TestApplicationsTriedCount

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: mitdesai

pkg/metrics/scheduler_test.go

@@ -232,6 +232,44 @@ func verifyMetric(t *testing.T, expectedCounter float64, expectedState string, n
 	assert.Assert(t, checked, "Failed to find metric")
 }
 
+func TestTryNodeCount(t *testing.T) {
+	sm = getSchedulerMetrics(t)
+	defer unregisterMetrics()
+
+	sm.AddTryNodeCount(5)
+	count, err := sm.GetTryNodeCount()
+	assert.NilError(t, err)
+	assert.Equal(t, int64(5), count)
+
+	sm.AddTryNodeCount(3)
+	count, err = sm.GetTryNodeCount()
+	assert.NilError(t, err)
+	assert.Equal(t, int64(8), count)
+
+	sm.ResetTryNodeCount()
+	sm.AddTryNodeCount(1)
+	count, err = sm.GetTryNodeCount()
+	assert.NilError(t, err)
+	assert.Equal(t, int64(1), count)
+}
+
+func TestTryApplicationCount(t *testing.T) {
+	sm = getSchedulerMetrics(t)
+	defer unregisterMetrics()
+
+	sm.AddTryApplicationCount(4)
+	metricDto := &dto.Metric{}
+	err := sm.tryApplicationCount.With(nil).Write(metricDto)
+	assert.NilError(t, err)
+	assert.Equal(t, int64(4), int64(*metricDto.Counter.Value))
+
+	sm.ResetTryApplicationCount()
+	sm.AddTryApplicationCount(2)
+	err = sm.tryApplicationCount.With(nil).Write(metricDto)
+	assert.NilError(t, err)
+	assert.Equal(t, int64(2), int64(*metricDto.Counter.Value))
+}
+
 func unregisterMetrics() {
 	sm := GetSchedulerMetrics()
 	prometheus.Unregister(sm.containerAllocation)
@@ -245,4 +283,5 @@ func unregisterMetrics() {
 	prometheus.Unregister(sm.tryNodeEvaluation)
 	prometheus.Unregister(sm.tryPreemptionLatency)
 	prometheus.Unregister(sm.tryNodeCount)
+	prometheus.Unregister(sm.tryApplicationCount)
 }

pkg/scheduler/objects/application_test.go

@@ -3329,7 +3329,7 @@ func TestTryAllocateWithReservedHeadRoomChecking(t *testing.T) {
 
 	// pass the time and try again
 	reservationWaitTimeout = -60 * time.Second
-	result = app.tryReservedAllocate(headRoom, iter)
+	result, _ = app.tryReservedAllocate(headRoom, iter)
 	assert.Assert(t, result == nil, "result is expected to be nil due to insufficient headroom")
 	assert.Equal(t, len(app.reservations), 0)
 

pkg/scheduler/partition_test.go

@@ -1664,8 +1664,9 @@ func TestApplicationsTriedCount(t *testing.T) {
 		t.Fatal("allocation did not return any allocation")
 	}
 	assert.Equal(t, result.ResultType, objects.Allocated, "result type is not the expected allocated")
-	assert.Equal(t, result.Request.GetApplicationID(), appID3, "expected application app-2 to be allocated")
-	assert.Equal(t, result.Request.GetAllocationKey(), allocKey3, "expected ask alloc-2 to be allocated")
+	assert.Equal(t, result.Request.GetApplicationID(), appID3, "expected application app-3 to be allocated")
+	assert.Equal(t, result.Request.GetAllocationKey(), allocKey3, "expected ask alloc-3 to be allocated")
+	assert.Equal(t, result.ApplicationsTried, int64(3), "expected 3 applications to be tried")
 }
 
 func TestNodesTriedCount(t *testing.T) {