diff --git a/superset-frontend/src/SqlLab/actions/sqlLab.test.ts b/superset-frontend/src/SqlLab/actions/sqlLab.test.ts index ae53c83b77a4..157aaa3d4c9f 100644 --- a/superset-frontend/src/SqlLab/actions/sqlLab.test.ts +++ b/superset-frontend/src/SqlLab/actions/sqlLab.test.ts @@ -1843,14 +1843,26 @@ describe('async actions', () => { { ...query, id: 'previewOne', - sqlEditorId: oldQueryEditor.id, - inLocalStorage: true, + sqlEditorId: null, + isDataPreview: true, }, { ...query, id: 'previewTwo', + sqlEditorId: null, + isDataPreview: true, + }, + { + ...query, + id: 'runningQuery', sqlEditorId: oldQueryEditor.id, - inLocalStorage: true, + state: 'running', + }, + { + ...query, + id: 'unrelatedQuery', + sqlEditorId: 'other-editor', + state: 'running', }, ]; const store = mockStore({ @@ -1885,12 +1897,7 @@ describe('async actions', () => { }, { type: actions.MIGRATE_QUERY, - queryId: 'previewOne', - queryEditorId: '1', - }, - { - type: actions.MIGRATE_QUERY, - queryId: 'previewTwo', + queryId: 'runningQuery', queryEditorId: '1', }, ]; @@ -1900,7 +1907,7 @@ describe('async actions', () => { expect(store.getActions()).toEqual(expectedActions); expect( fetchMock.callHistory.calls(updateTabStateEndpoint), - ).toHaveLength(3); + ).toHaveLength(2); // query editor has 2 tables loaded in the schema viewer expect( diff --git a/superset-frontend/src/SqlLab/actions/sqlLab.ts b/superset-frontend/src/SqlLab/actions/sqlLab.ts index 072bfd05260e..8941f688929b 100644 --- a/superset-frontend/src/SqlLab/actions/sqlLab.ts +++ b/superset-frontend/src/SqlLab/actions/sqlLab.ts @@ -689,8 +689,8 @@ export function syncQueryEditor( (table: Table) => table.inLocalStorage && table.queryEditorId === queryEditor.id, ); - const localStorageQueries = Object.values(queries).filter( - query => query.inLocalStorage && query.sqlEditorId === queryEditor.id, + const queriesToMigrate = Object.values(queries).filter( + query => query.sqlEditorId === queryEditor.id && !query.isDataPreview, ); return SupersetClient.post({ endpoint: '/tabstateview/', @@ -712,7 +712,7 @@ export function syncQueryEditor( ...localStorageTables.map((table: Table) => migrateTable(table, newQueryEditor.tabViewId!, dispatch), ), - ...localStorageQueries.map((query: Query) => + ...queriesToMigrate.map((query: Query) => migrateQuery(query.id, newQueryEditor.tabViewId!, dispatch), ), ]);