When trying to duplicate a dataset, the "Fatal error" appears

[dinoel93]

Bug description

There is some role with access to all interactions with datasets and some user in this role.
This user can create new datasets, edit and delete existing datasets.
But when this user tries to duplicate any dataset, an error appears:
There was an issue duplicating the selected datasets: Fatal error
In logs of superset appears:
ERROR:flask_appbuilder.api:Entity namespace for "mapped class Database->dbs" has no property "table_name"
At the same time, a user with administrator rights can duplicate datasets

How to reproduce the bug

• Create role with permissions shown in screenshots below
• Create user in this role an permissions to some database
• Try to duplicate some dataset by this user

Screenshots/recordings

Superset version

3.1.1

Python version

3.10

Node version

16

Browser

Chrome

Additional context

Full error from logs:
Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: 2024-03-27 15:34:24,136:ERROR:flask_appbuilder.api:Entity namespace for "mapped class Database->dbs" has no property "table_name" Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: Traceback (most recent call last): Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: File "/usr/local/lib/python3.10/dist-packages/sqlalchemy/sql/base.py", line 1694, in _entity_namespace_key Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: return getattr(ns, key) Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: AttributeError: type object 'Database' has no attribute 'table_name'. Did you mean: 'database_name'? Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: The above exception was the direct cause of the following exception: Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: Traceback (most recent call last): Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: File "/usr/local/lib/python3.10/dist-packages/flask_appbuilder/api/__init__.py", line 110, in wraps Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: return f(self, *args, **kwargs) Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: File "/usr/local/lib/python3.10/dist-packages/superset/views/base_api.py", line 127, in wraps Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: raise ex Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: File "/usr/local/lib/python3.10/dist-packages/superset/views/base_api.py", line 121, in wraps Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: duration, response = time_function(f, self, *args, **kwargs) Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: File "/usr/local/lib/python3.10/dist-packages/superset/utils/core.py", line 1463, in time_function Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: response = func(*args, **kwargs) Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: File "/usr/local/lib/python3.10/dist-packages/superset/utils/log.py", line 255, in wrapper Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: value = f(*args, **kwargs) Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: File "/usr/local/lib/python3.10/dist-packages/superset/views/base_api.py", line 93, in wraps Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: return f(self, *args, **kwargs) Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: File "/usr/local/lib/python3.10/dist-packages/superset/datasets/api.py", line 618, in duplicate Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: new_model = DuplicateDatasetCommand(item).run() Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: File "/usr/local/lib/python3.10/dist-packages/superset/commands/dataset/duplicate.py", line 51, in run Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: self.validate() Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: File "/usr/local/lib/python3.10/dist-packages/superset/commands/dataset/duplicate.py", line 126, in validate Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: if DatasetDAO.find_one_or_none(table_name=duplicate_name): Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: File "/usr/local/lib/python3.10/dist-packages/superset/daos/base.py", line 128, in find_one_or_none Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: return query.filter_by(**filter_by).one_or_none() Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: File "/usr/local/lib/python3.10/dist-packages/sqlalchemy/orm/query.py", line 1806, in filter_by Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: clauses = [ Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: File "/usr/local/lib/python3.10/dist-packages/sqlalchemy/orm/query.py", line 1807, in <listcomp> Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: _entity_namespace_key(from_entity, key) == value Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: File "/usr/local/lib/python3.10/dist-packages/sqlalchemy/sql/base.py", line 1696, in _entity_namespace_key Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: util.raise_( Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: File "/usr/local/lib/python3.10/dist-packages/sqlalchemy/util/compat.py", line 211, in raise_ Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: raise exception Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: sqlalchemy.exc.InvalidRequestError: Entity namespace for "mapped class Database->dbs" has no property "table_name" Mar 27 15:34:24 superset.virt.qb.loc superset[1387334]: 2024-03-27 15:34:24,141:INFO:werkzeug:127.0.0.1 - - [27/Mar/2024 15:34:24] "POST /api/v1/dataset/duplicate HTTP/1.0" 500 -

Checklist

• I have searched Superset docs and Slack and didn't find a solution to my problem.
• I have searched the GitHub issue tracker and didn't find a similar bug report.
• I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

[L-Ameneiro]

Are there any news regarding this issue?
I'm having the same problem with a user that has all the relevant permissions.
Interestingly, an admin user is able to duplicate datasets without issue.

[rusackas]

@dosu-bot

[dosubot]

@rusackas Hello! I'm here to help you with any bugs, questions, or contributions while you wait for a human maintainer. Feel free to ask me anything. Dosu

The issue arises because the DatasetDAO.find_one_or_none method is attempting to access a non-existent table_name property on the Database class. This results in the error: Entity namespace for "mapped class Database->dbs" has no property "table_name".

To resolve this, ensure that the query in the DuplicateDatasetCommand class is using the correct property names. Specifically, replace table_name with a valid property of the Database class, such as database_name.

Here's a snippet from the superset/commands/dataset/duplicate.py file that needs modification:

# Original code
if DatasetDAO.find_one_or_none(table_name=duplicate_name):

Change it to:

# Corrected code
if DatasetDAO.find_one_or_none(database_name=duplicate_name):

Additionally, ensure that the user has explicit access to the dataset they are trying to duplicate. This can be done by checking and updating the dataset's permissions to include the user's role or by adding the user as an owner of the dataset ^{[1][2][3][4][5]}.

To continue talking to Dosu, mention @dosu.

[deepakbh-conga]

Facing Similar issue? Any updates? Admin user is able to duplicate. But a user with access to a particular Database connection is not able to.

[rusackas]

We're no longer supporting 3.x versions, and we haven't heard any activity here in ~5 months, so I'll somewhat optimistically close this, but let us know if you're facing this in 4.1.2 or 5.0.0, and we can happily revisit/reopen.

[mapledan]

I encountered the same issue. My Superset version is 5.0.0.
When a user only has the on duplicate on dataset permission, the action button appears, but executing it results in the same error message.
Only when the user is granted all datasource access on all_datasource_access can the operation be successfully executed.

[editicalu]

We had the same issue when a user had access to duplicate the data source (according to permissions), but could not duplicate, even with the duplicate permission. An admin could duplicate.
Superset version 4.1.4

[goldjee]

Hello, Evan!

The issue is still present in 6.0. According to Claude, the problematic code resides in superset/commands/dataset/duplicate.py, lines 118-119 where it checks for dataset existence using find_one_or_none(table_name=duplicate_name). This fails because:

1. The DatasourceFilter joins the Database table to the query
2. SQLAlchemy's filter_by() gets confused about which model has the table_name attribute
3. It incorrectly resolves to Database instead of SqlaTable, causing the error

@rusackas

[rusackas]

Reopening since it's still a thing in 6.0. Hopefully get can get @goldjee's PR through.

[goldjee]

Fixed in #40130

[rusackas]

#37932 fixed this - dataset duplication for non-admin users works now that the validation check is corrected. Closing, holler if it's still broken for you.