fix(mcp): address review feedback on remove_chart_from_dashboard

- Fix ruff E501: shorten _call_remove docstring to ≤88 chars
- Add remove_chart_from_dashboard to FieldPermissionsMiddleware
  TOOL_OBJECT_TYPE_MAP (was missing, unlike add_chart_to_existing_dashboard)
- Add remove_chart_from_dashboard to tool-search-optimization.md mutate
  tools list for documentation consistency
- Add created_on/changed_on to the re-fetch-fallback DashboardInfo path
  so its shape matches the successful re-fetch path
- Add removed_layout_keys=[] and permission_denied=False to the exception
  handler response for a consistent schema across all code paths

Author: aminghadersohi

superset/mcp_service/dashboard/tool/remove_chart_from_dashboard.py

@@ -366,6 +366,8 @@ def remove_chart_from_dashboard(  # noqa: C901 — complexity is structural (lay
                     id=updated_dashboard.id,
                     dashboard_title=updated_dashboard.dashboard_title,
                     published=updated_dashboard.published,
+                    created_on=updated_dashboard.created_on,
+                    changed_on=updated_dashboard.changed_on,
                     chart_count=len(remaining_slices),
                     url=dashboard_url,
                 ),
@@ -439,5 +441,7 @@ def remove_chart_from_dashboard(  # noqa: C901 — complexity is structural (lay
         return RemoveChartFromDashboardResponse(
             dashboard=None,
             dashboard_url=None,
+            removed_layout_keys=[],
+            permission_denied=False,
             error=f"Failed to remove chart from dashboard: {str(e)}",
         )

superset/mcp_service/docs/tool-search-optimization.md

@@ -34,7 +34,7 @@ Superset MCP tools are categorized with tags to help clients configure optimal l
 | `core` | Essential discovery and health tools | `health_check`, `get_instance_info`, `list_charts`, `list_dashboards`, `list_datasets` | Always load |
 | `discovery` | Detailed resource information and schema | `get_chart_info`, `get_dashboard_info`, `get_dataset_info`, `get_schema` | Can defer |
 | `data` | Data retrieval and previews | `get_chart_preview`, `get_chart_data` | Defer |
-| `mutate` | Create/modify resources | `generate_chart`, `update_chart`, `update_chart_preview`, `generate_dashboard`, `add_chart_to_existing_dashboard`, `execute_sql` | Defer |
+| `mutate` | Create/modify resources | `generate_chart`, `update_chart`, `update_chart_preview`, `generate_dashboard`, `add_chart_to_existing_dashboard`, `remove_chart_from_dashboard`, `execute_sql` | Defer |
 | `explore` | URL generation for exploration | `generate_explore_link`, `open_sql_lab_with_context` | Defer |
 
 ## Client Configuration

superset/mcp_service/middleware.py

@@ -1056,6 +1056,7 @@ class FieldPermissionsMiddleware(Middleware):
         "get_dashboard_info": "dashboard",
         "generate_dashboard": "dashboard",
         "add_chart_to_existing_dashboard": "dashboard",
+        "remove_chart_from_dashboard": "dashboard",
     }
 
     async def on_call_tool(

tests/unit_tests/mcp_service/dashboard/tool/test_remove_chart_from_dashboard.py

@@ -256,7 +256,7 @@ def _tabbed_layout() -> dict[str, Any]:
 async def _call_remove(
     mcp_server: object, dashboard_id: int = 1, chart_id: int = 10
 ) -> dict[str, Any]:
-    """Call remove_chart_from_dashboard via the MCP client and return structured content."""
+    """Call remove_chart_from_dashboard via MCP client; return structured content."""
     async with Client(mcp_server) as client:
         result = await client.call_tool(
             "remove_chart_from_dashboard",