[MDEP-794] It is not respecting the includeScope and excludeScope

[jira-importer]

Cristiano Gavião opened MDEP-794 and commented

I'm using the copyDependencies to build a distribution package and I'm getting junit.jar and others on it.

        <plugin>
          <artifactId>maven-dependency-plugin</artifactId>
          <version>3.2.0</version>
          <configuration>
            <excludeClassifiers>sources,javadoc,full,pom</excludeClassifiers>
            <excludeScope>system</excludeScope>
            <includeScope>compile</includeScope>
          </configuration>
        </plugin> 

 

[DEBUG] Configuring mojo org.apache.maven.plugins:maven-dependency-plugin:3.2.0:copy-dependencies from plugin realm ClassRealm[plugin>org.apache.maven.plugins:maven-dependency-plugin:3.2.0, parent: sun.misc.Launcher$AppClassLoader@18b4aac2]
[DEBUG] Configuring mojo 'org.apache.maven.plugins:maven-dependency-plugin:3.2.0:copy-dependencies' with basic configurator -->
[DEBUG]   (f) addParentPoms = false
[DEBUG]   (s) copyPom = false
[DEBUG]   (f) excludeArtifactIds = jdk.tools
[DEBUG]   (f) excludeClassifiers = sources,javadoc,full,pom
[DEBUG]   (f) excludeScope = system
[DEBUG]   (f) excludeTransitive = false
[DEBUG]   (s) failOnMissingClassifierArtifact = false
[DEBUG]   (f) includeScope = compile
[DEBUG]   (s) markersDirectory = C:\Users\cristianoga\git-code\p-stripping\target\dependency-maven-plugin-markers
[DEBUG]   (f) outputAbsoluteArtifactFilename = false
[DEBUG]   (s) outputDirectory = C:\Users\cristianoga\git-code\p-stripping\target\dependency
[DEBUG]   (f) overWriteIfNewer = true
[DEBUG]   (f) overWriteReleases = false
[DEBUG]   (f) overWriteSnapshots = false
[DEBUG]   (s) prependGroupId = false 

[INFO] Copying junit-4.13.2.jar to C:\Users\cristianoga\git-code\p-stripping\target\dependency\junit-4.13.2.jar
[INFO] Copying hamcrest-core-1.3.jar to C:\Users\cristianoga\git-code\p-stripping\target\dependency\hamcrest-core-1.3.jar
[INFO] Copying mockito-core-3.12.4.jar to C:\Users\cristianoga\git-code\p-stripping\target\dependency\mockito-core-3.12.4.jar
[INFO] Copying byte-buddy-1.11.13.jar to C:\Users\cristianoga\git-code\p-stripping\target\dependency\byte-buddy-1.11.13.jar
[INFO] Copying byte-buddy-agent-1.11.13.jar to C:\Users\cristianoga\git-code\p-stripping\target\dependency\byte-buddy-agent-1.11.13.jar
[INFO] Copying objenesis-3.2.jar to C:\Users\cristianoga\git-code\p-stripping\target\dependency\objenesis-3.2.jar
[INFO] Copying dbunit-2.7.2.jar to C:\Users\cristianoga\git-code\p-stripping\target\dependency\dbunit-2.7.2.jar
[INFO] Copying h2-1.4.200.jar to C:\Users\cristianoga\git-code\p-stripping\target\dependency\h2-1.4.200.jar
[INFO] Copying assertj-core-3.21.0.jar to C:\Users\cristianoga\git-code\p-stripping\target\dependency\assertj-core-3.21.0.jar
 

---

Affects: 3.2.0

Attachments:

• Deps.7z (4.64 kB)
• Deps2.7z (6.97 kB)

[jira-importer]

Slawomir Jaranowski commented

can you provide simple project which reproduce it?

[jira-importer]

Slawomir Jaranowski commented

Please also run

mvn dependency:tree -Dverbose 

on your project and share output

[jira-importer]

Cristiano Gavião commented

I'm attaching two simple projects.
Below is the log execution of one of them:

// log
$ mvn package
[INFO] Scanning for projects...
[INFO] 
[INFO] ---------------------------< test:test-deps >---------------------------
[INFO] Building test-deps 0.0.1-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- maven-clean-plugin:3.1.0:clean (default-clean) @ test-deps ---
[INFO] Deleting C:\Users\cristianoga\Downloads\deps\target
[INFO] 
[INFO] --- maven-enforcer-plugin:3.0.0:enforce (enforce) @ test-deps ---
[INFO] 
[INFO] --- maven-resources-plugin:3.2.0:resources (default-resources) @ test-deps ---
[WARNING] Using platform encoding (Cp1252 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] Using 'null' encoding to copy filtered properties files.
[INFO] Copying 0 resource
[INFO] 
[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ test-deps ---
[INFO] Nothing to compile - all classes are up to date
[INFO] 
[INFO] --- maven-resources-plugin:3.2.0:testResources (default-testResources) @ test-deps ---
[WARNING] Using platform encoding (Cp1252 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] Using 'null' encoding to copy filtered properties files.
[INFO] Copying 0 resource
[INFO] 
[INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ test-deps ---
[INFO] Nothing to compile - all classes are up to date
[INFO] 
[INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ test-deps ---
[INFO] 
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ test-deps ---
[INFO] Building jar: C:\Users\cristianoga\Downloads\deps\target\test-deps-0.0.1-SNAPSHOT.jar
[INFO] 
[INFO] --- maven-dependency-plugin:3.2.0:copy-dependencies (copy-dependencies) @ test-deps ---
[INFO] Copying test-deps2-0.0.1-SNAPSHOT.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\test-deps2-0.0.1-SNAPSHOT.jar
[INFO] Copying hbase-client-1.1.2.2.6.5.0-292.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\hbase-client-1.1.2.2.6.5.0-292.jar
[INFO] Copying hbase-annotations-1.1.2.2.6.5.0-292.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\hbase-annotations-1.1.2.2.6.5.0-292.jar
[INFO] Copying tools.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\jdk.tools-1.7.jar
[INFO] Copying log4j-1.2.17.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\log4j-1.2.17.jar
[INFO] Copying hbase-common-1.1.2.2.6.5.0-292.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\hbase-common-1.1.2.2.6.5.0-292.jar
[INFO] Copying commons-collections-3.2.2.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\commons-collections-3.2.2.jar
[INFO] Copying jetty-util-6.1.26.hwx.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\jetty-util-6.1.26.hwx.jar
[INFO] Copying hbase-protocol-1.1.2.2.6.5.0-292.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\hbase-protocol-1.1.2.2.6.5.0-292.jar
[INFO] Copying hadoop-aws-2.7.3.2.6.5.0-292.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\hadoop-aws-2.7.3.2.6.5.0-292.jar
[INFO] Copying aws-java-sdk-s3-1.10.6.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\aws-java-sdk-s3-1.10.6.jar
[INFO] Copying aws-java-sdk-kms-1.10.6.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\aws-java-sdk-kms-1.10.6.jar
[INFO] Copying aws-java-sdk-core-1.10.6.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\aws-java-sdk-core-1.10.6.jar
[INFO] Copying jackson-core-2.2.3.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\jackson-core-2.2.3.jar
[INFO] Copying jackson-databind-2.2.3.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\jackson-databind-2.2.3.jar
[INFO] Copying jackson-annotations-2.2.3.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\jackson-annotations-2.2.3.jar
[INFO] Copying joda-time-2.9.4.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\joda-time-2.9.4.jar
[INFO] Copying commons-codec-1.9.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\commons-codec-1.9.jar
[INFO] Copying commons-io-2.4.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\commons-io-2.4.jar
[INFO] Copying commons-lang-2.6.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\commons-lang-2.6.jar
[INFO] Copying commons-logging-1.2.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\commons-logging-1.2.jar
[INFO] Copying guava-12.0.1.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\guava-12.0.1.jar
[INFO] Copying jsr305-1.3.9.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\jsr305-1.3.9.jar
[INFO] Copying protobuf-java-2.5.0.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\protobuf-java-2.5.0.jar
[INFO] Copying netty-all-4.0.52.Final.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\netty-all-4.0.52.Final.jar
[INFO] Copying zookeeper-3.4.6.2.6.5.0-292.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\zookeeper-3.4.6.2.6.5.0-292.jar
[INFO] Copying slf4j-api-1.6.1.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\slf4j-api-1.6.1.jar
[INFO] Copying slf4j-log4j12-1.6.1.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\slf4j-log4j12-1.6.1.jar
[INFO] Copying htrace-core-3.1.0-incubating.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\htrace-core-3.1.0-incubating.jar
[INFO] Copying jackson-mapper-asl-1.9.13.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\jackson-mapper-asl-1.9.13.jar
[INFO] Copying jackson-core-asl-1.9.13.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\jackson-core-asl-1.9.13.jar
[INFO] Copying jcodings-1.0.8.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\jcodings-1.0.8.jar
[INFO] Copying joni-2.1.2.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\joni-2.1.2.jar
[INFO] Copying hadoop-auth-2.7.3.2.6.5.0-292.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\hadoop-auth-2.7.3.2.6.5.0-292.jar
[INFO] Copying httpclient-4.5.2.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\httpclient-4.5.2.jar
[INFO] Copying httpcore-4.4.4.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\httpcore-4.4.4.jar
[INFO] Copying nimbus-jose-jwt-4.41.1.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\nimbus-jose-jwt-4.41.1.jar
[INFO] Copying jcip-annotations-1.0-1.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\jcip-annotations-1.0-1.jar
[INFO] Copying json-smart-1.3.1.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\json-smart-1.3.1.jar
[INFO] Copying apacheds-kerberos-codec-2.0.0-M15.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\apacheds-kerberos-codec-2.0.0-M15.jar
[INFO] Copying apacheds-i18n-2.0.0-M15.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\apacheds-i18n-2.0.0-M15.jar
[INFO] Copying api-asn1-api-1.0.0-M20.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\api-asn1-api-1.0.0-M20.jar
[INFO] Copying api-util-1.0.0-M20.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\api-util-1.0.0-M20.jar
[INFO] Copying curator-framework-2.7.1.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\curator-framework-2.7.1.jar
[INFO] Copying hadoop-common-2.7.3.2.6.5.0-292.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\hadoop-common-2.7.3.2.6.5.0-292.jar
[INFO] Copying hadoop-annotations-2.7.3.2.6.5.0-292.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\hadoop-annotations-2.7.3.2.6.5.0-292.jar
[INFO] Copying commons-cli-1.2.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\commons-cli-1.2.jar
[INFO] Copying commons-math3-3.1.1.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\commons-math3-3.1.1.jar
[INFO] Copying xmlenc-0.52.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\xmlenc-0.52.jar
[INFO] Copying commons-net-3.1.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\commons-net-3.1.jar
[INFO] Copying jetty-sslengine-6.1.26.hwx.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\jetty-sslengine-6.1.26.hwx.jar
[INFO] Copying azure-storage-5.4.0.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\azure-storage-5.4.0.jar
[INFO] Copying commons-lang3-3.4.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\commons-lang3-3.4.jar
[INFO] Copying azure-keyvault-core-0.8.0.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\azure-keyvault-core-0.8.0.jar
[INFO] Copying commons-configuration-1.6.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\commons-configuration-1.6.jar
[INFO] Copying commons-digester-1.8.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\commons-digester-1.8.jar
[INFO] Copying commons-beanutils-1.7.0.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\commons-beanutils-1.7.0.jar
[INFO] Copying commons-beanutils-core-1.8.0.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\commons-beanutils-core-1.8.0.jar
[INFO] Copying avro-1.7.4.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\avro-1.7.4.jar
[INFO] Copying paranamer-2.3.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\paranamer-2.3.jar
[INFO] Copying snappy-java-1.0.4.1.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\snappy-java-1.0.4.1.jar
[INFO] Copying gson-2.2.4.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\gson-2.2.4.jar
[INFO] Copying jsch-0.1.54.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\jsch-0.1.54.jar
[INFO] Copying curator-client-2.7.1.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\curator-client-2.7.1.jar
[INFO] Copying curator-recipes-2.7.1.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\curator-recipes-2.7.1.jar
[INFO] Copying commons-compress-1.4.1.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\commons-compress-1.4.1.jar
[INFO] Copying xz-1.0.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\xz-1.0.jar
[INFO] Copying hadoop-mapreduce-client-core-2.7.3.2.6.5.0-292.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\hadoop-mapreduce-client-core-2.7.3.2.6.5.0-292.jar
[INFO] Copying hadoop-yarn-common-2.7.3.2.6.5.0-292.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\hadoop-yarn-common-2.7.3.2.6.5.0-292.jar
[INFO] Copying hadoop-yarn-api-2.7.3.2.6.5.0-292.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\hadoop-yarn-api-2.7.3.2.6.5.0-292.jar
[INFO] Copying jaxb-api-2.2.2.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\jaxb-api-2.2.2.jar
[INFO] Copying stax-api-1.0-2.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\stax-api-1.0-2.jar
[INFO] Copying activation-1.1.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\activation-1.1.jar
[INFO] Copying jersey-client-1.9.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\jersey-client-1.9.jar
[INFO] Copying netty-3.6.2.Final.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\netty-3.6.2.Final.jar
[INFO] Copying findbugs-annotations-1.3.9-1.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\findbugs-annotations-1.3.9-1.jar
[INFO] Copying junit-4.12.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\junit-4.12.jar
[INFO] Copying hamcrest-core-1.3.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\hamcrest-core-1.3.jar
[INFO] Copying log4j-api-2.17.1.jar to C:\Users\cristianoga\Downloads\deps\target\dependency\log4j-api-2.17.1.jar
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  7.244 s
[INFO] Finished at: 2022-02-28T17:15:57Z
[INFO] ------------------------------------------------------------------------
 

[jira-importer]

Cristiano Gavião commented

[^Deps.7z]

 

sjaranowski , let me know if you can reproduce the issue with those simple projects.

[jira-importer]

Cristiano Gavião commented

Could anyone give me a feedback on this, please?

[jira-importer]

Slawomir Jaranowski commented

Can you simplify your example project a little?
Should only contains minimal dependencies list, no profiles no configurations for other plugin.

eg. 

After execute  mvn dependency:tree in deps2 I have ...

ERROR] Failed to execute goal on project test-deps2: Could not resolve dependencies for project test:test-deps2:jar:0.0.1-SNAPSHOT: 
Could not find artifact org.apache.hbase:hbase-client:jar:1.1.2.2.6.5.0-292 in central (https://repo.maven.apache.org/maven2) 

[jira-importer]

Cristiano Gavião commented

Hi sjaranowski , strangely I didn't receive a notification for your comment. 
I've added a new archive with a simplified project. I've used the 'hbase-client' because it has a system dependency that is being copied.

[jira-importer]

Cristiano Gavião commented

sjaranowski , any news ?

[jira-importer]

Slawomir Jaranowski commented

Example projects still contains many staff what is not needed to reproduce your issue ... as I guess.
Should only contains configuration for maven-dependency-plugin.
Example project should not contains target directory, empty directory and configuration for external tools like for eclispe.

It will be the best if dependency contains one artifact which should be copied and one which should not be copied.

[jira-importer]

Slawomir Jaranowski commented

There is a it test https://github.com/apache/maven-dependency-plugin/tree/master/src/it/projects/copy-dependencies
We can create another one similar to this with your case