fix(linear): recover owning issue id for comments and history

eduardoarantes · claude · eduardoarantes · commit 55dbfefb4a43 · 2026-06-03T14:52:47.000+10:00
The GraphQL collector stores the query variables (which carry issueId) in the
raw row's input column, but the comment and history extractors parsed it as
{"Id":...} (SimpleLinearIssue.Id), so the owning issue id came out empty and
the convertor joins produced zero domain comments/changelogs on real data. The
e2e fixtures hand-wrote {"Id":...}, masking it. Parse issueId (with an Id
fallback) and update the fixtures to the real collector shape.

Co-Authored-By: Claude Opus 4.8 (1M context) &lt;noreply@anthropic.com&gt;
Signed-off-by: Eduardo Rodrigues &lt;2961314+eduardoarantes@users.noreply.github.com&gt;
diff --git a/backend/plugins/linear/e2e/raw_tables/_raw_linear_comments.csv b/backend/plugins/linear/e2e/raw_tables/_raw_linear_comments.csv
@@ -1,4 +1,4 @@
 id,params,data,url,input,created_at
-1,"{""ConnectionId"":1,""TeamId"":""team-1""}","{""Id"":""comment-1"",""Body"":""Looking into this"",""CreatedAt"":""2026-05-02T10:00:00Z"",""UpdatedAt"":""2026-05-02T10:00:00Z"",""User"":{""Id"":""user-2""}}",https://api.linear.app/graphql,"{""Id"":""issue-1""}",2026-05-02 10:00:00.000
-2,"{""ConnectionId"":1,""TeamId"":""team-1""}","{""Id"":""comment-2"",""Body"":""Fixed in PR 42"",""CreatedAt"":""2026-05-03T09:00:00Z"",""UpdatedAt"":""2026-05-03T09:30:00Z"",""User"":{""Id"":""user-1""}}",https://api.linear.app/graphql,"{""Id"":""issue-1""}",2026-05-03 09:00:00.000
-3,"{""ConnectionId"":1,""TeamId"":""team-1""}","{""Id"":""comment-3"",""Body"":""Any update?"",""CreatedAt"":""2026-05-02T11:00:00Z"",""UpdatedAt"":""2026-05-02T11:00:00Z"",""User"":{""Id"":""user-1""}}",https://api.linear.app/graphql,"{""Id"":""issue-2""}",2026-05-02 11:00:00.000
+1,"{""ConnectionId"":1,""TeamId"":""team-1""}","{""Id"":""comment-1"",""Body"":""Looking into this"",""CreatedAt"":""2026-05-02T10:00:00Z"",""UpdatedAt"":""2026-05-02T10:00:00Z"",""User"":{""Id"":""user-2""}}",https://api.linear.app/graphql,"{""issueId"":""issue-1""}",2026-05-02 10:00:00.000
+2,"{""ConnectionId"":1,""TeamId"":""team-1""}","{""Id"":""comment-2"",""Body"":""Fixed in PR 42"",""CreatedAt"":""2026-05-03T09:00:00Z"",""UpdatedAt"":""2026-05-03T09:30:00Z"",""User"":{""Id"":""user-1""}}",https://api.linear.app/graphql,"{""issueId"":""issue-1""}",2026-05-03 09:00:00.000
+3,"{""ConnectionId"":1,""TeamId"":""team-1""}","{""Id"":""comment-3"",""Body"":""Any update?"",""CreatedAt"":""2026-05-02T11:00:00Z"",""UpdatedAt"":""2026-05-02T11:00:00Z"",""User"":{""Id"":""user-1""}}",https://api.linear.app/graphql,"{""issueId"":""issue-2""}",2026-05-02 11:00:00.000
diff --git a/backend/plugins/linear/e2e/raw_tables/_raw_linear_issue_history.csv b/backend/plugins/linear/e2e/raw_tables/_raw_linear_issue_history.csv
@@ -1,4 +1,4 @@
 id,params,data,url,input,created_at
-1,"{""ConnectionId"":1,""TeamId"":""team-1""}","{""Id"":""hist-1"",""CreatedAt"":""2026-05-01T08:00:00Z"",""Actor"":{""Id"":""user-2""},""FromState"":{""Id"":""state-backlog"",""Name"":""Backlog"",""Type"":""backlog""},""ToState"":{""Id"":""state-todo"",""Name"":""Todo"",""Type"":""unstarted""}}",https://api.linear.app/graphql,"{""Id"":""issue-1""}",2026-05-01 08:00:00.000
-2,"{""ConnectionId"":1,""TeamId"":""team-1""}","{""Id"":""hist-2"",""CreatedAt"":""2026-05-02T00:00:00Z"",""Actor"":{""Id"":""user-1""},""FromState"":{""Id"":""state-todo"",""Name"":""Todo"",""Type"":""unstarted""},""ToState"":{""Id"":""state-inprogress"",""Name"":""In Progress"",""Type"":""started""}}",https://api.linear.app/graphql,"{""Id"":""issue-1""}",2026-05-02 00:00:00.000
-3,"{""ConnectionId"":1,""TeamId"":""team-1""}","{""Id"":""hist-3"",""CreatedAt"":""2026-05-03T00:00:00Z"",""Actor"":{""Id"":""user-1""},""FromState"":{""Id"":""state-inprogress"",""Name"":""In Progress"",""Type"":""started""},""ToState"":{""Id"":""state-done"",""Name"":""Done"",""Type"":""completed""}}",https://api.linear.app/graphql,"{""Id"":""issue-1""}",2026-05-03 00:00:00.000
+1,"{""ConnectionId"":1,""TeamId"":""team-1""}","{""Id"":""hist-1"",""CreatedAt"":""2026-05-01T08:00:00Z"",""Actor"":{""Id"":""user-2""},""FromState"":{""Id"":""state-backlog"",""Name"":""Backlog"",""Type"":""backlog""},""ToState"":{""Id"":""state-todo"",""Name"":""Todo"",""Type"":""unstarted""}}",https://api.linear.app/graphql,"{""issueId"":""issue-1""}",2026-05-01 08:00:00.000
+2,"{""ConnectionId"":1,""TeamId"":""team-1""}","{""Id"":""hist-2"",""CreatedAt"":""2026-05-02T00:00:00Z"",""Actor"":{""Id"":""user-1""},""FromState"":{""Id"":""state-todo"",""Name"":""Todo"",""Type"":""unstarted""},""ToState"":{""Id"":""state-inprogress"",""Name"":""In Progress"",""Type"":""started""}}",https://api.linear.app/graphql,"{""issueId"":""issue-1""}",2026-05-02 00:00:00.000
+3,"{""ConnectionId"":1,""TeamId"":""team-1""}","{""Id"":""hist-3"",""CreatedAt"":""2026-05-03T00:00:00Z"",""Actor"":{""Id"":""user-1""},""FromState"":{""Id"":""state-inprogress"",""Name"":""In Progress"",""Type"":""started""},""ToState"":{""Id"":""state-done"",""Name"":""Done"",""Type"":""completed""}}",https://api.linear.app/graphql,"{""issueId"":""issue-1""}",2026-05-03 00:00:00.000
diff --git a/backend/plugins/linear/tasks/comment_collector.go b/backend/plugins/linear/tasks/comment_collector.go
@@ -34,7 +34,23 @@ const RAW_COMMENTS_TABLE = "linear_comments"
 // of child resources (comments, history). Its JSON form is stored in the raw
 // row's `input` column so extractors can recover the owning issue id.
 type SimpleLinearIssue struct {
-	Id string
+	// Id is populated by the DalCursorIterator (the _tool_linear_issues.id column)
+	// when driving per-issue child collection.
+	Id string `json:"Id"`
+	// IssueId is populated when parsing a raw row's `input` column: the GraphQL
+	// collector stores the query variables there (which carry `issueId`), not the
+	// iterator element. OwningIssueId resolves whichever is present.
+	IssueId string `json:"issueId" gorm:"-"`
+}
+
+// OwningIssueId returns the issue id this child row belongs to, tolerating both
+// the iterator element shape ({"Id":...}) and the collector's stored variables
+// shape ({"issueId":...}).
+func (s SimpleLinearIssue) OwningIssueId() string {
+	if s.IssueId != "" {
+		return s.IssueId
+	}
+	return s.Id
 }
 
 // GraphqlQueryCommentWrapper is the per-issue, paginated `comments` query.
diff --git a/backend/plugins/linear/tasks/comment_extractor.go b/backend/plugins/linear/tasks/comment_extractor.go
@@ -60,7 +60,7 @@ func ExtractComments(taskCtx plugin.SubTaskContext) errors.Error {
 			comment := &models.LinearComment{
 				ConnectionId: data.Options.ConnectionId,
 				Id:           apiComment.Id,
-				IssueId:      issueRef.Id,
+				IssueId:      issueRef.OwningIssueId(),
 				Body:         apiComment.Body,
 				CreatedAt:    apiComment.CreatedAt,
 				UpdatedAt:    apiComment.UpdatedAt,
diff --git a/backend/plugins/linear/tasks/issue_history_extractor.go b/backend/plugins/linear/tasks/issue_history_extractor.go
@@ -59,7 +59,7 @@ func ExtractIssueHistory(taskCtx plugin.SubTaskContext) errors.Error {
 			event := &models.LinearIssueHistory{
 				ConnectionId: data.Options.ConnectionId,
 				Id:           apiEvent.Id,
-				IssueId:      issueRef.Id,
+				IssueId:      issueRef.OwningIssueId(),
 				CreatedAt:    apiEvent.CreatedAt,
 			}
 			if apiEvent.Actor != nil {

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ func ExtractIssueHistory(taskCtx plugin.SubTaskContext) errors.Error {`
`59`	`59`	`event := &models.LinearIssueHistory{`
`60`	`60`	`ConnectionId: data.Options.ConnectionId,`
`61`	`61`	`Id: apiEvent.Id,`
`62`		`- IssueId: issueRef.Id,`
	`62`	`+ IssueId: issueRef.OwningIssueId(),`
`63`	`63`	`CreatedAt: apiEvent.CreatedAt,`
`64`	`64`	`}`
`65`	`65`	`if apiEvent.Actor != nil {`