fix(argocd): resolve repo_url at extraction time for reliable cicd_deployment_commits

Previously cicd_deployment_commits.repo_url was populated by reading
application.RepoURL in convertSyncOperations. For multi-source apps
_tool_argocd_applications.repo_url is empty when extractApplications
is skipped (DevLake's collector state cache omits it when no new
application raw data has been collected), causing the repo_url field
to fall back to the deployment-name placeholder and breaking DevLake's
commits_diff to PR linkage for DORA Lead Time metrics.

Fix: resolve the git repo URL during extractSyncOperations, which
always runs regardless of collector state. The resolved URL is stored
in a new ArgocdSyncOperation.RepoURL field and used as the primary
source in convertSyncOperations, with application.RepoURL as fallback.

Changes:
- models/sync_operation.go: add RepoURL varchar(500) field
- models/migrationscripts/: add migration 20260331 to ADD COLUMN
- tasks/sync_operation_extractor.go:
  - add resolveGitRepoURL(singleSourceURL, sources): prefers known
    git-hosting URLs from sources[], falls back to first non-chart URL
  - populate syncOp.RepoURL after revision resolution
- tasks/sync_operation_convertor.go: use syncOp.RepoURL first, then
  application.RepoURL, then deployment name as last resort
- tasks/sync_operation_extractor_test.go: 6 new tests for
  resolveGitRepoURL covering single-source, multi-source, fallback,
  all-chart, and empty inputs

Author: Vemula Anvesh

backend/plugins/argocd/models/migrationscripts/20260331_add_repo_url_to_sync_operations.go

@@ -0,0 +1,54 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements.  See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License.  You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package migrationscripts
+
+import (
+	"github.com/apache/incubator-devlake/core/context"
+	"github.com/apache/incubator-devlake/core/errors"
+	"github.com/apache/incubator-devlake/core/plugin"
+)
+
+var _ plugin.MigrationScript = (*addRepoURLToSyncOperations)(nil)
+
+type addRepoURLToSyncOperations struct{}
+
+// addRepoURLSyncOpArchived is a snapshot of ArgocdSyncOperation used solely
+// for this migration so the live model can evolve independently.
+type addRepoURLSyncOpArchived struct {
+	ConnectionId    uint64 `gorm:"primaryKey"`
+	ApplicationName string `gorm:"primaryKey;type:varchar(255)"`
+	DeploymentId    int64  `gorm:"primaryKey"`
+	RepoURL         string `gorm:"type:varchar(500)"`
+}
+
+func (addRepoURLSyncOpArchived) TableName() string {
+	return "_tool_argocd_sync_operations"
+}
+
+func (m *addRepoURLToSyncOperations) Up(basicRes context.BasicRes) errors.Error {
+	db := basicRes.GetDal()
+	return db.AutoMigrate(&addRepoURLSyncOpArchived{})
+}
+
+func (*addRepoURLToSyncOperations) Version() uint64 {
+	return 20260331000000
+}
+
+func (*addRepoURLToSyncOperations) Name() string {
+	return "argocd add repo_url to sync operations"
+}

backend/plugins/argocd/models/migrationscripts/register.go

@@ -25,5 +25,6 @@ func All() []plugin.MigrationScript {
 	return []plugin.MigrationScript{
 		new(addInitTables),
 		new(addImageSupportArtifacts),
+		new(addRepoURLToSyncOperations),
 	}
 }

backend/plugins/argocd/models/sync_operation.go

@@ -28,6 +28,7 @@ type ArgocdSyncOperation struct {
 	ApplicationName string `gorm:"primaryKey;type:varchar(255)"`
 	DeploymentId    int64  `gorm:"primaryKey"`        // History ID from ArgoCD
 	Revision        string `gorm:"type:varchar(255)"` // Git SHA
+	RepoURL         string `gorm:"type:varchar(500)"` // Git repo URL resolved from source/sources at extraction time
 	Kind            string `gorm:"type:varchar(100)"` // Kubernetes resource kind: Deployment, ReplicaSet, Rollout, StatefulSet, DaemonSet, etc.
 	StartedAt       *time.Time
 	FinishedAt      *time.Time

backend/plugins/argocd/tasks/sync_operation_convertor.go

@@ -137,8 +137,14 @@ func ConvertSyncOperations(taskCtx plugin.SubTaskContext) errors.Error {
 			results = append(results, deployment)
 
 			if syncOp.Revision != "" {
+				// Priority: repo_url resolved at extraction time (always present for
+				// multi-source apps) → application-level repo_url → deployment name
+				// as a last-resort non-empty placeholder.
 				repoUrl := deployment.Name
-				if application != nil && application.RepoURL != "" {
+				switch {
+				case syncOp.RepoURL != "":
+					repoUrl = syncOp.RepoURL
+				case application != nil && application.RepoURL != "":
 					repoUrl = application.RepoURL
 				}
 

backend/plugins/argocd/tasks/sync_operation_extractor.go

@@ -197,6 +197,12 @@ func ExtractSyncOperations(taskCtx plugin.SubTaskContext) errors.Error {
 				return nil, nil
 			}
 
+			// Resolve the git repo URL at extraction time so the convertor can set
+			// cicd_deployment_commits.repo_url correctly even when
+			// _tool_argocd_applications.repo_url is empty (e.g. for multi-source apps
+			// whose collectApplications subtask was skipped due to state caching).
+			syncOp.RepoURL = resolveGitRepoURL(apiOp.Source.RepoURL, apiOp.Sources)
+
 			if isOperationState {
 				start := normalize(apiOp.StartedAt)
 				if start != nil {
@@ -469,6 +475,52 @@ func isGitHostedURL(repoURL string) bool {
 	return strings.HasSuffix(strings.TrimSpace(repoURL), ".git")
 }
 
+// resolveGitRepoURL returns the best git repository URL from a sync operation's
+// source metadata. For single-source apps the source.repoURL is used directly.
+// For multi-source apps (sources[]) the first URL that matches a known git
+// hosting service is preferred; if none match the heuristic, the first non-chart
+// HTTPS/SSH URL is used as a fallback so that cicd_deployment_commits.repo_url
+// is never left as the deployment-name placeholder.
+//
+// This is called during extractSyncOperations which always runs, providing
+// reliable repo_url population even when extractApplications is skipped due
+// to the collector state cache.
+func resolveGitRepoURL(singleSourceURL string, sources []ArgocdApiSyncSource) string {
+	// Single-source app: use the URL directly.
+	if singleSourceURL != "" {
+		return singleSourceURL
+	}
+
+	// Multi-source app: pass 1 — prefer a known git host.
+	for _, src := range sources {
+		if isGitHostedURL(src.RepoURL) {
+			return src.RepoURL
+		}
+	}
+
+	// Pass 2 — fall back to the first non-chart URL (covers self-hosted instances
+	// not in the known-host list, e.g. on-prem GitLab with a custom domain).
+	chartPrefixes := []string{"gs://", "oci://", "s3://"}
+	for _, src := range sources {
+		if src.RepoURL == "" {
+			continue
+		}
+		lower := strings.ToLower(src.RepoURL)
+		isChart := false
+		for _, pfx := range chartPrefixes {
+			if strings.HasPrefix(lower, pfx) {
+				isChart = true
+				break
+			}
+		}
+		if !isChart {
+			return src.RepoURL
+		}
+	}
+
+	return ""
+}
+
 // isCommitSHA returns true for a 40-character lowercase hexadecimal string,
 // which is the standard representation of a Git commit SHA-1.
 func isCommitSHA(s string) bool {

backend/plugins/argocd/tasks/sync_operation_extractor_test.go

@@ -147,6 +147,59 @@ func TestIsCommitSHA(t *testing.T) {
 	assert.False(t, isCommitSHA("5dd95b4efd7e9b668c361bbddb8d7f1e56c32ac12")) // 41 chars
 }
 
+// ── resolveGitRepoURL ─────────────────────────────────────────────────────────
+
+func TestResolveGitRepoURL_SingleSource(t *testing.T) {
+	// Single-source app: singleSourceURL is used directly, sources ignored.
+	got := resolveGitRepoURL("https://github.com/example/my-app", nil)
+	assert.Equal(t, "https://github.com/example/my-app", got)
+}
+
+func TestResolveGitRepoURL_MultiSourceGitHubWins(t *testing.T) {
+	// Multi-source pattern: GCS chart + GitHub values ref.
+	sources := []ArgocdApiSyncSource{
+		{RepoURL: "gs://charts-example-net/infra/stable", Chart: "generic-service"},
+		{RepoURL: "https://github.com/example/my-app"},
+	}
+	got := resolveGitRepoURL("", sources)
+	assert.Equal(t, "https://github.com/example/my-app", got)
+}
+
+func TestResolveGitRepoURL_MultiSourceOCIChart(t *testing.T) {
+	// OCI chart + GitLab values repo.
+	sources := []ArgocdApiSyncSource{
+		{RepoURL: "oci://registry.example.com/charts", Chart: "app"},
+		{RepoURL: "https://gitlab.com/org/config"},
+	}
+	got := resolveGitRepoURL("", sources)
+	assert.Equal(t, "https://gitlab.com/org/config", got)
+}
+
+func TestResolveGitRepoURL_FallbackNonChartURL(t *testing.T) {
+	// No known git host but a non-chart HTTPS URL is still better than nothing.
+	sources := []ArgocdApiSyncSource{
+		{RepoURL: "gs://bucket/charts"},
+		{RepoURL: "https://git.acme-corp.internal/team/config"},
+	}
+	got := resolveGitRepoURL("", sources)
+	assert.Equal(t, "https://git.acme-corp.internal/team/config", got)
+}
+
+func TestResolveGitRepoURL_AllChartSources(t *testing.T) {
+	// All sources are chart registries — returns empty string.
+	sources := []ArgocdApiSyncSource{
+		{RepoURL: "gs://charts-example-net/infra/stable"},
+		{RepoURL: "oci://registry.example.com/charts"},
+	}
+	got := resolveGitRepoURL("", sources)
+	assert.Equal(t, "", got)
+}
+
+func TestResolveGitRepoURL_EmptySources(t *testing.T) {
+	assert.Equal(t, "", resolveGitRepoURL("", nil))
+	assert.Equal(t, "", resolveGitRepoURL("", []ArgocdApiSyncSource{}))
+}
+
 // ── isGitHostedURL ────────────────────────────────────────────────────────────
 
 func TestIsGitHostedURL(t *testing.T) {