feat: add NewAdapterWithPool() (#37)

* feat: add pool adapter

* fix: add missing key

* docs: add pool adapter example

Author: marcozac

README.md

@@ -26,6 +26,10 @@ func main() {
 	// Use the following if you use Redis with a specific user 
 	// a, err := redisadapter.NewAdapterWithUser("tcp", "127.0.0.1:6379", "username", "password")
 
+	// Use the following if you use Redis connections pool
+	// pool := &redis.Pool{}
+	// a, err := redisadapter.NewAdapterWithPool(pool)
+
 	e := casbin.NewEnforcer("examples/rbac_model.conf", a)
 
 	// Load the policy from DB.

adapter.go

@@ -92,6 +92,18 @@ func NewAdapterWithKey(network string, address string, key string) (*Adapter, er
 	return newAdapter(network, address, key, "", "")
 }
 
+// NewAdapterWithPool is the constructor for Adapter.
+func NewAdapterWithPool(pool *redis.Pool) (*Adapter, error) {
+	a := &Adapter{}
+	a.key = "casbin_rules"
+	a.conn = pool.Get()
+
+	// Call the destructor when the object is released.
+	runtime.SetFinalizer(a, finalizer)
+
+	return a, nil
+}
+
 type Option func(*Adapter)
 
 func NewAdpaterWithOption(options ...Option) (*Adapter, error) {

adapter_test.go

@@ -21,6 +21,7 @@ import (
 
 	"github.com/casbin/casbin/v2"
 	"github.com/casbin/casbin/v2/util"
+	"github.com/gomodule/redigo/redis"
 )
 
 func testGetPolicy(t *testing.T, e *casbin.Enforcer, res [][]string) {
@@ -356,7 +357,7 @@ func TestAdapters(t *testing.T) {
 	a, _ := NewAdapter("tcp", "127.0.0.1:6379")
 
 	// Use the following if Redis has password like "123"
-	//a, err := NewAdapterWithPassword("tcp", "127.0.0.1:6379", "123")
+	// a, err := NewAdapterWithPassword("tcp", "127.0.0.1:6379", "123")
 
 	// Use the following if you use Redis with a account
 	// a, err := NewAdapterWithUser("tcp", "127.0.0.1:6379", "testaccount", "userpass")
@@ -369,3 +370,22 @@ func TestAdapters(t *testing.T) {
 	testUpdatePolicies(t, a)
 	testUpdateFilteredPolicies(t, a)
 }
+
+func TestPoolAdapters(t *testing.T) {
+	a, err := NewAdapterWithPool(&redis.Pool{
+		Dial: func() (redis.Conn, error) {
+			return redis.Dial("tcp", "127.0.0.1:6379")
+		},
+	})
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	testSaveLoad(t, a)
+	testAutoSave(t, a)
+	testFilteredPolicy(t, a)
+	testAddPolicies(t, a)
+	testRemovePolicies(t, a)
+	testUpdatePolicies(t, a)
+	testUpdateFilteredPolicies(t, a)
+}