From ed5738a2ec4bb14ecc3aeaa5ca7eb052959bf34c Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Fri, 29 May 2026 05:29:52 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=8E=A8=20Palette:=20Improve=20accessibili?= =?UTF-8?q?ty=20of=20playground=20inputs?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Adds explicit ARIA labels and keyboard focus indicators to the inputs in the playground view. Co-authored-by: aloewright <3641844+aloewright@users.noreply.github.com> --- .Jules/palette.md | 3 +++ apps/quill/client/components/playground-view.tsx | 14 ++++++++++---- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/.Jules/palette.md b/.Jules/palette.md index 7af9e36b..02689eb6 100644 --- a/.Jules/palette.md +++ b/.Jules/palette.md @@ -1,3 +1,6 @@ ## 2025-03-05 - Form controls missing focus indicators and ARIA labels **Learning:** Found that custom search inputs and select dropdowns were using `focus:outline-none` but missing visual focus states, impairing keyboard accessibility. Additionally, they were missing explicit ARIA labels. **Action:** Always ensure any interactive control using `focus:outline-none` has a corresponding `focus-visible:` ring state added (using standard `focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-[var(--strand-color-accent-lede)]`), and verify inputs have `aria-label` or related `aria-labelledby`. +## 2025-05-29 - Missing ARIA labels and focus states on interactive elements in playground +**Learning:** Verified that missing explicit `aria-label` attributes and visually prominent focus states (by stripping with `focus:outline-none`) are a recurring issue for custom inputs and selects, especially those nested inside wrapper components like `` that do not natively handle `htmlFor`. +**Action:** Always add explicit `aria-label` attributes to form elements where the visual label isn't directly bound, and replace `focus:outline-none` with `focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-[var(--strand-color-accent-lede)] focus:outline-none` to ensure keyboard accessibility. diff --git a/apps/quill/client/components/playground-view.tsx b/apps/quill/client/components/playground-view.tsx index 511226b4..bdcdb49c 100644 --- a/apps/quill/client/components/playground-view.tsx +++ b/apps/quill/client/components/playground-view.tsx @@ -295,7 +295,8 @@ export function PlaygroundView({
setPresetSlug(e.target.value as UseCase | "")} value={presetSlug} > @@ -326,7 +328,8 @@ export function PlaygroundView({ setTemperature(Number.parseFloat(e.target.value))} @@ -341,7 +344,8 @@ export function PlaygroundView({