Merge branch 'dev'

Author: alcalyn

.gitignore

@@ -4,4 +4,3 @@ composer.lock
 
 # Others
 *~
-nbproject

AlcalynPayplugBundle.php

@@ -6,8 +6,6 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Alcalyn\PayplugBundle\DependencyInjection\Compiler\RegisterMappingsPass;
 use Doctrine\Bundle\DoctrineBundle\DependencyInjection\Compiler\DoctrineOrmMappingsPass;
-use Doctrine\Bundle\MongoDBBundle\DependencyInjection\Compiler\DoctrineMongoDBMappingsPass;
-use Doctrine\Bundle\CouchDBBundle\DependencyInjection\Compiler\DoctrineCouchDBMappingsPass;
 
 class AlcalynPayplugBundle extends Bundle
 {

DependencyInjection/Compiler/RegisterMappingsPass.php

@@ -9,12 +9,38 @@
 
 class RegisterMappingsPass implements CompilerPassInterface
 {
+    /**
+     * @var Definition|Reference
+     */
     private $driver;
+    
+    /**
+     * @var string
+     */
     private $driverPattern;
+    
+    /**
+     * @var array
+     */
     private $namespaces;
+    
+    /**
+     * @var array
+     */
     private $managerParameters;
+    
+    /**
+     * @var mixed false or parameter name
+     */
     private $enabledParameter;
 
+    /**
+     * @param Definition $driver
+     * @param string $driverPattern
+     * @param array $namespaces
+     * @param string[] $managerParameters
+     * @param mixed $enabledParameter
+     */
     public function __construct($driver, $driverPattern, $namespaces, $managerParameters, $enabledParameter = false)
     {
         $this->driver = $driver;
@@ -24,6 +50,9 @@ public function __construct($driver, $driverPattern, $namespaces, $managerParame
         $this->enabledParameter = $enabledParameter;
     }
 
+    /**
+     * @param ContainerBuilder $container
+     */
     public function process(ContainerBuilder $container)
     {
         if ($this->enabledParameter && !$container->hasParameter($this->enabledParameter)) {
@@ -37,6 +66,13 @@ public function process(ContainerBuilder $container)
         }
     }
 
+    /**
+     * @param ContainerBuilder $container
+     * 
+     * @return string
+     * 
+     * @throws ParameterNotFoundException
+     */
     protected function getChainDriverServiceName(ContainerBuilder $container)
     {
         foreach ($this->managerParameters as $param) {
@@ -51,6 +87,11 @@ protected function getChainDriverServiceName(ContainerBuilder $container)
         throw new ParameterNotFoundException('None of the managerParameters resulted in a valid name');
     }
 
+    /**
+     * @param array $mappings
+     * 
+     * @return \Alcalyn\PayplugBundle\DependencyInjection\Compiler\RegisterMappingsPass
+     */
     public static function createOrmMappingDriver(array $mappings)
     {
         $arguments = array($mappings, '.orm.yml');

DependencyInjection/Configuration.php

@@ -4,7 +4,6 @@
 
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
 use Symfony\Component\Config\Definition\ConfigurationInterface;
-use Alcalyn\PayplugBundle\Model\Payment;
 use Alcalyn\PayplugBundle\Model\IPN;
 
 /**

Exceptions/PayplugException.php

@@ -4,6 +4,9 @@
 
 class PayplugException extends \Exception
 {
+    /**
+     * @param string $message
+     */
     public function __construct($message)
     {
         parent::__construct($message, null, null);

Exceptions/PayplugUndefinedAccountParameterException.php

@@ -4,6 +4,9 @@
 
 class PayplugUndefinedAccountParameterException extends PayplugException
 {
+    /**
+     * @param string $missingParameter
+     */
     public function __construct($missingParameter)
     {
         parent::__construct(sprintf('Payplug account parameter "%s" is needed but not set.', $missingParameter));

Model/IPN.php

@@ -2,8 +2,6 @@
 
 namespace Alcalyn\PayplugBundle\Model;
 
-use Doctrine\ORM\Mapping as ORM;
-
 /**
  * IPN
  * 

README.md

@@ -3,6 +3,9 @@ AlcalynPayplugBundle
 
 [Payplug](https://www.payplug.fr/) integration to symfony2.
 
+[![Scrutinizer Code Quality](https://scrutinizer-ci.com/g/alcalyn/payplug-bundle/badges/quality-score.png?b=master)](https://scrutinizer-ci.com/g/alcalyn/payplug-bundle/?branch=master)
+[![SensioLabsInsight](https://insight.sensiolabs.com/projects/5db1af60-63e4-40a6-bb5a-671725d9ac73/mini.png)](https://insight.sensiolabs.com/projects/5db1af60-63e4-40a6-bb5a-671725d9ac73)
+
 ## Installation
 
 

Resources/config/doctrine/model/IPN.orm.yml

@@ -11,4 +11,3 @@ Alcalyn\PayplugBundle\Model\IPN:
             type: integer
             column: id_transaction
             nullable: true
-            

Services/PayplugIPNService.php

@@ -56,7 +56,7 @@ public function verifyIPNRequest(Request $request)
     public function verifyIPN($body, $signature)
     {
         $publicKey = openssl_pkey_get_public($this->payplugPublicKey);
-        return openssl_verify($body, $signature, $publicKey, OPENSSL_ALGO_SHA1);
+        return 1 === openssl_verify($body, $signature, $publicKey, OPENSSL_ALGO_SHA1);
     }
 
     /**