Merge pull request #31 from hhy827/fix/issue-30-subelement-dispatch

fix(oxml): use _append_child for cell/run text + run-style modifier (closes #30)

Author: airmang

src/hwpx/oxml/document.py

@@ -2031,17 +2031,21 @@ def _size_element(self) -> ET.Element:
     def _ensure_text_element(self) -> ET.Element:
         sublist = self.element.find(f"{_HP}subList")
         if sublist is None:
-            sublist = ET.SubElement(self.element, f"{_HP}subList", _default_sublist_attributes())
+            sublist = _append_child(
+                self.element, f"{_HP}subList", _default_sublist_attributes()
+            )
         paragraph = sublist.find(f"{_HP}p")
         if paragraph is None:
-            paragraph = ET.SubElement(sublist, f"{_HP}p", _default_cell_paragraph_attributes())
+            paragraph = _append_child(
+                sublist, f"{_HP}p", _default_cell_paragraph_attributes()
+            )
         _clear_paragraph_layout_cache(paragraph)
         run = paragraph.find(f"{_HP}run")
         if run is None:
-            run = ET.SubElement(paragraph, f"{_HP}run", {"charPrIDRef": "0"})
+            run = _append_child(paragraph, f"{_HP}run", {"charPrIDRef": "0"})
         text = run.find(f"{_HP}t")
         if text is None:
-            text = ET.SubElement(run, f"{_HP}t")
+            text = _append_child(run, f"{_HP}t")
         return text
 
     @property
@@ -4536,9 +4540,9 @@ def modifier(element: ET.Element) -> None:
                 element.remove(child)
 
             if target[0]:
-                ET.SubElement(element, f"{_HH}bold")
+                _append_child(element, f"{_HH}bold")
             if target[1]:
-                ET.SubElement(element, f"{_HH}italic")
+                _append_child(element, f"{_HH}italic")
 
             underline_attrs = dict(base_underline_attrs)
             if target[2]:
@@ -4550,14 +4554,14 @@ def modifier(element: ET.Element) -> None:
                     underline_attrs["color"] = base_underline_attrs["color"]
                 if "color" not in underline_attrs:
                     underline_attrs["color"] = "#000000"
-                ET.SubElement(element, f"{_HH}underline", underline_attrs)
+                _append_child(element, f"{_HH}underline", underline_attrs)
             else:
                 attrs = dict(base_underline_attrs)
                 attrs["type"] = "NONE"
                 attrs.setdefault("shape", base_underline_attrs.get("shape", "SOLID"))
                 if "color" in base_underline_attrs:
                     attrs["color"] = base_underline_attrs["color"]
-                ET.SubElement(element, f"{_HH}underline", attrs)
+                _append_child(element, f"{_HH}underline", attrs)
 
         element = header.ensure_char_property(
             predicate=predicate,

tests/test_document_formatting.py

@@ -750,3 +750,47 @@ def test_paragraph_add_shape_and_control_updates_attributes() -> None:
     control.set_attribute("id", None)
     assert control.get_attribute("id") is None
     assert section.dirty is True
+
+
+# ---------------------------------------------------------------------------
+# Regression: issue #30 — stdlib ET.SubElement called on lxml _Element
+# https://github.com/airmang/python-hwpx/issues/30
+# ---------------------------------------------------------------------------
+
+
+def test_issue_30_set_cell_text_on_blank_cell() -> None:
+    """Setting ``cell.text`` on a cell that lacks ``<hp:subList>/<hp:p>/<hp:run>``
+    must not raise ``TypeError``.
+
+    Before the fix, ``HwpxOxmlTableCell._ensure_text_element`` used
+    ``ET.SubElement`` (stdlib) on ``self.element`` which is an
+    ``lxml.etree._Element``. This reproduces the call path reported by
+    ``@devnoff`` in issue #30 and by downstream consumers running
+    ``table.set_cell_text(...)`` on freshly created tables.
+    """
+
+    document = HwpxDocument.new()
+    table = document.add_table(rows=2, cols=2)
+
+    # Both the explicit API and the property setter must succeed.
+    table.set_cell_text(0, 0, "hello")
+    cells = list(table.rows[1].cells)
+    cells[1].text = "world"
+
+    assert table.rows[0].cells[0].text == "hello"
+    assert table.rows[1].cells[1].text == "world"
+
+
+def test_issue_30_add_run_bold() -> None:
+    """``paragraph.add_run(text, bold=True)`` must not raise ``TypeError``.
+
+    Before the fix, ``ensure_run_style``'s ``modifier`` closure called
+    ``ET.SubElement(element, ...)`` where ``element`` is an lxml element.
+    This is the original reproduction from the body of issue #30.
+    """
+
+    document = HwpxDocument.new()
+    paragraph = document.add_paragraph("")
+    run = paragraph.add_run("hello", bold=True)
+
+    assert run.text == "hello"