Skip to content

Commit 0d4c5e3

Browse files
acailicclaude
andcommitted
refactor: remove dead ranking module and unused feature tests
- Delete collector/ranking/ (replaced by compute.py functions) - Remove dead ranking imports from intelligence facade - Extract severity weights to module-level constant in causal_analysis.py - Delete test_feature_2/3/5 (testing features that don't exist) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent de1e4df commit 0d4c5e3

8 files changed

Lines changed: 21 additions & 1736 deletions

File tree

collector/causal_analysis.py

Lines changed: 19 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -8,29 +8,31 @@
88

99
from .intelligence.helpers import event_value as _event_value
1010

11+
DEFAULT_SEVERITY_WEIGHTS: dict[EventType, float] = {
12+
EventType.ERROR: 1.0,
13+
EventType.POLICY_VIOLATION: 0.96,
14+
EventType.REFUSAL: 0.92,
15+
EventType.BEHAVIOR_ALERT: 0.88,
16+
EventType.SAFETY_CHECK: 0.8,
17+
EventType.DECISION: 0.72,
18+
EventType.CHECKPOINT: 0.65,
19+
EventType.TOOL_RESULT: 0.58,
20+
EventType.LLM_RESPONSE: 0.52,
21+
EventType.PROMPT_POLICY: 0.48,
22+
EventType.AGENT_TURN: 0.44,
23+
EventType.TOOL_CALL: 0.4,
24+
EventType.LLM_REQUEST: 0.35,
25+
EventType.AGENT_START: 0.2,
26+
EventType.AGENT_END: 0.2,
27+
}
28+
1129

1230
class CausalAnalyzer:
1331
"""Walk the event graph to surface the most likely upstream causes of failures."""
1432

1533
def __init__(self, severity_weights: dict[EventType, float] | None = None) -> None:
1634
if severity_weights is None:
17-
severity_weights = {
18-
EventType.ERROR: 1.0,
19-
EventType.POLICY_VIOLATION: 0.96,
20-
EventType.REFUSAL: 0.92,
21-
EventType.BEHAVIOR_ALERT: 0.88,
22-
EventType.SAFETY_CHECK: 0.8,
23-
EventType.DECISION: 0.72,
24-
EventType.CHECKPOINT: 0.65,
25-
EventType.TOOL_RESULT: 0.58,
26-
EventType.LLM_RESPONSE: 0.52,
27-
EventType.PROMPT_POLICY: 0.48,
28-
EventType.AGENT_TURN: 0.44,
29-
EventType.TOOL_CALL: 0.4,
30-
EventType.LLM_REQUEST: 0.35,
31-
EventType.AGENT_START: 0.2,
32-
EventType.AGENT_END: 0.2,
33-
}
35+
severity_weights = DEFAULT_SEVERITY_WEIGHTS
3436
self.severity_weights = severity_weights
3537

3638
# ------------------------------------------------------------------

collector/intelligence/facade.py

Lines changed: 2 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,11 @@
88

99
from agent_debugger_sdk.core.events import Checkpoint, EventType, TraceEvent
1010

11-
from ..causal_analysis import CausalAnalyzer
11+
from ..causal_analysis import DEFAULT_SEVERITY_WEIGHTS, CausalAnalyzer
1212
from ..clustering import FailureClusterAnalyzer
1313
from ..failure_diagnostics import FailureDiagnostics
1414
from ..highlights import generate_highlights
1515
from ..live_monitor import LiveMonitor
16-
from ..ranking import CheckpointRankingService, EventRankingService
1716
from .compute import (
1817
compute_checkpoint_rankings,
1918
compute_event_ranking,
@@ -34,8 +33,6 @@ class TraceIntelligence:
3433
- :class:`~collector.clustering.failure_clusters.FailureClusterAnalyzer`
3534
- :class:`~collector.failure_diagnostics.FailureDiagnostics`
3635
- :class:`~collector.live_monitor.LiveMonitor`
37-
- :class:`~collector.ranking.event_ranker.EventRankingService`
38-
- :class:`~collector.ranking.checkpoint_ranker.CheckpointRankingService`
3936
4037
The public API is unchanged so all callers continue to work without
4138
modification.
@@ -45,33 +42,11 @@ class TraceIntelligence:
4542

4643
def __post_init__(self) -> None:
4744
if self.severity_weights is None:
48-
self.severity_weights = {
49-
EventType.ERROR: 1.0,
50-
EventType.POLICY_VIOLATION: 0.96,
51-
EventType.REFUSAL: 0.92,
52-
EventType.BEHAVIOR_ALERT: 0.88,
53-
EventType.SAFETY_CHECK: 0.8,
54-
EventType.DECISION: 0.72,
55-
EventType.CHECKPOINT: 0.65,
56-
EventType.TOOL_RESULT: 0.58,
57-
EventType.LLM_RESPONSE: 0.52,
58-
EventType.PROMPT_POLICY: 0.48,
59-
EventType.AGENT_TURN: 0.44,
60-
EventType.TOOL_CALL: 0.4,
61-
EventType.LLM_REQUEST: 0.35,
62-
EventType.AGENT_START: 0.2,
63-
EventType.AGENT_END: 0.2,
64-
}
45+
self.severity_weights = DEFAULT_SEVERITY_WEIGHTS
6546
self._causal = CausalAnalyzer(self.severity_weights)
6647
self._clusterer = FailureClusterAnalyzer()
6748
self._diagnostics = FailureDiagnostics(self._causal)
6849
self._monitor = LiveMonitor()
69-
self._event_ranker = EventRankingService(
70-
causal_analyzer=self._causal,
71-
fingerprint_fn=self.fingerprint,
72-
severity_fn=self.severity,
73-
)
74-
self._checkpoint_ranker = CheckpointRankingService()
7550

7651
# ------------------------------------------------------------------
7752
# Public API methods (delegate to submodules or provide utilities)

collector/ranking/__init__.py

Lines changed: 0 additions & 4 deletions
This file was deleted.

collector/ranking/checkpoint_ranker.py

Lines changed: 0 additions & 75 deletions
This file was deleted.

collector/ranking/event_ranker.py

Lines changed: 0 additions & 115 deletions
This file was deleted.

0 commit comments

Comments
 (0)