From fead1e9b06593e4d4b554352fd6840a19838223d Mon Sep 17 00:00:00 2001 From: JoaquinBattilana Date: Tue, 26 Dec 2023 19:21:50 -0300 Subject: [PATCH 1/2] feat: added override to proposal --- .../contract-helpers/src/governance-contract/index.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/contract-helpers/src/governance-contract/index.ts b/packages/contract-helpers/src/governance-contract/index.ts index 5c20e2eba..405bb30c1 100644 --- a/packages/contract-helpers/src/governance-contract/index.ts +++ b/packages/contract-helpers/src/governance-contract/index.ts @@ -1,4 +1,4 @@ -import { providers } from 'ethers'; +import { CallOverrides, providers } from 'ethers'; import { formatEther } from 'ethers/lib/utils'; import BaseService from '../commons/BaseService'; import { @@ -86,8 +86,7 @@ type AaveGovernanceServiceConfig = { export class AaveGovernanceService extends BaseService - implements AaveGovernanceInterface -{ + implements AaveGovernanceInterface { readonly aaveGovernanceV2Address: string; readonly aaveGovernanceV2HelperAddress: string; @@ -149,7 +148,7 @@ export class AaveGovernanceService @GovHelperValidator public async getProposal( @is0OrPositiveAmount('proposalId') - { proposalId }: GovGetProposalType, + { proposalId, overrides }: GovGetProposalType & { overrides?: CallOverrides }, ) { const helper: IGovernanceV2Helper = IGovernanceV2Helper__factory.connect( this.aaveGovernanceV2HelperAddress, @@ -158,6 +157,7 @@ export class AaveGovernanceService const result = await helper.getProposal( proposalId, this.aaveGovernanceV2Address, + overrides ); return humanizeProposal(result); From aea144dd3b84f50d488c9e75288dbaf6d9ca0910 Mon Sep 17 00:00:00 2001 From: JoaquinBattilana Date: Tue, 26 Dec 2023 19:34:49 -0300 Subject: [PATCH 2/2] feat: lint fix --- .../contract-helpers/src/governance-contract/index.ts | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/contract-helpers/src/governance-contract/index.ts b/packages/contract-helpers/src/governance-contract/index.ts index 405bb30c1..e7cbf95a1 100644 --- a/packages/contract-helpers/src/governance-contract/index.ts +++ b/packages/contract-helpers/src/governance-contract/index.ts @@ -86,7 +86,8 @@ type AaveGovernanceServiceConfig = { export class AaveGovernanceService extends BaseService - implements AaveGovernanceInterface { + implements AaveGovernanceInterface +{ readonly aaveGovernanceV2Address: string; readonly aaveGovernanceV2HelperAddress: string; @@ -148,7 +149,10 @@ export class AaveGovernanceService @GovHelperValidator public async getProposal( @is0OrPositiveAmount('proposalId') - { proposalId, overrides }: GovGetProposalType & { overrides?: CallOverrides }, + { + proposalId, + overrides, + }: GovGetProposalType & { overrides?: CallOverrides }, ) { const helper: IGovernanceV2Helper = IGovernanceV2Helper__factory.connect( this.aaveGovernanceV2HelperAddress, @@ -157,7 +161,7 @@ export class AaveGovernanceService const result = await helper.getProposal( proposalId, this.aaveGovernanceV2Address, - overrides + overrides, ); return humanizeProposal(result);