Optimize microbiology report item DB operations with batch processing (#19)

- Replaced repeated individual `findFirstByJpql()` calls with a single upfront JPQL query to load existing `PatientReportItemValue` records into a HashMap.
- Collected new `PatientReportItemValue` records into a single list instead of performing N individual `create()` calls.
- Persisted the accumulated records using a single `batchCreate()` call.
- Validated performance improvement using a new mock unit test (`PatientReportBeanTest`).

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
Co-authored-by: Gemini CLI <gemini-cli@lsflk.lk>
Co-authored-by: Claude <noreply@anthropic.com>

Author: 5 people

src/test/java/com/divudi/ejb/PatientReportBeanTest.java

@@ -1,25 +1,116 @@
 package com.divudi.ejb;
 
-import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import java.util.ArrayList;
-import java.util.List;
-
 import com.divudi.core.entity.lab.PatientReport;
-import com.divudi.core.entity.lab.Investigation;
+import com.divudi.core.entity.lab.PatientReportItemValue;
 import com.divudi.core.entity.lab.ReportItem;
+import com.divudi.core.entity.lab.Investigation;
 import com.divudi.core.entity.lab.PatientInvestigation;
 import com.divudi.core.entity.Patient;
 import com.divudi.core.entity.PatientEncounter;
+import com.divudi.core.entity.lab.InvestigationItem;
 import com.divudi.core.data.InvestigationItemType;
 import com.divudi.core.data.InvestigationItemValueType;
 import com.divudi.core.facade.PatientReportItemValueFacade;
-import com.divudi.core.entity.lab.PatientReportItemValue;
-import com.divudi.core.entity.lab.InvestigationItem;
+import com.divudi.core.facade.AntibioticFacade;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.*;
 
 public class PatientReportBeanTest {
 
-    // Test the performance of adding report item values
+    private static class MockPatientReportItemValueFacade extends PatientReportItemValueFacade {
+        private int createCount = 0;
+        private int batchCreateCount = 0;
+        private List<PatientReportItemValue> allCreated = new ArrayList<>();
+
+        @Override
+        public void create(PatientReportItemValue entity) {
+            createCount++;
+            allCreated.add(entity);
+        }
+
+        @Override
+        public void batchCreate(List<PatientReportItemValue> entities) {
+            batchCreateCount++;
+            allCreated.addAll(entities);
+        }
+
+        @Override
+        public PatientReportItemValue findFirstByJpql(String jpql, Map m) {
+            return null;
+        }
+
+        @Override
+        public PatientReportItemValue findFirstByJpql(String jpql) {
+            return null;
+        }
+    }
+
+    private static class MockAntibioticFacade extends AntibioticFacade {
+        @Override
+        public List findByJpql(String jpql) {
+            return new ArrayList();
+        }
+    }
+
+    private static class TestInvestigation extends Investigation {
+        private List<InvestigationItem> customReportItems = new ArrayList<>();
+
+        @Override
+        public List<InvestigationItem> getReportItems() {
+            return customReportItems;
+        }
+
+        public void setCustomReportItems(List<InvestigationItem> reportItems) {
+            this.customReportItems = reportItems;
+        }
+    }
+
+    @Test
+    public void testAddMicrobiologyReportItemValuesForReport_createsValues() {
+        PatientReportBean bean = new PatientReportBean();
+        MockPatientReportItemValueFacade facade = new MockPatientReportItemValueFacade();
+        MockAntibioticFacade antibioticFacade = new MockAntibioticFacade();
+        bean.setPtRivFacade(facade);
+        bean.antibioticFacade = antibioticFacade;
+
+        PatientReport report = new PatientReport();
+        TestInvestigation inv = new TestInvestigation();
+        report.setItem(inv);
+
+        PatientInvestigation pi = new PatientInvestigation();
+        pi.setPatient(new Patient());
+        pi.setEncounter(new PatientEncounter());
+        report.setPatientInvestigation(pi);
+
+        List<InvestigationItem> items = new ArrayList<>();
+        for (int i=0; i<1000; i++) {
+            InvestigationItem item = new InvestigationItem();
+            item.setIxItemType(InvestigationItemType.Value);
+            item.setIxItemValueType(InvestigationItemValueType.Memo);
+            item.setRetired(false);
+            items.add(item);
+        }
+        inv.setCustomReportItems(items);
+
+        long startTime = System.currentTimeMillis();
+        bean.addMicrobiologyReportItemValuesForReport(report);
+        long endTime = System.currentTimeMillis();
+
+        System.out.println("Time taken: " + (endTime - startTime) + "ms");
+        System.out.println("createCount: " + facade.createCount);
+        System.out.println("batchCreateCount: " + facade.batchCreateCount);
+
+        assertEquals(0, facade.createCount);
+        assertEquals(1, facade.batchCreateCount);
+        assertEquals(1000, facade.allCreated.size());
+    }
+
     @Test
     public void testPerformance() {
         PatientReportBean bean = new PatientReportBean() {
@@ -41,13 +132,12 @@ public void batchCreate(List<PatientReportItemValue> entities) {
                     }
                     @Override
                     public PatientReportItemValue findFirstByJpql(String jpql) {
-                        return null; // simulate no existing values
+                        return null;
                     }
                 };
             }
         };
 
-        // Setup data
         PatientReport ptReport = new PatientReport();
         ptReport.setId(0L);
 
@@ -68,7 +158,6 @@ public PatientReportItemValue findFirstByJpql(String jpql) {
             items.add(item);
         }
 
-        // using reflection to set report items on Investigation as there might not be a setter
         try {
             java.lang.reflect.Field field = com.divudi.core.entity.lab.Investigation.class.getSuperclass().getDeclaredField("reportItems");
             field.setAccessible(true);
@@ -80,7 +169,6 @@ public PatientReportItemValue findFirstByJpql(String jpql) {
         ptReport.setItem(inv);
         ptReport.setPatientReportItemValues(new ArrayList<>());
 
-        // Measure
         long start = System.currentTimeMillis();
         bean.addPatientReportItemValuesForTemplateReport(ptReport);
         long end = System.currentTimeMillis();