Merge pull request #94 from Zektopic/sentinel/fix-mock-assertion-ssrf-16557653444664257341

🛡️ Sentinel: [MEDIUM] Fix test suite SSRF mock bypass

Author: manupawickramasinghe

test_testping1.py

@@ -12,14 +12,17 @@ def test_is_reachable_success(self, mock_call):
         mock_call.return_value = 0
 
         self.assertTrue(is_reachable('8.8.8.8'))
+        mock_call.assert_called_once()
 
     @patch('testping1.subprocess.call')
     def test_is_reachable_failure(self, mock_call):
         """Test is_reachable returns False for a failed ping."""
         # Simulate a failed ping response by returning a non-zero exit code
         mock_call.return_value = 1
 
-        self.assertFalse(is_reachable('10.0.0.1'))
+        # 🛡️ Sentinel: Use a public IP to ensure SSRF blocklist doesn't bypass network logic test
+        self.assertFalse(is_reachable('8.8.4.4'))
+        mock_call.assert_called_once()
 
     @patch('testping1.subprocess.call')
     def test_is_reachable_invalid_ip_format(self, mock_call):