Skip to content

Commit 1ed27db

Browse files
committed
fix: remove too activate validators from the new super-linter
1 parent 8bc8046 commit 1ed27db

6 files changed

Lines changed: 15 additions & 22 deletions

File tree

.github/linters/conf/constants.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?php
22

33
/**
4-
* Predefining constants for PHPSTAN analysis as recommanded by
4+
* Predefining constants for PHPSTAN analysis as recommended by
55
* https://phpstan.org/user-guide/discovering-symbols
66
*
77
* add `define('PREDEFINED_CONSTANT', 'value');` as needed on top of conf/config.php and conf/config.local.dist.php

.github/linters/zizmor.yaml

Lines changed: 0 additions & 13 deletions
This file was deleted.

.github/workflows/linter.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,15 @@ jobs:
7575
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
7676
#JAVASCRIPT_ES_CONFIG_FILE: .eslintrc.yml
7777
VALIDATE_ANSIBLE: false
78+
VALIDATE_BIOME_FORMAT: false
79+
VALIDATE_BIOME_LINT: false
7880
VALIDATE_CSS: false
7981
# TODO 211017 returns false positive `unknown Webhook event "workflow_call"`
8082
VALIDATE_GITHUB_ACTIONS: false
8183
# TODO 211003 returns false positive: {"line":" <li><a href=\"https://www.linkedin.com/company/MYCMSPROJECTSPECIFIC\" title=\"{=\"MYCMSPROJECTSPECIFIC na LinkedIn\"|translate}\"><i class=\"fa fa-linkedin\" aria-hidden=\"true\"></i></a></li>","lineNumber":56,"offender":"linkedin.com/company/MYCMSPROJECTSPECIFIC","offenderEntropy":-1,"commit":"","repo":"","repoURL":"","leakURL":"","rule":"LinkedIn Secret Key","commitMessage":"","author":"","email":"","file":".","date":"0001-01-01T00:00:00Z","tags":"secret, LinkedIn"}
8284
VALIDATE_GITLEAKS: false
85+
# Prettier is applied anyway and I don't want to have `.eslintrc.yml` configured
86+
VALIDATE_JAVASCRIPT_ES: false
8387
# 240803, there's no way to configure JAVASCRIPT_PRETTIER, neither it shows what exactly an issue is. Just 'Code style issue found in file.', which is useless.
8488
VALIDATE_JAVASCRIPT_PRETTIER: false
8589
#VALIDATE_JAVASCRIPT_STANDARD: false
@@ -90,3 +94,5 @@ jobs:
9094
VALIDATE_PHP_PSALM: false
9195
# 240519 .shfmt is not taken into account, so far
9296
VALIDATE_SHELL_SHFMT: false
97+
# Let's leave SPELL_CODESPELL to seablast-actions, where it is configurable
98+
VALIDATE_SPELL_CODESPELL: false

CHANGELOG.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ feat!: Admin UI can be rendered by Latte & filtering and sorting of tables fixed
141141

142142
- fix filtering and sorting of tables in Admin UI
143143
- Admin UI can be rendered by Latte (instead directly from MyAdmin methods) if $featureFlags['admin_latte_render'] set to true (still experimental because the main part of body is prerendered as HTML)
144-
- DivisionProducts, Pages, Products, Translations, `Urls` admin pages are generated in AdminModel classes invoked within Admin::controller (instead as spaghetti code within Admin::projectSpecificSections) (Feature flag 'legacy_admin_methods_instead_of_admin_models' => true forces execution of the old spagetti code)
144+
- DivisionProducts, Pages, Products, Translations, `Urls` admin pages are generated in AdminModel classes invoked within Admin::controller (instead as spaghetti code within Admin::projectSpecificSections) (Feature flag 'legacy_admin_methods_instead_of_admin_models' => true forces execution of the old spaghetti code)
145145
- where Translations and `Urls` admin page generation is moved to the the core so that further improvements are automatically available to the Apps using updated version of MyCMS
146146
- **BREAKING CHANGE (feature flagged)** if $featureFlags['admin_latte_render']===false `dist/styles/admin.css.php` MUST be present (to link rel `admin.css` deep in vendor folder) and admin.php code has to be updated to alternatively use the latte rendering and toggle admin menu special links
147147

@@ -155,7 +155,7 @@ feat!: Admin UI can be rendered by Latte & filtering and sorting of tables fixed
155155
- instead of simply {include $latte} call {include 'inherite.latte', latte => $latte} so that the preferred existing version of latte is used
156156
- new parameter to MyCustomFilters allows for another translate method (in order to use $tableAdmin->translate instead of $MyCMS->translate for Admin UI)
157157
- featureFlags to `admin-*.latte`
158-
- DivisionProducts, Pages, Products, Translations, `Urls` admin pages are generated in AdminModel classes invoked within Admin::controller (instead as spaghetti code within Admin::projectSpecificSections) (Feature flag 'legacy_admin_methods_instead_of_admin_models' => true forces execution of the old spagetti code)
158+
- DivisionProducts, Pages, Products, Translations, `Urls` admin pages are generated in AdminModel classes invoked within Admin::controller (instead as spaghetti code within Admin::projectSpecificSections) (Feature flag 'legacy_admin_methods_instead_of_admin_models' => true forces execution of the old spaghetti code)
159159

160160
### Changed
161161

@@ -204,10 +204,10 @@ refactor!: Less files in the application root folder
204204

205205
- **BREAKING CHANGE** dist/Test/AdminTest.php TableAdmin declaration expects language and prefixL10n
206206
- **BREAKING CHANGE** dist/Test/ControllerTest.php MUST accomodate language both in GET and `_SESSION` as the checks are stricter in L10n
207-
- App class handles the request dispatching instead of spagetti code in index.php
207+
- App class handles the request dispatching instead of spaghetti code in index.php
208208
- L10n (Localisation) class with loadLocalisation and translate methods common both for admin UI and MyCMS UI (instead of include php file with array for web UI and parsing yml for admin UI)
209209
- dist/Admin::sectionTranslations uses new L10n class instead of including language.inc.php file directly
210-
- MyAdminProcess::processTranslationsUpdate method created instead of code being spagetti part of dist/AdminProcess::adminProcess
210+
- MyAdminProcess::processTranslationsUpdate method created instead of code being spaghetti part of dist/AdminProcess::adminProcess
211211

212212
### Deprecated
213213

@@ -573,7 +573,7 @@ to
573573

574574
## [0.3.6] - 2018-09-20
575575

576-
- fix environment dependant CAST(AS)
576+
- fix environment dependent CAST(AS)
577577

578578
## [0.3.5] - 2018-09-20
579579

dist/classes/Admin.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
* (Last MyCMS/dist revision: 2026-02-28, v0.5.1)
1919
*
2020
* Feature flag 'legacy_admin_methods_instead_of_admin_models' => true can turn off the new AdminModels
21-
* in favour of the legacy spagetti code within this class
21+
* in favour of the legacy spaghetti code within this class
2222
*/
2323
class Admin extends MyAdmin
2424
{

dist/classes/TableAdmin.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ public function customInput($field, $value, array $record = [])
4141
$fieldLang = '##';
4242
$fieldName = $field;
4343
if (substr($field, -3, 1) === '_' && in_array(substr($field, -2), array_keys($this->TRANSLATIONS))) {
44-
// Localised fields may have language independant behaviour, so switch below handles type dependant code
45-
// Language dependant conditions can however be added as well in separate switch
44+
// Localised fields may have language independent behaviour, so switch below handles type dependent code
45+
// Language dependent conditions can however be added as well in separate switch
4646
$fieldLang = substr($field, -2); // language of the field
4747
$fieldName = substr($field, 0, -2) . '##';
4848
}

0 commit comments

Comments
 (0)