Skip to content

Commit 393184e

Browse files
committed
Fix test
FAIL routes/dashboard/widget-dashboard/test/staging.test.tsx ● WidgetDashboard staging layer › grid settings staging › publishes both layout and settings on commit expect(jest.fn()).toHaveBeenCalledTimes(expected) Expected number of calls: 1 Received number of calls: 0 364 | 365 | expect( onLayoutChange ).toHaveBeenCalledTimes( 1 ); > 366 | expect( onGridSettingsChange ).toHaveBeenCalledTimes( 1 ); | ^ 367 | expect( onGridSettingsChange.mock.calls[ 0 ][ 0 ] ).toMatchObject( { 368 | model: 'masonry', 369 | } ); at Object.toHaveBeenCalledTimes (routes/dashboard/widget-dashboard/test/staging.test.tsx:366:35)
1 parent 41bd370 commit 393184e

2 files changed

Lines changed: 8 additions & 6 deletions

File tree

routes/dashboard/widget-dashboard/context/dashboard-context.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ export function WidgetDashboardProvider( {
250250
onEditChange,
251251
resolveWidgetModule = DEFAULT_RESOLVE_WIDGET_MODULE,
252252
gridSettings: committedGridSettings = DEFAULT_GRID,
253-
onGridSettingsChange,
253+
onGridSettingsChange: publishCommittedGridSettings,
254254
children,
255255
}: ProviderProps ) {
256256
const [ stagingLayout, setStagingLayout ] =
@@ -308,7 +308,7 @@ export function WidgetDashboardProvider( {
308308
}
309309

310310
if ( hasGridSettingsChanges ) {
311-
onGridSettingsChange?.( stagingGridSettings );
311+
publishCommittedGridSettings?.( stagingGridSettings );
312312
}
313313

314314
if ( options?.exitEditMode !== false ) {
@@ -318,7 +318,7 @@ export function WidgetDashboardProvider( {
318318
[
319319
hasLayoutChanges,
320320
hasGridSettingsChanges,
321-
onGridSettingsChange,
321+
publishCommittedGridSettings,
322322
publishLayout,
323323
stagingLayout,
324324
stagingGridSettings,
@@ -344,14 +344,14 @@ export function WidgetDashboardProvider( {
344344
);
345345

346346
if ( hasGridSettingsChanges ) {
347-
onGridSettingsChange?.( stagingGridSettings );
347+
publishCommittedGridSettings?.( stagingGridSettings );
348348
}
349349

350350
onEditChange?.( false );
351351
},
352352
[
353353
hasGridSettingsChanges,
354-
onGridSettingsChange,
354+
publishCommittedGridSettings,
355355
onEditChange,
356356
publishLayout,
357357
stagingGridSettings,
@@ -374,7 +374,7 @@ export function WidgetDashboardProvider( {
374374
// eslint-disable-next-line react-hooks/exhaustive-deps
375375
}, [ stagingLayout.length === 0 ] );
376376

377-
const canEditGridSettings = onGridSettingsChange !== undefined;
377+
const canEditGridSettings = publishCommittedGridSettings !== undefined;
378378

379379
const value = useMemo< InternalDashboardContextValue >(
380380
() => ( {

routes/dashboard/widget-dashboard/widget-dashboard.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ export const WidgetDashboard = Object.assign(
4848
onEditChange,
4949
resolveWidgetModule,
5050
gridSettings,
51+
onGridSettingsChange,
5152
children,
5253
}: WidgetDashboardProps ) {
5354
return (
@@ -61,6 +62,7 @@ export const WidgetDashboard = Object.assign(
6162
onEditChange={ onEditChange }
6263
resolveWidgetModule={ resolveWidgetModule }
6364
gridSettings={ gridSettings }
65+
onGridSettingsChange={ onGridSettingsChange }
6466
>
6567
<WidgetDashboardUIProvider>
6668
{ children ?? (

0 commit comments

Comments
 (0)