core/content: align the content tests with the instance classes and core

Drive the Content and Show_In_Abilities tests through instances (held on the
test case so the same instance detaches its hooks on tear down) instead of the
old static calls. Bring ContentTest in line with core's wpRegisterCoreContentAbility:
assert show_in_rest + destructive/idempotent annotations on registration, assert
the input schema type and additionalProperties, add output-schema coverage, and
add a test that a post type registered by another active plugin (flagged
show_in_abilities) is exposed in the input enum and in query results.

Author: jorgefilipecosta

tests/Integration/Includes/Abilities/Content/ContentTest.php

@@ -18,6 +18,15 @@
  */
 class ContentTest extends WP_UnitTestCase {
 
+	/**
+	 * The exposure component. Held so the same instance can detach its filters on tear down.
+	 *
+	 * @since x.x.x
+	 *
+	 * @var \WordPress\AI\Abilities\Show_In_Abilities
+	 */
+	private $show_in_abilities;
+
 	/**
 	 * Set up test case.
 	 *
@@ -27,9 +36,15 @@ public function setUp(): void {
 		parent::setUp();
 
 		// Mark the curated core post types (post, page) as exposed to abilities.
-		Show_In_Abilities::register();
+		$this->show_in_abilities = new Show_In_Abilities();
+		$this->show_in_abilities->register();
 
 		$this->ensure_content_category();
+
+		// The plugin also registers the `core/settings` ability (into the `site` category)
+		// on the same abilities-init hook, so make sure that category exists too; otherwise
+		// its registration emits an "incorrect usage" notice that fails this test.
+		$this->ensure_site_category();
 	}
 
 	/**
@@ -42,8 +57,8 @@ public function tearDown(): void {
 			wp_unregister_ability( 'core/content' );
 		}
 
-		remove_filter( 'register_setting_args', array( Show_In_Abilities::class, 'mark_setting' ), 10 );
-		remove_filter( 'register_post_type_args', array( Show_In_Abilities::class, 'mark_post_type' ), 10 );
+		remove_filter( 'register_setting_args', array( $this->show_in_abilities, 'mark_setting' ), 10 );
+		remove_filter( 'register_post_type_args', array( $this->show_in_abilities, 'mark_post_type' ), 10 );
 
 		// Restore the curated post types to their unmarked state to avoid leaking into other tests.
 		foreach ( array( 'post', 'page' ) as $post_type ) {
@@ -85,6 +100,32 @@ private function ensure_content_category(): void {
 		}
 	}
 
+	/**
+	 * Ensures the `site` ability category exists, used by the plugin's `core/settings`
+	 * ability which registers on the same hook as `core/content`.
+	 *
+	 * @since x.x.x
+	 */
+	private function ensure_site_category(): void {
+		if ( wp_has_ability_category( 'site' ) ) {
+			return;
+		}
+
+		global $wp_current_filter;
+		$wp_current_filter[] = 'wp_abilities_api_categories_init'; // phpcs:ignore WordPress.WP.GlobalVariablesOverride.Prohibited -- Faking the action context to register within it.
+		try {
+			wp_register_ability_category(
+				'site',
+				array(
+					'label'       => 'Site',
+					'description' => 'Site.',
+				)
+			);
+		} finally {
+			array_pop( $wp_current_filter );
+		}
+	}
+
 	/**
 	 * Registers the plugin's core/content ability inside a faked init action.
 	 *
@@ -94,7 +135,7 @@ private function register_ability(): void {
 		global $wp_current_filter;
 		$wp_current_filter[] = 'wp_abilities_api_init'; // phpcs:ignore WordPress.WP.GlobalVariablesOverride.Prohibited -- Faking the action context to register within it.
 		try {
-			Content::register();
+			( new Content() )->register();
 		} finally {
 			array_pop( $wp_current_filter );
 		}
@@ -125,9 +166,12 @@ public function test_registers_core_content_ability(): void {
 		$this->assertNotNull( $ability );
 		$this->assertSame( 'core/content', $ability->get_name() );
 		$this->assertSame( 'content', $ability->get_category() );
+		$this->assertTrue( $ability->get_meta_item( 'show_in_rest', false ) );
 
 		$annotations = $ability->get_meta_item( 'annotations', array() );
 		$this->assertTrue( $annotations['readonly'] );
+		$this->assertFalse( $annotations['destructive'] );
+		$this->assertTrue( $annotations['idempotent'] );
 	}
 
 	/**
@@ -172,6 +216,8 @@ public function test_input_schema_requires_id_or_post_type(): void {
 
 		$schema = wp_get_ability( 'core/content' )->get_input_schema();
 
+		$this->assertSame( 'object', $schema['type'] );
+		$this->assertFalse( $schema['additionalProperties'] );
 		$this->assertSame(
 			array(
 				array( 'required' => array( 'id' ) ),
@@ -185,6 +231,62 @@ public function test_input_schema_requires_id_or_post_type(): void {
 		$this->assertContains( 'page', $enum );
 	}
 
+	/**
+	 * The output schema describes each post as an object with no required fields.
+	 *
+	 * @since x.x.x
+	 */
+	public function test_output_schema_has_no_required_post_fields(): void {
+		$this->register_ability();
+
+		$schema    = wp_get_ability( 'core/content' )->get_output_schema();
+		$post_item = $schema['properties']['posts']['items'];
+
+		$this->assertSame( 'object', $post_item['type'] );
+		$this->assertArrayNotHasKey( 'required', $post_item );
+		$this->assertFalse( $post_item['additionalProperties'] );
+		$this->assertArrayHasKey( 'raw_content', $post_item['properties'] );
+		$this->assertArrayHasKey( 'total', $schema['properties'] );
+		$this->assertArrayHasKey( 'total_pages', $schema['properties'] );
+	}
+
+	/**
+	 * A post type registered by another active plugin and flagged `show_in_abilities`
+	 * is exposed by the ability, both in the input enum and in query results.
+	 *
+	 * @since x.x.x
+	 */
+	public function test_exposes_a_post_type_registered_by_another_plugin(): void {
+		register_post_type(
+			'wpai_content_cpt',
+			array(
+				'public'            => true,
+				'show_in_abilities' => true,
+				'supports'          => array( 'title', 'editor' ),
+			)
+		);
+
+		$this->login_as( 'administrator' );
+		$this->register_ability();
+
+		$enum = wp_get_ability( 'core/content' )->get_input_schema()['properties']['post_type']['enum'];
+		$this->assertContains( 'wpai_content_cpt', $enum );
+
+		$post_id = self::factory()->post->create(
+			array(
+				'post_type'   => 'wpai_content_cpt',
+				'post_status' => 'publish',
+			)
+		);
+
+		$result = wp_get_ability( 'core/content' )->execute( array( 'post_type' => 'wpai_content_cpt' ) );
+		$ids    = wp_list_pluck( $result['posts'], 'id' );
+
+		$this->assertContains( $post_id, $ids );
+
+		unregister_post_type( 'wpai_content_cpt' );
+	}
+
 	/**
 	 * A published post can be fetched by ID.
 	 *

tests/Integration/Includes/Abilities/Show_In_AbilitiesTest.php

@@ -26,6 +26,15 @@ class Show_In_AbilitiesTest extends WP_UnitTestCase {
 	 */
 	private $registered_options = array();
 
+	/**
+	 * The component under test. Held so the same instance can detach its filters on tear down.
+	 *
+	 * @since x.x.x
+	 *
+	 * @var \WordPress\AI\Abilities\Show_In_Abilities
+	 */
+	private $show_in_abilities;
+
 	/**
 	 * Set up test case.
 	 *
@@ -34,7 +43,8 @@ class Show_In_AbilitiesTest extends WP_UnitTestCase {
 	public function setUp(): void {
 		parent::setUp();
 
-		Show_In_Abilities::register();
+		$this->show_in_abilities = new Show_In_Abilities();
+		$this->show_in_abilities->register();
 	}
 
 	/**
@@ -43,8 +53,8 @@ public function setUp(): void {
 	 * @since x.x.x
 	 */
 	public function tearDown(): void {
-		remove_filter( 'register_setting_args', array( Show_In_Abilities::class, 'mark_setting' ), 10 );
-		remove_filter( 'register_post_type_args', array( Show_In_Abilities::class, 'mark_post_type' ), 10 );
+		remove_filter( 'register_setting_args', array( $this->show_in_abilities, 'mark_setting' ), 10 );
+		remove_filter( 'register_post_type_args', array( $this->show_in_abilities, 'mark_post_type' ), 10 );
 
 		foreach ( $this->registered_options as $option ) {
 			unregister_setting( 'group', $option );
@@ -146,7 +156,7 @@ public function test_respects_existing_value(): void {
 	 * @since x.x.x
 	 */
 	public function test_marks_curated_registered_post_types(): void {
-		// Show_In_Abilities::register() ran in setUp and patches existing post types.
+		// $this->show_in_abilities->register() ran in setUp and patches existing post types.
 		$this->assertNotEmpty( get_post_type_object( 'post' )->show_in_abilities );
 		$this->assertNotEmpty( get_post_type_object( 'page' )->show_in_abilities );
 	}
@@ -157,7 +167,7 @@ public function test_marks_curated_registered_post_types(): void {
 	 * @since x.x.x
 	 */
 	public function test_filter_marks_curated_post_type(): void {
-		$args = Show_In_Abilities::mark_post_type( array(), 'page' );
+		$args = $this->show_in_abilities->mark_post_type( array(), 'page' );
 
 		$this->assertTrue( $args['show_in_abilities'] );
 	}
@@ -168,7 +178,7 @@ public function test_filter_marks_curated_post_type(): void {
 	 * @since x.x.x
 	 */
 	public function test_filter_skips_uncurated_post_type(): void {
-		$args = Show_In_Abilities::mark_post_type( array(), 'wpai_not_curated_cpt' );
+		$args = $this->show_in_abilities->mark_post_type( array(), 'wpai_not_curated_cpt' );
 
 		$this->assertTrue( empty( $args['show_in_abilities'] ) );
 	}
@@ -179,7 +189,7 @@ public function test_filter_skips_uncurated_post_type(): void {
 	 * @since x.x.x
 	 */
 	public function test_filter_respects_existing_post_type_value(): void {
-		$args = Show_In_Abilities::mark_post_type(
+		$args = $this->show_in_abilities->mark_post_type(
 			array( 'show_in_abilities' => array( 'custom' => true ) ),
 			'post'
 		);