driver: remove fixed codeql suppressions

I fixed the CodeQL rules.

Link: microsoft/Windows-Driver-Developer-Supplemental-Tools#217
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Author: zx2c4

driver/ioctl.c

@@ -625,8 +625,6 @@ ReadLogLine(_In_ DEVICE_OBJECT *DeviceObject, _Inout_ IRP *Irp)
         Irp->IoStatus.Information = sizeof(WG_IOCTL_LOG_ENTRY);
 }
 
-#pragma prefast(push)
-#pragma prefast(disable : cpp/drivers/invalid-function-class-typedef) /* It's fine to make this paged because it's only ever called from userspace. */
 _Dispatch_type_(IRP_MJ_DEVICE_CONTROL)
 static DRIVER_DISPATCH_PAGED DispatchDeviceControl;
 _Use_decl_annotations_
@@ -655,7 +653,6 @@ DispatchDeviceControl(DEVICE_OBJECT *DeviceObject, IRP *Irp)
     IoCompleteRequest(Irp, IO_NO_INCREMENT);
     return Status;
 }
-#pragma prefast(pop)
 
 _Dispatch_type_(IRP_MJ_CREATE)
 static DRIVER_DISPATCH DispatchCreate;
@@ -696,8 +693,6 @@ DispatchPnp(DEVICE_OBJECT *DeviceObject, IRP *Irp)
 #ifdef ALLOC_PRAGMA
 #    pragma alloc_text(INIT, IoctlDriverEntry)
 #endif
-#pragma prefast(push)
-#pragma prefast(disable : cpp/drivers/illegal-field-access-2) /* This is a driver entry routine; we've just split them up. */
 _Use_decl_annotations_
 VOID
 IoctlDriverEntry(DRIVER_OBJECT *DriverObject)
@@ -709,4 +704,3 @@ IoctlDriverEntry(DRIVER_OBJECT *DriverObject)
     DriverObject->MajorFunction[IRP_MJ_CREATE] = DispatchCreate;
     DriverObject->MajorFunction[IRP_MJ_PNP] = DispatchPnp;
 }
-#pragma prefast(pop)

driver/nsi.c

@@ -147,8 +147,6 @@ TryBuildMTURow(_In_ IRP *Irp, _Out_ MIB_IPINTERFACE_ROW *Row)
     return TRUE;
 }
 
-#pragma prefast(push)
-#pragma prefast(disable : cpp/drivers/invalid-function-class-typedef) /* It's fine to make this paged because it's only ever called from userspace. */
 static DRIVER_DISPATCH_PAGED FilterDispatch;
 _Use_decl_annotations_
 static NTSTATUS
@@ -173,7 +171,6 @@ FilterDispatch(DEVICE_OBJECT *DeviceObject, IRP *Irp)
     ExReleaseRundownProtection(&FilterRundown);
     return Status;
 }
-#pragma prefast(pop)
 
 static NTSTATUS
 Attach(VOID)
@@ -236,8 +233,6 @@ Detach(VOID)
 #ifdef ALLOC_PRAGMA
 #    pragma alloc_text(INIT, NsiDriverEntry)
 #endif
-#pragma prefast(push)
-#pragma prefast(disable : cpp/drivers/illegal-field-access-2) /* This is a driver entry routine; we've just split them up. */
 _Use_decl_annotations_
 VOID
 NsiDriverEntry(DRIVER_OBJECT *DriverObject)
@@ -252,7 +247,6 @@ NsiDriverEntry(DRIVER_OBJECT *DriverObject)
         DriverObject->MajorFunction[i] = FilterDispatch;
     }
 }
-#pragma prefast(pop)
 
 _Use_decl_annotations_
 NTSTATUS

driver/rcu.c

@@ -107,7 +107,6 @@ __RcuCall(_Inout_ RCU_CALLBACK *Head)
     KeAcquireInStackQueuedSpinLock(&Cleanup.Lock, &LockHandle);
     *(Cleanup.Tail ? &Cleanup.Tail->Next : &Cleanup.Head) = Head;
     Cleanup.Tail = Head;
-#pragma prefast(suppress : cpp/drivers/irql-too-high) /* The last param is FALSE, so the max level is 2, not 1. */
     KeSetEvent(&Cleanup.WorkPending, IO_NO_INCREMENT, FALSE);
     KeReleaseInStackQueuedSpinLock(&LockHandle);
 }

driver/rcu.h

@@ -44,8 +44,6 @@ struct _RCU_CALLBACK
     };
 };
 
-#pragma prefast(push)
-#pragma prefast(disable : cpp/drivers/irql-annotation-issue) /* The annotations are copied directly from KeRaiseIrqlToDpcLevel. */
 _IRQL_requires_max_(DISPATCH_LEVEL)
 _IRQL_saves_
 _IRQL_raises_(DISPATCH_LEVEL)
@@ -55,7 +53,6 @@ static inline KIRQL RcuReadLock(VOID)
     _Analysis_assume_rcu_acquired_;
     return KeRaiseIrqlToDpcLevel();
 }
-#pragma prefast(pop)
 
 _IRQL_requires_max_(DISPATCH_LEVEL)
 _Releases_rcu_