Avoid duplicate HTTP view registration on reload.

Home Assistant keeps PlainResource routes for the process lifetime, so unload now clears tracked views and setup skips paths that are already registered.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: Wheemer

custom_components/ip_ban_manager/__init__.py

@@ -1187,8 +1187,35 @@ async def post(self, request: Request) -> Response:
         return self.json(_panel_payload(hass, entry))
 
 
+def _integration_view_urls() -> set[str]:
+    """Return the HTTP paths owned by IP Ban Manager."""
+    return {
+        url
+        for url in (
+            SilenceAllowlistedLoginNotificationsView.url,
+            IPBanManagerStatusView.url,
+            IPBanManagerManageView.url,
+        )
+        if url
+    }
+
+
+def _registered_integration_view_urls(hass: HomeAssistant) -> set[str]:
+    """Return integration view paths already registered on the HTTP router."""
+    owned_urls = _integration_view_urls()
+    registered_urls = set()
+    for route in hass.http.app.router.routes():
+        resource = route.resource
+        if resource is None:
+            continue
+        canonical = resource.canonical
+        if canonical in owned_urls:
+            registered_urls.add(canonical)
+    return registered_urls
+
+
 def _register_http_views(hass: HomeAssistant) -> None:
-    """Register HTTP API views once per setup cycle."""
+    """Register HTTP API views once per Home Assistant process."""
     if hass.data.get(KEY_HTTP_VIEWS):
         return
 
@@ -1197,34 +1224,17 @@ def _register_http_views(hass: HomeAssistant) -> None:
         IPBanManagerStatusView(),
         IPBanManagerManageView(),
     )
+    registered_urls = _registered_integration_view_urls(hass)
     for view in views:
+        if view.url in registered_urls:
+            continue
         hass.http.register_view(view)
     hass.data[KEY_HTTP_VIEWS] = views
 
 
 def _unregister_http_views(hass: HomeAssistant) -> None:
-    """Remove HTTP API views registered by this integration."""
-    views = hass.data.pop(KEY_HTTP_VIEWS, None)
-    if not views:
-        return
-
-    urls = set()
-    for view in views:
-        if view.url:
-            urls.add(view.url)
-        urls.update(view.extra_urls)
-
-    resources_to_unregister: set[object] = set()
-    for route in hass.http.app.router.routes():
-        resource = route.resource
-        if resource is None:
-            continue
-        if resource.canonical in urls:
-            resources_to_unregister.add(resource)
-
-    for resource in resources_to_unregister:
-        with suppress(ValueError):
-            resource.unregister()
+    """Drop tracked HTTP views without removing Home Assistant routes."""
+    hass.data.pop(KEY_HTTP_VIEWS, None)
 
 
 def _coerce_panel_boolean(value: object) -> bool:

tests/ip_ban_manager/test_setup.py

@@ -2828,7 +2828,7 @@ async def test_unload_restores_home_assistant_hooks(
 async def test_setup_entry_reregisters_http_views_after_unload(
     hass: HomeAssistant, caplog: pytest.LogCaptureFixture
 ) -> None:
-    """Test reloading does not leave duplicate HTTP view routes behind."""
+    """Test reloading does not register duplicate HTTP view routes."""
     await setup_ip_ban_manager(hass)
     entry = hass.config_entries.async_entries(DOMAIN)[0]
     view_urls = {
@@ -2849,12 +2849,14 @@ def count_view_resources() -> int:
 
     assert await hass.config_entries.async_unload(entry.entry_id)
     await hass.async_block_till_done()
-    assert count_view_resources() == 0
+    assert KEY_HTTP_VIEWS not in hass.data
+    assert count_view_resources() == 3
 
     assert await hass.config_entries.async_setup(entry.entry_id)
     await hass.async_block_till_done()
     check_records(caplog.records)
     assert count_view_resources() == 3
+    assert KEY_HTTP_VIEWS in hass.data
 
 
 @pytest.mark.asyncio