Skip to content

fix(HTML Authoring): Disable pasting images#2320

Merged
hirokiterashima merged 1 commit into
developfrom
tinymce-disable-pasting-images
Jun 8, 2026
Merged

fix(HTML Authoring): Disable pasting images#2320
hirokiterashima merged 1 commit into
developfrom
tinymce-disable-pasting-images

Conversation

@hirokiterashima

Copy link
Copy Markdown
Member

Changes

  • Set TinyMCE's paste_data_images option to false to disallow authors from pasting images. This was creating images to be converted to base64 strings, which made the unit large.

Test

Try pasting images in:

  • Display content authoring
  • Student notebook report

@hirokiterashima hirokiterashima self-assigned this Jun 8, 2026
@hirokiterashima hirokiterashima added the bug Something isn't working label Jun 8, 2026
@qltysh

qltysh Bot commented Jun 8, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
New Coverage rating: D
...irectives/wise-tinymce-editor/wise-tinymce-editor.component.ts0.0%161
Total0.0%
🤖 Increase coverage with AI coding...
In the `tinymce-disable-pasting-images` branch, add test coverage for this new code:

- `src/assets/wise5/directives/wise-tinymce-editor/wise-tinymce-editor.component.ts` -- Line 161

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@hirokiterashima hirokiterashima marked this pull request as ready for review June 8, 2026 02:54
@hirokiterashima hirokiterashima merged commit 29f13e3 into develop Jun 8, 2026
4 checks passed
@hirokiterashima hirokiterashima deleted the tinymce-disable-pasting-images branch June 8, 2026 03:33
@hirokiterashima

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 5.232.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant