feat(TeacherTools): Show workgroups in tooltip for Sort summary#2319
Conversation
|
Coverage Impact Unable to calculate total coverage change because base branch coverage was not found. Modified Files with Diff Coverage (3)
🛟 Help
|
hirokiterashima
left a comment
There was a problem hiding this comment.
The new tooltip text works great for both owner and shared owner, but I'm a bit concerned about the hit to the performance this will cause.
The new getWorkgroupNames() function gets called many times. You can see this by adding console.log() in the function and just moving your mouse over the screen. It does the same calculations and returns the same result.
This could cause an issue with a class with many students and many buckets, especially on slower machines. Can we cache the result somewhere- maybe in MatchSummaryDisplayComponent or MatchSummaryDataPoint?
|
@hirokiterashima Ah yes, I agree that could hinder performance. I refactored to cache the workgroup names in the MatchSummaryDisplayComponent. |
hirokiterashima
left a comment
There was a problem hiding this comment.
New changes look good. 👍
|
🎉 This PR is included in version 5.233.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |

Changes
Test