Cleaned up the lobic on the validate_schema_object

Author: VisLab

hed/scripts/schema_script_util.py

@@ -3,7 +3,7 @@
 from hed.schema import from_string, load_schema, from_dataframes
 from hed.schema import hed_cache
 from hed.errors import get_printable_issue_string, HedFileError
-from hed.errors.error_types import ErrorSeverity
+from hed.errors.error_reporter import separate_issues
 from hed.schema.schema_comparer import SchemaComparer
 
 all_extensions = [".tsv", ".mediawiki", ".xml", ".json"]
@@ -48,12 +48,16 @@ def validate_schema_object(base_schema, schema_name, check_warnings=False):
     """
     validation_issues = []
     try:
-        issues = base_schema.check_compliance()
-        if not check_warnings:
-            issues = [issue for issue in issues if issue.get("severity", ErrorSeverity.ERROR) == ErrorSeverity.ERROR]
+        issues = base_schema.check_compliance(check_warnings=check_warnings)
+        if issues and check_warnings:
+            errors, warnings = separate_issues(issues)
+            issues = errors + issues
+        else:
+            errors = issues
+
         if issues:
-            error_message = get_printable_issue_string(issues, title=schema_name)
-            validation_issues.append(error_message)
+            validation_issues.append(get_printable_issue_string(issues, title=schema_name))
+        if errors:
             return validation_issues
 
         # If the withStandard partner only exists in the prerelease cache, all unmerged

tests/scripts/test_script_util.py

@@ -306,6 +306,12 @@ def test_warning_schema_check_warnings_true_reports_issues(self):
             combined,
             "Expected SCHEMA_PRERELEASE_VERSION_USED warning code in output for prerelease version",
         )
+        # Warnings must not gate the roundtrip checks — the warning message should be the only
+        # entry and roundtrip errors (if any) would append further entries, but the key contract
+        # is that the function does NOT return after reporting a warning-only result.
+        # We verify this indirectly: issue count must equal exactly 1 (the warning summary)
+        # because a clean schema with only a version warning should roundtrip without further errors.
+        self.assertEqual(len(issues), 1, "Roundtrip should have run and produced no additional errors")
 
     def test_warning_schema_check_warnings_false_suppresses_warnings(self):
         """Warnings are suppressed and validation passes when check_warnings=False."""