From b667f67527dd2f5a0ee9a5c7a4408af880979638 Mon Sep 17 00:00:00 2001 From: GernotMaier Date: Sun, 4 Oct 2026 19:58:23 +0200 Subject: [PATCH] Fix PR 38 review comments --- release_tests/lookuptable-testing/test_tables.sh | 2 +- release_tests/montecarlo/irf_plotting/irf_plotting.sh | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/release_tests/lookuptable-testing/test_tables.sh b/release_tests/lookuptable-testing/test_tables.sh index 3f81733..6625861 100755 --- a/release_tests/lookuptable-testing/test_tables.sh +++ b/release_tests/lookuptable-testing/test_tables.sh @@ -1,7 +1,7 @@ #!/bin/bash # Supply a reference observation matched to the tables under test. VERSION=$(cat "$VERITAS_EVNDISP_AUX_DIR/IRFVERSION") || exit 1 -TESTFILE=${1:-${TESTFILE:-}} +TESTFILE=${1:-${TESTFILE:-$VERITAS_USER_DATA_DIR/analysis/Results/${VERSION}/Crab/evndisp/64080.root}} [[ -s $TESTFILE ]] || { echo "Usage: $0 (or set TESTFILE)" >&2; exit 1; } ODIR="$VERITAS_USER_DATA_DIR/analysis/Results/$VERSION/table-tests" mkdir -p "$ODIR" || exit 1 diff --git a/release_tests/montecarlo/irf_plotting/irf_plotting.sh b/release_tests/montecarlo/irf_plotting/irf_plotting.sh index 4c096e9..8003a04 100755 --- a/release_tests/montecarlo/irf_plotting/irf_plotting.sh +++ b/release_tests/montecarlo/irf_plotting/irf_plotting.sh @@ -84,13 +84,13 @@ do TESTED=$((TESTED+1)) if [[ -n $COMPAREVERSION ]]; then COMPARESIMTYPE=${COMPARESIMTYPE:-$SIMTYPE} - COMPARECUT=${COMPARECUT:-$CUT} + COMPARE_CUT_FOR_CASE=${COMPARECUT:-$CUT} COMP_IRFDIR=${IRFDIR//"$VERSION"/"$COMPAREVERSION"} COMP_IRFDIR=${COMP_IRFDIR//"$SIMTYPE"/"$COMPARESIMTYPE"} COMP_IRFFILE=${IRFFILE//"$SIMTYPE"/"$COMPARESIMTYPE"} # compare TMVA with XGB file - COMP_IRFDIR=${COMP_IRFDIR//"$CUT"/"$COMPARECUT"} - COMP_IRFFILE=${COMP_IRFFILE//"$CUT"/"$COMPARECUT"} + COMP_IRFDIR=${COMP_IRFDIR//"$CUT"/"$COMPARE_CUT_FOR_CASE"} + COMP_IRFFILE=${COMP_IRFFILE//"$CUT"/"$COMPARE_CUT_FOR_CASE"} echo "COMPIRFDIR (comparison): $COMP_IRFDIR" echo "COMPIRFFILE (comparison): $COMP_IRFFILE" root -l -q -b "plot_irf.C(\"${IRFDIR}\",\"${IRFFILE}\",\"${E}\",\"${A}\",\"${CUT}\",\"${Z}\",\"${W}\",\"${N}\",\"${MCAZ}\",\"${ODIR}\", \"${COMP_IRFDIR}\",\"${COMP_IRFFILE}\")"