Add Deployments to Solidity#16
Closed
jtriley2p wants to merge 5 commits into
Closed
Conversation
Author
|
Also, for development and testing purposes, if any contract is hard-coding their address constants, they can use these directly. import {IPoolManager} from "briefcase/protocols/v4-core/interfaces/IPoolManager.sol";
import {Ethereum} from "briefcase/deployments/Latest.sol";
contract PoolCaller {
IPoolManager pool = IPoolManager(Ethereum.PoolManager);
function run() public {
pool.unlock();
}
// ..
} |
Author
|
closing to potentially add to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a script
sync_deployments.py(no external dependencies) which parses thedeployments/*.jsonfiles and writes respective solidity libraries tosrc/depoyments/*.sol.Each file contains a library named after the network with constants declared internally to be accessed in cleaner, namespaced way.
Why
This is useful for governance scripting where currently address constants are duplicated in each script which opens us up to errors.
Governance Script Example
Current way:
Briefcase Deployment way: