Skip to content

Commit da611f3

Browse files
committed
tidied up action inputs
1 parent c9ad817 commit da611f3

8 files changed

Lines changed: 41 additions & 34 deletions

File tree

.github/actions/android-app-setup/action.yml

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,25 @@
11
name: Setup Android App Build
2-
description: >
3-
Extended setup for Android app build jobs (Alpaka, Play Store, code quality).
4-
Calls android-base-setup and then computes build variables derived from the
5-
flavor and app module inputs.
6-
All inputs must be supplied by the caller — defaults live in the workflow files.
2+
description: Extended setup for Android app build jobs.
73

84
inputs:
95
checkout-token:
10-
description: 'Token used for checkout. Falls back to the default GITHUB_TOKEN if not set.'
11-
default: ${{ github.token }}
6+
description: 'Token used for checkout.'
7+
required: true
128
use-git-lfs:
139
description: 'Use git lfs during repository checkout.'
14-
fetch-depth:
15-
description: 'Number of commits to fetch during checkout.'
10+
required: true
1611
jdk:
1712
description: 'The JDK version to use.'
13+
required: true
1814
setup-rust:
1915
description: 'Whether to set up the Rust toolchain.'
16+
required: true
2017
flavor:
2118
description: 'The build flavor. Used to compute flavor_capitalized.'
19+
required: true
2220
app-module:
2321
description: 'The Gradle app module (e.g. "app" or "android:androidApp").'
22+
required: true
2423

2524
outputs:
2625
flavor_capitalized:
@@ -47,7 +46,6 @@ runs:
4746
with:
4847
checkout-token: ${{ inputs.checkout-token }}
4948
use-git-lfs: ${{ inputs.use-git-lfs }}
50-
fetch-depth: ${{ inputs.fetch-depth }}
5149
jdk: ${{ inputs.jdk }}
5250
setup-rust: ${{ inputs.setup-rust }}
5351

.github/actions/android-base-setup/action.yml

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,21 @@
11
name: Setup Android Environment
22
description: >
33
Base setup for Android CI jobs. Checks out the repository, installs zstd,
4-
optionally sets up a JDK, and optionally sets up the Rust toolchain.
5-
All inputs must be supplied by the caller — defaults live in the workflow files.
4+
sets up a JDK, and optionally sets up the Rust toolchain.
65
76
inputs:
87
checkout-token:
9-
description: 'Token used for checkout. Falls back to the default GITHUB_TOKEN if not set.'
10-
default: ${{ github.token }}
8+
description: 'Token used for checkout.'
9+
required: true
1110
use-git-lfs:
1211
description: 'Use git lfs during repository checkout.'
13-
fetch-depth:
14-
description: 'Number of commits to fetch during checkout.'
15-
setup-jdk:
16-
description: 'Whether to set up a JDK.'
12+
required: true
1713
jdk:
1814
description: 'The JDK version to use.'
15+
required: true
1916
setup-rust:
2017
description: 'Whether to set up the Rust toolchain.'
18+
required: true
2119

2220
runs:
2321
using: composite
@@ -28,10 +26,9 @@ runs:
2826
token: ${{ inputs.checkout-token }}
2927
submodules: 'recursive'
3028
lfs: ${{ inputs.use-git-lfs }}
31-
fetch-depth: ${{ inputs.fetch-depth }}
29+
fetch-depth: 10
3230

3331
- name: Set up JDK
34-
if: ${{ inputs.setup-jdk != 'false' }}
3532
uses: actions/setup-java@v5.2.0
3633
with:
3734
distribution: 'zulu'

.github/actions/ssh-setup/action.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,9 @@ runs:
1717
if [ -e "$HOME/.ssh" ] && [ ! -d "$HOME/.ssh" ]; then
1818
echo "~/.ssh exists but is not a directory. Deleting it..."
1919
rm -f "$HOME/.ssh"
20-
echo "Removed ~/.ssh."
21-
else
22-
echo "~/.ssh is either a directory or does not exist. No action needed."
2320
fi
21+
mkdir -p "$HOME/.ssh"
22+
chmod 700 "$HOME/.ssh"
2423
2524
- name: Add SSH Key
2625
uses: webfactory/ssh-agent@dc588b651fe13675774614f8e6a936a468676387

.github/workflows/android_build_alpaka_upload.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ on:
2525
default: ''
2626
required: false
2727
description: 'Suffix to the working directory of the script, only used for gradle build. Must end with a slash or be empty.'
28-
setup-rust-tool-chain:
28+
setup-rust:
2929
required: false
3030
default: false
3131
type: boolean
@@ -110,7 +110,7 @@ jobs:
110110
checkout-token: ${{ secrets.ANDROID_JENKINS_PAT }}
111111
use-git-lfs: ${{ inputs.use-git-lfs }}
112112
jdk: ${{ inputs.jdk }}
113-
setup-rust: ${{ inputs.setup-rust-tool-chain }}
113+
setup-rust: ${{ inputs.setup-rust }}
114114
flavor: ${{ inputs.flavor }}
115115
app-module: ${{ inputs.app-module }}
116116

.github/workflows/android_build_store_upload.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ on:
1111
required: false
1212
default: 'app'
1313
description: 'The gradle app module (e.g. custom "android:androidApp")'
14-
setup-rust-tool-chain:
14+
setup-rust:
1515
required: false
1616
default: false
1717
type: boolean
@@ -85,7 +85,7 @@ jobs:
8585
checkout-token: ${{ secrets.ANDROID_JENKINS_PAT }}
8686
use-git-lfs: ${{ inputs.use-git-lfs }}
8787
jdk: ${{ inputs.jdk }}
88-
setup-rust: ${{ inputs.setup-rust-tool-chain }}
88+
setup-rust: ${{ inputs.setup-rust }}
8989
flavor: ${{ inputs.flavor }}
9090
app-module: ${{ inputs.app-module }}
9191

@@ -100,7 +100,7 @@ jobs:
100100
-PubiquePoEditorAPIKey=${{ secrets.UBIQUE_POEDITOR_API_KEY }} \
101101
-Pbuild_id=${{ steps.setup.outputs.build_id }} \
102102
-Pbuild_number=${{ steps.setup.outputs.build_number }} \
103-
-Pbuild_batch=${{ steps.setup.outputs.build_batch }} \
103+
-Pbuild_batch=release${{ steps.setup.outputs.build_batch }} \
104104
-Pbranch=${{ github.ref_name }} \
105105
-PcommitHash=${{ github.sha }} \
106106
${{ secrets.ADDITIONAL_GRADLE_PROPS }}
@@ -138,7 +138,9 @@ jobs:
138138
uses: ./.github/actions/android-app-setup
139139
with:
140140
checkout-token: ${{ secrets.ANDROID_JENKINS_PAT }}
141+
use-git-lfs: ${{ inputs.use-git-lfs }}
141142
jdk: ${{ inputs.jdk }}
143+
setup-rust: false
142144
flavor: ${{ inputs.flavor }}
143145
app-module: ${{ inputs.app-module }}
144146

.github/workflows/android_code_quality.yml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,15 @@ on:
4040
required: false
4141
default: '2026.03.1-ndk'
4242
description: The Android image version to use. Default is 2026.03.1-ndk.
43-
setup-rust-tool-chain:
43+
setup-rust:
4444
required: false
4545
default: false
4646
type: boolean
47+
jdk:
48+
type: string
49+
required: false
50+
default: '21'
51+
description: 'The JDK version to use. Default is 21.'
4752
use-git-lfs:
4853
required: false
4954
default: false
@@ -95,7 +100,7 @@ jobs:
95100
checkout-token: ${{ secrets.ANDROID_JENKINS_PAT }}
96101
use-git-lfs: ${{ inputs.use-git-lfs }}
97102
jdk: ${{ inputs.jdk }}
98-
setup-rust: ${{ inputs.setup-rust-tool-chain }}
103+
setup-rust: ${{ inputs.setup-rust }}
99104
flavor: ${{ inputs.flavor }}
100105
app-module: ${{ inputs.app-module }}
101106

@@ -156,7 +161,7 @@ jobs:
156161
checkout-token: ${{ secrets.ANDROID_JENKINS_PAT }}
157162
use-git-lfs: ${{ inputs.use-git-lfs }}
158163
jdk: ${{ inputs.jdk }}
159-
setup-rust: ${{ inputs.setup-rust-tool-chain }}
164+
setup-rust: ${{ inputs.setup-rust }}
160165
flavor: ${{ inputs.flavor }}
161166
app-module: ${{ inputs.app-module }}
162167

.github/workflows/android_gradle_task.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,11 @@ on:
3232
default: false
3333
type: boolean
3434
description: 'Use git lfs during repository checkout'
35+
jdk:
36+
type: string
37+
required: false
38+
default: '21'
39+
description: 'The JDK version to use. Default is 21.'
3540
secrets:
3641
ANDROID_JENKINS_PAT:
3742
required: false
@@ -64,7 +69,8 @@ jobs:
6469
with:
6570
checkout-token: ${{ secrets.ANDROID_JENKINS_PAT || github.token }}
6671
use-git-lfs: ${{ inputs.use-git-lfs }}
67-
setup-jdk: 'false'
72+
jdk: ${{ inputs.jdk }}
73+
setup-rust: 'false'
6874

6975
- name: Run Gradle task
7076
run: ./gradlew ${{ inputs.task }} ${{ inputs.gradle-args }} ${{ github.run_attempt > 1 && '--stacktrace --info' || '' }}

.github/workflows/android_library_artifactory.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ on:
2828
required: false
2929
default: '21'
3030
description: The JDK version to use. Default is 21.
31-
setup-rust-tool-chain:
31+
setup-rust:
3232
required: false
3333
default: false
3434
type: boolean
@@ -66,7 +66,7 @@ jobs:
6666
checkout-token: ${{ secrets.ANDROID_JENKINS_PAT }}
6767
use-git-lfs: ${{ inputs.use-git-lfs }}
6868
jdk: ${{ inputs.jdk }}
69-
setup-rust: ${{ inputs.setup-rust-tool-chain }}
69+
setup-rust: ${{ inputs.setup-rust }}
7070

7171
# Append version name suffix
7272
- name: Append version name suffix

0 commit comments

Comments
 (0)