Skip to content

Commit 1120e07

Browse files
committed
refactor(autofix): Do not fix access expressions in assignments
1 parent 898f258 commit 1120e07

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

src/linter/ui5Types/fix/AccessExpressionFix.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import ts from "typescript";
22
import {ChangeAction} from "../../../autofix/autofix.js";
33
import {PositionInfo} from "../../LinterContext.js";
44
import BaseFix, {BaseFixParams, FixScope} from "./BaseFix.js";
5+
import {isAssignment} from "../utils/utils.js";
56

67
export interface AccessExpressionFixParams extends BaseFixParams {
78
/**
@@ -32,6 +33,9 @@ export default class AccessExpressionFix extends BaseFix {
3233
// access expression
3334
return false;
3435
}
36+
if (!ts.isCallExpression(node) && isAssignment(node)) {
37+
return false;
38+
}
3539
this.sourcePosition = sourcePosition;
3640

3741
// This might be a partial access expression, e.g. "sap.module" of sap.module.property.method"

src/linter/ui5Types/fix/AccessExpressionGeneratorFix.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import ts from "typescript";
22
import {ChangeAction} from "../../../autofix/autofix.js";
33
import {PositionInfo} from "../../LinterContext.js";
44
import BaseFix, {BaseFixParams, FixScope} from "./BaseFix.js";
5+
import {isAssignment} from "../utils/utils.js";
56

67
export interface AccessExpressionGeneratorFixParams extends BaseFixParams {
78
/**
@@ -40,6 +41,9 @@ export default class AccessExpressionGeneratorFix extends BaseFix {
4041
// access expression
4142
return false;
4243
}
44+
if (!ts.isCallExpression(node) && isAssignment(node)) {
45+
return false;
46+
}
4347
this.sourcePosition = sourcePosition;
4448

4549
// This might be a partial access expression, e.g. "sap.module" of sap.module.property.method"

0 commit comments

Comments
 (0)