Commit f6737c7
committed
fix: import boto3/hvac/keyring lazily so the CLI runs without them (v1.2.1)
Closes #1.
The integrations module imported `boto3`, `hvac`, `keyring` and
`botocore.exceptions` at module load time, and the CLI imports that module at
startup. As a result, any problem in those packages crashed every command,
including plain password generation that never touches AWS, Vault or the OS
keychain. This is what issue #1 hit: a broken `boto3` in the user's
environment (`boto.vendored.six.moves`) brought down the whole tool.
Fixed
- Move the `boto3`, `hvac`, `keyring` and `botocore.exceptions` imports inside
the methods that use them (AWS Secrets Manager, HashiCorp Vault, OS keychain).
Password generation and all non-integration features now run with no
dependency on those packages being importable.
- When an integration is used and its package is missing or broken, only that
feature fails, with a clear error, instead of taking down the entire CLI.
Bumps version to 1.2.1.1 parent 4f8ac9e commit f6737c7
4 files changed
Lines changed: 12 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
236 | 236 | | |
237 | 237 | | |
238 | 238 | | |
239 | | - | |
| 239 | + | |
240 | 240 | | |
241 | 241 | | |
242 | 242 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
14 | 13 | | |
15 | 14 | | |
16 | 15 | | |
17 | 16 | | |
18 | 17 | | |
19 | 18 | | |
| 19 | + | |
| 20 | + | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| |||
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
| 41 | + | |
40 | 42 | | |
41 | 43 | | |
42 | 44 | | |
| |||
72 | 74 | | |
73 | 75 | | |
74 | 76 | | |
| 77 | + | |
75 | 78 | | |
76 | 79 | | |
77 | 80 | | |
| |||
110 | 113 | | |
111 | 114 | | |
112 | 115 | | |
| 116 | + | |
113 | 117 | | |
114 | 118 | | |
115 | 119 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
0 commit comments