[TASK] Make implicit nullable param to explicit

Applied rule:
Rector\Php84\Rector\Param\ExplicitNullableParamTypeRector

Resolves: #806

Author: simonschaufi

rector.php

@@ -10,10 +10,12 @@
  */
 
 use Rector\Config\RectorConfig;
+use Rector\Php84\Rector\Param\ExplicitNullableParamTypeRector;
 use Rector\PHPUnit\CodeQuality\Rector\Class_\PreferPHPUnitThisCallRector;
 use Rector\PHPUnit\CodeQuality\Rector\ClassMethod\ReplaceTestAnnotationWithPrefixedFunctionRector;
 use Rector\PHPUnit\Set\PHPUnitSetList;
 use Rector\Set\ValueObject\LevelSetList;
+use Rector\ValueObject\PhpVersion;
 
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->importNames();
@@ -32,4 +34,8 @@
         PHPUnitSetList::PHPUNIT_90,
         LevelSetList::UP_TO_PHP_74,
     ]);
+    $rectorConfig->rules([
+        ExplicitNullableParamTypeRector::class,
+    ]);
+    $rectorConfig->phpVersion(PhpVersion::PHP_84);
 };

src/Cli/Symfony/ConsoleApplication.php

@@ -32,7 +32,7 @@ public function __construct(FactoryInterface $factory, OutputInterface $output,
         $this->output = $output;
     }
 
-    public function run(InputInterface $input = null, OutputInterface $output = null): int
+    public function run(?InputInterface $input = null, ?OutputInterface $output = null): int
     {
         return parent::run($input, $this->output);
     }

src/Domain/Clock/ClockInterface.php

@@ -15,7 +15,7 @@ interface ClockInterface
 {
     public function currentTime(): int;
 
-    public function stringToTime(string $string, int $time = null): int;
+    public function stringToTime(string $string, ?int $time = null): int;
 
     public function createTimestampFromFormat(string $format, string $time): int;
 }

src/Domain/Clock/SystemClock.php

@@ -20,7 +20,7 @@ public function currentTime(): int
         return time();
     }
 
-    public function stringToTime(string $string, int $time = null): int
+    public function stringToTime(string $string, ?int $time = null): int
     {
         $time ??= $this->currentTime();
         $timestamp = strtotime($string, $time);

src/Domain/Model/Deployment.php

@@ -96,7 +96,7 @@ class Deployment implements LoggerAwareInterface
     private string $deploymentLockIdentifier;
     private ContainerInterface $container;
 
-    public function __construct(ContainerInterface $container, string $name, string $deploymentLockIdentifier = null)
+    public function __construct(ContainerInterface $container, string $name, ?string $deploymentLockIdentifier = null)
     {
         $this->container = $container;
         $this->name = $name;

src/Domain/Model/Workflow.php

@@ -48,7 +48,7 @@ abstract public function getName(): string;
     /**
      * Remove the given task from all stages and applications
      */
-    public function removeTask(string $removeTask, Application $application = null): self
+    public function removeTask(string $removeTask, ?Application $application = null): self
     {
         $removeApplicationName = $application instanceof Application ? $application->getName() : null;
 
@@ -108,7 +108,7 @@ public function forStage(string $stage, $tasks): self
      * @param string $stage The name of the stage when this task shall be executed
      * @param string $step A stage has three steps "before", "tasks" and "after"
      */
-    protected function addTaskToStage($tasks, string $stage, Application $application = null, string $step = 'tasks'): void
+    protected function addTaskToStage($tasks, string $stage, ?Application $application = null, string $step = 'tasks'): void
     {
         if (!is_array($tasks)) {
             $tasks = [$tasks];
@@ -134,7 +134,7 @@ protected function addTaskToStage($tasks, string $stage, Application $applicatio
      *
      * @return Workflow
      */
-    public function addTask($tasks, string $stage, Application $application = null)
+    public function addTask($tasks, string $stage, ?Application $application = null)
     {
         $this->addTaskToStage($tasks, $stage, $application);
 
@@ -148,7 +148,7 @@ public function addTask($tasks, string $stage, Application $application = null)
      *
      * @param array|string $tasks
      */
-    public function afterTask(string $task, $tasks, Application $application = null): self
+    public function afterTask(string $task, $tasks, ?Application $application = null): self
     {
         if (!is_array($tasks)) {
             $tasks = [$tasks];
@@ -171,7 +171,7 @@ public function afterTask(string $task, $tasks, Application $application = null)
      *
      * @param array|string $tasks
      */
-    public function beforeTask(string $task, $tasks, Application $application = null): self
+    public function beforeTask(string $task, $tasks, ?Application $application = null): self
     {
         if (!is_array($tasks)) {
             $tasks = [$tasks];
@@ -204,7 +204,7 @@ public function defineTask(string $taskName, string $baseTask, array $options):
      *
      * @param array|string $tasks
      */
-    public function beforeStage(string $stage, $tasks, Application $application = null): self
+    public function beforeStage(string $stage, $tasks, ?Application $application = null): self
     {
         $this->addTaskToStage($tasks, $stage, $application, 'before');
 
@@ -216,7 +216,7 @@ public function beforeStage(string $stage, $tasks, Application $application = nu
      *
      * @param array|string $tasks
      */
-    public function afterStage(string $stage, $tasks, Application $application = null): self
+    public function afterStage(string $stage, $tasks, ?Application $application = null): self
     {
         $this->addTaskToStage($tasks, $stage, $application, 'after');
 

src/Integration/Factory.php

@@ -40,7 +40,7 @@ public function __construct(ContainerInterface $container, FilesystemInterface $
         $this->logger = $logger;
     }
 
-    public function getDeployment(string $deploymentName, string $configurationPath = null, bool $simulateDeployment = true, bool $initialize = true, bool $forceDeployment = false): Deployment
+    public function getDeployment(string $deploymentName, ?string $configurationPath = null, bool $simulateDeployment = true, bool $initialize = true, bool $forceDeployment = false): Deployment
     {
         $deployment = $this->createDeployment($deploymentName, $configurationPath);
 
@@ -65,7 +65,7 @@ public function getDeployment(string $deploymentName, string $configurationPath
     /**
      * @inheritDoc
      */
-    public function getDeploymentNames(string $path = null): array
+    public function getDeploymentNames(?string $path = null): array
     {
         $path = $this->getDeploymentsBasePath($path);
         $files = $this->filesystem->glob(Files::concatenatePaths([$path, '*.php']));
@@ -76,7 +76,7 @@ public function getDeploymentNames(string $path = null): array
     /**
      * @inheritDoc
      */
-    public function getDeploymentsBasePath(string $path = null): string
+    public function getDeploymentsBasePath(?string $path = null): string
     {
         $localDeploymentDescription = $this->filesystem->getRealPath('./.surf');
         if (! $path && $this->filesystem->isDirectory($localDeploymentDescription)) {
@@ -91,7 +91,7 @@ public function getDeploymentsBasePath(string $path = null): string
     /**
      * @inheritDoc
      */
-    public function getWorkspacesBasePath(string $path = null): string
+    public function getWorkspacesBasePath(?string $path = null): string
     {
         $workspacesBasePath = getenv('SURF_WORKSPACE');
 
@@ -124,7 +124,7 @@ public function getWorkspacesBasePath(string $path = null): string
      * The script has access to a deployment object as "$deployment". This could change
      * in the future.
      */
-    protected function createDeployment(string $deploymentName, string $path = null): Deployment
+    protected function createDeployment(string $deploymentName, ?string $path = null): Deployment
     {
         $deploymentConfigurationPath = $this->getDeploymentsBasePath($path);
         $workspacesBasePath = $this->getWorkspacesBasePath();

src/Integration/FactoryInterface.php

@@ -15,24 +15,24 @@
 
 interface FactoryInterface
 {
-    public function getDeployment(string $deploymentName, string $configurationPath = null, bool $simulateDeployment = true, bool $initialize = true, bool $forceDeployment = false): Deployment;
+    public function getDeployment(string $deploymentName, ?string $configurationPath = null, bool $simulateDeployment = true, bool $initialize = true, bool $forceDeployment = false): Deployment;
 
     /**
      * Get available deployment names
      *
      * Will look up all .php files in the directory ./.surf/ or the given path if specified.
      */
-    public function getDeploymentNames(string $path = null): array;
+    public function getDeploymentNames(?string $path = null): array;
 
     /**
      * Get the root path of the surf deployment declarations
      *
      * This defaults to ./.surf if a NULL path is given.
      */
-    public function getDeploymentsBasePath(string $path = null): string;
+    public function getDeploymentsBasePath(?string $path = null): string;
 
     /**
      * Get the base path to local workspaces
      */
-    public function getWorkspacesBasePath(string $path = null): string;
+    public function getWorkspacesBasePath(?string $path = null): string;
 }

tests/Unit/Domain/Service/ShellCommandServiceTest.php

@@ -34,10 +34,10 @@ class ShellCommandServiceTest extends TestCase
      */
     public function executeRemoteCommandRespectsOptionsInSshCommand(
         string $expectedCommandArguments,
-        string $username = null,
-        string $password = null,
-        int $port = null,
-        string $privateKey = null
+        ?string $username = null,
+        ?string $password = null,
+        ?int $port = null,
+        ?string $privateKey = null
     ): void {
         /** @var MockObject|ShellCommandService $service */
         $service = $this->createPartialMock(ShellCommandService::class, ['executeProcess']);