Skip to content

Allow configuration file to be specified via a environment variable#917

Open
luto wants to merge 1 commit into
Supervisor:mainfrom
Uberspace:env_config
Open

Allow configuration file to be specified via a environment variable#917
luto wants to merge 1 commit into
Supervisor:mainfrom
Uberspace:env_config

Conversation

@luto

@luto luto commented Apr 9, 2017

Copy link
Copy Markdown
Contributor

Fixes #742

This PR enables the configuration file to be specified in the $SUPERVISOR_CONFIG environment variable. Refer to the issue for further discussion.

@mnaberez mnaberez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't merge any new features that don't have tests. Please remove the unrelated gitignore changes.

@luto

luto commented Apr 11, 2017

Copy link
Copy Markdown
Contributor Author
  1. tests: will do
  2. gitignore: gotcha. See Add a couple of common python dirs to .gitignore #919

@mnaberez

Copy link
Copy Markdown
Member

Thanks, I've merged #919.

@luto

luto commented Apr 11, 2017

Copy link
Copy Markdown
Contributor Author

@mnaberez got tests now and they pass in the CI. Please let me know if you need anything else! :)

@mnaberez mnaberez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test this locally and if I don't find any issues, I'll merge it for the next feature release.

@luto

luto commented Apr 16, 2017

Copy link
Copy Markdown
Contributor Author

Thank you! :)

@luto

luto commented Oct 8, 2017

Copy link
Copy Markdown
Contributor Author

@mnaberez any news on this? :)

@santiagobasulto

Copy link
Copy Markdown

Hello, I came here searching for this. Any news on when it's planned to be merged/released?

@mjpieters

Copy link
Copy Markdown
Contributor

I'd have created this very pull request if this wasn't here already. What is the status of this, what is missing (if anything) before this can be merged?

@mnaberez

Copy link
Copy Markdown
Member

What is the status of this, what is missing (if anything) before this can be merged?

I reviewed it again and it looks fine to me. I intend to include it in the next release.

@delgor

delgor commented Oct 6, 2022

Copy link
Copy Markdown

Hi, I'd love to see this feature as well. Did anything change since your last review, what is required for this to be merged?

@luto

luto commented Oct 6, 2022

Copy link
Copy Markdown
Contributor Author

We are still interested as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Suggestion: Allow a configuration file to be determined via ENVIRONMENT vars

5 participants