don't check always priority for item hints

gymnast86 · gymnast86 · commit 224cf5f15884 · 2026-01-13T13:07:13.000-08:00
diff --git a/logic/Hints.cpp b/logic/Hints.cpp
@@ -519,8 +519,7 @@ static HintError generateItemHintLocations(World& world, std::vector<Location*>&
            !location->hasKnownVanillaItem      &&  // and does not have a known vanilla item...
            !location->hasExpectedItem          &&  // and does not have an expected item...
            !location->hasBeenHinted            &&  // and has not been hinted at yet...
-           !(settings.ho_ho_triforce_hints && location->currentItem.isTriforceShard()) && // and isn't a shard when ho ho will hint shards...
-           (location->hintPriority != "Always" || !world.getSettings().use_always_hints)) // and the hint priority is not "Always" when we're using always hints...
+           !(settings.ho_ho_triforce_hints && location->currentItem.isTriforceShard())) // and isn't a shard when ho ho will hint shards...
            
            {
               // Then the item is a possible item hint location

Original file line number	Diff line number	Diff line change
`@@ -519,8 +519,7 @@ static HintError generateItemHintLocations(World& world, std::vector<Location*>&`
`519`	`519`	`!location->hasKnownVanillaItem && // and does not have a known vanilla item...`
`520`	`520`	`!location->hasExpectedItem && // and does not have an expected item...`
`521`	`521`	`!location->hasBeenHinted && // and has not been hinted at yet...`
`522`		`- !(settings.ho_ho_triforce_hints && location->currentItem.isTriforceShard()) && // and isn't a shard when ho ho will hint shards...`
`523`		`- (location->hintPriority != "Always" \|\| !world.getSettings().use_always_hints)) // and the hint priority is not "Always" when we're using always hints...`
	`522`	`+ !(settings.ho_ho_triforce_hints && location->currentItem.isTriforceShard())) // and isn't a shard when ho ho will hint shards...`
`524`	`523`
`525`	`524`	`{`
`526`	`525`	`// Then the item is a possible item hint location`