Packaging fixes#1548
Merged
Merged
Conversation
185eaa0 to
9234149
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines the GitHub Actions packaging workflow to prevent version-bump PRs on prereleases, provide a distinct job name for branch protection rules, and make NuGet pushes rerunnable on failure.
- Renamed the build job to “Build and Package”
- Added
--skip-duplicateto the NuGet push step for retry support - Updated the version-bump PR job name and added an
ifcondition to skip prereleases
Comments suppressed due to low confidence (2)
.github/workflows/package.yml:243
- Use the built-in prerelease flag (
github.event.release.prerelease == false) instead of checking for a hyphen in the ref name to more reliably detect stable releases.
if: ${{ github.event_name == 'release' && !contains(github.ref_name, '-') }}
.github/workflows/package.yml:242
- [nitpick] Consider shortening the job name to improve readability and alignment with branch protection rules (e.g.,
Bump version PR).
name: Open pull request to bump Steeltoe version after stable release
Contributor
Summary - All Code Coverage (ubuntu-latest)
|
|
TimHess
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes to the GitHub Actions packaging workflow:
Follow-up actions: