Skip to content

Packaging fixes#1548

Merged
bart-vmware merged 2 commits into
mainfrom
packaging-fixes
Jul 17, 2025
Merged

Packaging fixes#1548
bart-vmware merged 2 commits into
mainfrom
packaging-fixes

Conversation

@bart-vmware

@bart-vmware bart-vmware commented Jul 17, 2025

Copy link
Copy Markdown
Member

Description

Fixes to the GitHub Actions packaging workflow:

  • Don't open PR to bump version after pre-release
  • Use a distinguished job name for use in Branch protection rules
  • Allow rerun of release workflow if NuGet upload fails halfway

Follow-up actions:

  • Add a required check on the main branch in GitHub repository settings after this is merged.
  • Update references to Azure DevOps feed ("dev" in the feed URL changed to "ci").

@bart-vmware bart-vmware requested a review from Copilot July 17, 2025 09:26
@bart-vmware bart-vmware marked this pull request as ready for review July 17, 2025 09:26
@bart-vmware bart-vmware requested a review from TimHess July 17, 2025 09:26

This comment was marked as outdated.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the GitHub Actions packaging workflow to prevent version-bump PRs on prereleases, provide a distinct job name for branch protection rules, and make NuGet pushes rerunnable on failure.

  • Renamed the build job to “Build and Package”
  • Added --skip-duplicate to the NuGet push step for retry support
  • Updated the version-bump PR job name and added an if condition to skip prereleases
Comments suppressed due to low confidence (2)

.github/workflows/package.yml:243

  • Use the built-in prerelease flag (github.event.release.prerelease == false) instead of checking for a hyphen in the ref name to more reliably detect stable releases.
    if: ${{ github.event_name == 'release' && !contains(github.ref_name, '-') }}

.github/workflows/package.yml:242

  • [nitpick] Consider shortening the job name to improve readability and alignment with branch protection rules (e.g., Bump version PR).
    name: Open pull request to bump Steeltoe version after stable release

@github-actions

Copy link
Copy Markdown
Contributor

Summary - All Code Coverage (ubuntu-latest)

Line coverage Branch coverage

Assembly Line coverage Branch coverage
Steeltoe.Bootstrap.AutoConfiguration 97.4% 100%
Steeltoe.Common 85.6% 79.8%
Steeltoe.Common.Certificates 96.2% 85.2%
Steeltoe.Common.Hosting 84% 70%
Steeltoe.Common.Http 100% 85.2%
Steeltoe.Common.Logging 81.1% 41.6%
Steeltoe.Common.Net 64.5% 66.6%
Steeltoe.Configuration.Abstractions 97.8% 92.6%
Steeltoe.Configuration.CloudFoundry 99.1% 91.6%
Steeltoe.Configuration.ConfigServer 97.2% 91.5%
Steeltoe.Configuration.Encryption 97.6% 92.4%
Steeltoe.Configuration.Kubernetes.ServiceBindings 95.1% 89.3%
Steeltoe.Configuration.Placeholder 93.8% 84.7%
Steeltoe.Configuration.RandomValue 93.2% 90%
Steeltoe.Configuration.SpringBoot 98.4% 95.4%
Steeltoe.Connectors 94.8% 90%
Steeltoe.Connectors.EntityFrameworkCore 81.5% 75%
Steeltoe.Discovery.Configuration 90.4% 100%
Steeltoe.Discovery.Consul 97.7% 94.8%
Steeltoe.Discovery.Eureka 92.7% 85.6%
Steeltoe.Discovery.HttpClients 94% 95.4%
Steeltoe.Logging.Abstractions 99.4% 96.9%
Steeltoe.Logging.DynamicConsole 100% 95.4%
Steeltoe.Logging.DynamicSerilog 99.1% 95%
Steeltoe.Management.Abstractions 100% 100%
Steeltoe.Management.Endpoint 95.5% 89.1%
Steeltoe.Management.Prometheus 95.9% 91.6%
Steeltoe.Management.Tasks 100% ****
Steeltoe.Management.Tracing 100% 75%
Steeltoe.Security.Authentication.JwtBearer 100% 100%
Steeltoe.Security.Authentication.OpenIdConnect 73.8% 59%
Steeltoe.Security.Authorization.Certificate 96.3% 75%
Steeltoe.Security.DataProtection.Redis 100% ****

@sonarqubecloud

Copy link
Copy Markdown

@bart-vmware bart-vmware merged commit 85f246b into main Jul 17, 2025
15 of 16 checks passed
@bart-vmware bart-vmware deleted the packaging-fixes branch July 17, 2025 14:17
@bart-vmware bart-vmware added ReleaseLine/4.x Identified as a feature/fix for the 4.x release line Type/infrastructure labels Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ReleaseLine/4.x Identified as a feature/fix for the 4.x release line Type/infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants