Fix crash when logging providers are cleared after AddDynamicConsole/AddDynamicSerilog

Register the concrete provider type as a standalone singleton so that IDynamicLoggerProvider
remains resolvable even when ClearProviders() is called after the dynamic logging setup.
Previously, IDynamicLoggerProvider was resolved via a factory that searched through
ILoggerProvider services using .Single(), which threw when ClearProviders() removed them.

Agent-Logs-Url: https://github.com/SteeltoeOSS/Steeltoe/sessions/9b9035c5-5b65-49bc-b0dd-a2e9cdd0fd14

Co-authored-by: bart-vmware <104792814+bart-vmware@users.noreply.github.com>

Author: Copilot

src/Logging/src/DynamicConsole/LoggingBuilderExtensions.cs

@@ -33,8 +33,9 @@ public static ILoggingBuilder AddDynamicConsole(this ILoggingBuilder builder)
             UpdateConsoleLoggerProviderRegistration(builder.Services);
 
             builder.AddFilter<DynamicConsoleLoggerProvider>(null, LogLevel.Trace);
-            builder.Services.TryAddEnumerable(ServiceDescriptor.Singleton<ILoggerProvider, DynamicConsoleLoggerProvider>());
-            builder.Services.AddSingleton(provider => provider.GetServices<ILoggerProvider>().OfType<IDynamicLoggerProvider>().Single());
+            builder.Services.TryAddSingleton<DynamicConsoleLoggerProvider>();
+            builder.Services.AddSingleton<ILoggerProvider>(serviceProvider => serviceProvider.GetRequiredService<DynamicConsoleLoggerProvider>());
+            builder.Services.AddSingleton<IDynamicLoggerProvider>(serviceProvider => serviceProvider.GetRequiredService<DynamicConsoleLoggerProvider>());
 
             DisableConsoleColorsOnCloudPlatform(builder);
         }

src/Logging/src/DynamicSerilog/SerilogLoggingBuilderExtensions.cs

@@ -8,7 +8,6 @@
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
 using Serilog;
-using Steeltoe.Common;
 
 namespace Steeltoe.Logging.DynamicSerilog;
 
@@ -94,17 +93,17 @@ public static ILoggingBuilder AddDynamicSerilog(this ILoggingBuilder builder, Lo
 
             ConfigureSerilogOptions(builder, serilogConfiguration);
 
-            builder.Services.TryAddEnumerable(ServiceDescriptor.Singleton<ILoggerProvider, DynamicSerilogLoggerProvider>());
-            builder.Services.AddSingleton(provider => provider.GetServices<ILoggerProvider>().OfType<IDynamicLoggerProvider>().Single());
+            builder.Services.TryAddSingleton<DynamicSerilogLoggerProvider>();
+            builder.Services.AddSingleton<ILoggerProvider>(serviceProvider => serviceProvider.GetRequiredService<DynamicSerilogLoggerProvider>());
+            builder.Services.AddSingleton<IDynamicLoggerProvider>(serviceProvider => serviceProvider.GetRequiredService<DynamicSerilogLoggerProvider>());
         }
 
         return builder;
     }
 
     private static bool IsSerilogDynamicLoggerProviderAlreadyRegistered(ILoggingBuilder builder)
     {
-        return builder.Services.Any(descriptor =>
-            descriptor.SafeGetImplementationType() == typeof(DynamicSerilogLoggerProvider) && descriptor.ServiceType == typeof(ILoggerProvider));
+        return builder.Services.Any(descriptor => descriptor.ServiceType == typeof(DynamicSerilogLoggerProvider));
     }
 
     private static void AssertNoDynamicLoggerProviderRegistered(ILoggingBuilder builder)

src/Logging/test/DynamicConsole.Test/HostBuilderTest.cs

@@ -203,6 +203,18 @@ public async Task DisposeTwiceSucceeds()
         action.Should().NotThrow();
     }
 
+    [Fact]
+    public async Task DoesNotCrashWhenLoggingProvidersAreCleared()
+    {
+        WebApplicationBuilder builder = TestWebApplicationBuilderFactory.Create();
+        builder.Logging.AddDynamicConsole();
+        builder.Services.AddLogging(loggingBuilder => loggingBuilder.ClearProviders());
+        await using WebApplication host = builder.Build();
+
+        host.Services.GetService<IDynamicLoggerProvider>().Should().BeOfType<DynamicConsoleLoggerProvider>();
+        host.Services.GetServices<ILoggerProvider>().OfType<DynamicConsoleLoggerProvider>().Should().BeEmpty();
+    }
+
     private sealed class OtherDynamicLoggerProvider : IDynamicLoggerProvider
     {
         public ILogger CreateLogger(string categoryName)

src/Logging/test/DynamicSerilog.Test/HostBuilderTest.cs

@@ -403,6 +403,18 @@ public async Task DisposeTwiceSucceeds()
         action.Should().NotThrow();
     }
 
+    [Fact]
+    public async Task DoesNotCrashWhenLoggingProvidersAreCleared()
+    {
+        WebApplicationBuilder builder = TestWebApplicationBuilderFactory.Create();
+        builder.Logging.AddDynamicSerilog();
+        builder.Services.AddLogging(loggingBuilder => loggingBuilder.ClearProviders());
+        await using WebApplication host = builder.Build();
+
+        host.Services.GetService<IDynamicLoggerProvider>().Should().BeOfType<DynamicSerilogLoggerProvider>();
+        host.Services.GetServices<ILoggerProvider>().OfType<DynamicSerilogLoggerProvider>().Should().BeEmpty();
+    }
+
     public void Dispose()
     {
         _consoleOutput.Dispose();