Add optimized path when no comma in URL

Author: bart-vmware

src/Common/src/Common/Extensions/UriExtensions.cs

@@ -41,6 +41,12 @@ public static string ToMaskedString(this Uri source)
         }
 
         var uris = source.ToString();
+
+        if (!uris.Contains(','))
+        {
+            return source.ToMaskedUri().ToString();
+        }
+
         return string.Join(",", uris.Split(_uriSeparatorChar, StringSplitOptions.RemoveEmptyEntries).Select(uri => new Uri(uri).ToMaskedUri().ToString()));
     }
 

src/Common/test/Common.Test/Extensions/UriExtensionsTest.cs

@@ -11,18 +11,29 @@ namespace Steeltoe.Common.Test.Extensions;
 public class UriExtensionsTest
 {
     [Fact]
-    public void MaskExistingBasicAuthentication()
+    public void MaskSingleBasicAuthentication()
+    {
+        var uri = new Uri("http://username:password@www.example.com/");
+        const string expected = "http://****:****@www.example.com/";
+
+        var masked = uri.ToMaskedString();
+
+        Assert.Equal(expected, masked);
+    }
+
+    [Fact]
+    public void MaskMultiBasicAuthentication()
     {
         var uri = new Uri("http://username:password@www.example.com/,http://user2:pass2@www.other.com/");
-        var expected = "http://****:****@www.example.com/,http://****:****@www.other.com/";
+        const string expected = "http://****:****@www.example.com/,http://****:****@www.other.com/";
 
         var masked = uri.ToMaskedString();
 
         Assert.Equal(expected, masked);
     }
 
     [Fact]
-    public void DontMaskIfNotBasicAuthenticationExists()
+    public void DoNotMaskIfNoBasicAuthentication()
     {
         var uri = new Uri("http://www.example.com/");
         var expected = uri.ToString();
@@ -31,4 +42,4 @@ public void DontMaskIfNotBasicAuthenticationExists()
 
         Assert.Equal(expected, masked);
     }
-}
+}