Address flaky tests

- Prevent extra SBA refresh request after refresh is disabled
- Address race condition in thread dump test
- Catch network-related SQLServer connection error
- Remove retry from eureka server timeout
- More buffer for infra around health aggregator parallelization test (allow +1s for +3s work)

Author: TimHess

src/Connectors/test/Connectors.Test/RelationalDatabaseHealthContributorTest.cs

@@ -111,7 +111,10 @@ public async Task SQLServer_Not_Connected_Returns_Down_Status()
         result.Description.Should().Be("SQL Server health check failed");
         result.Details.Should().Contain("host", "localhost");
         result.Details.Should().Contain("service", "Example");
-        result.Details.Should().ContainKey("error").WhoseValue.As<string>().Should().StartWith("SqlException: Connection Timeout Expired.");
+
+        result.Details.Should().ContainKey("error").WhoseValue.As<string>().Should().Match(exception =>
+            exception.StartsWith("SqlException: Connection Timeout Expired.", StringComparison.InvariantCulture) ||
+            exception.StartsWith("SqlException: A network-related or instance-specific error", StringComparison.InvariantCulture));
     }
 
     [Fact(Skip = "Integration test - Requires local SQL Server instance")]

src/Discovery/test/Eureka.Test/EurekaServiceCollectionExtensionsTest.cs

@@ -62,7 +62,7 @@ public async Task AddEurekaDiscoveryClient_UsesServerTimeout()
         var appSettings = new Dictionary<string, string?>
         {
             ["Eureka:Client:EurekaServer:ConnectTimeoutSeconds"] = "1",
-            ["Eureka:Client:EurekaServer:RetryCount"] = "1"
+            ["Eureka:Client:EurekaServer:RetryCount"] = "0"
         };
 
         IConfiguration configuration = new ConfigurationBuilder().AddInMemoryCollection(appSettings).Build();

src/Management/src/Endpoint/SpringBootAdminClient/SpringBootAdminPeriodicRefresh.cs

@@ -44,15 +44,20 @@ private async Task TimerLoopAsync(TimeSpan interval)
 
             do
             {
-                LogStartingRefreshCycle();
-
-                try
-                {
-                    await _runner.RunAsync(isFirstTime, _timerTokenSource.Token);
-                }
-                catch (Exception exception) when (!exception.IsCancellation())
+                // A tick queued just before periodic refresh was disabled would still be delivered here.
+                // Checking the period prevents executing a stale tick when refresh has been turned off.
+                if (isFirstTime || _periodicTimer.Period != Timeout.InfiniteTimeSpan)
                 {
-                    LogRefreshCycleFailed(exception);
+                    LogStartingRefreshCycle();
+
+                    try
+                    {
+                        await _runner.RunAsync(isFirstTime, _timerTokenSource.Token);
+                    }
+                    catch (Exception exception) when (!exception.IsCancellation())
+                    {
+                        LogRefreshCycleFailed(exception);
+                    }
                 }
 
                 isFirstTime = false;

src/Management/test/Endpoint.Test/Actuators/Health/HealthAggregationTest.cs

@@ -366,9 +366,9 @@ public async Task Aggregates_contributors_in_parallel()
     {
         List<IHealthContributor> contributors =
         [
-            new SlowContributor(1.Seconds()),
             new SlowContributor(2.Seconds()),
-            new SlowContributor(3.Seconds())
+            new SlowContributor(3.Seconds()),
+            new SlowContributor(4.Seconds())
         ];
 
         WebApplicationBuilder builder = TestWebApplicationBuilderFactory.Create();
@@ -408,7 +408,7 @@ public async Task Aggregates_contributors_in_parallel()
             }
             """);
 
-        stopwatch.Elapsed.Should().BeGreaterThan(500.Milliseconds()).And.BeLessThan(5.Seconds());
+        stopwatch.Elapsed.Should().BeGreaterThan(500.Milliseconds()).And.BeLessThan(6.Seconds());
     }
 
     [Fact]

src/Management/test/Endpoint.Test/Actuators/ThreadDump/EventPipeThreadDumperTest.cs

@@ -16,19 +16,22 @@ public sealed class EventPipeThreadDumperTest
     public async Task Can_resolve_source_location_from_pdb()
     {
         using var backgroundCancellationSource = new CancellationTokenSource();
+        using var threadStarted = new ManualResetEventSlim(false);
 
         var backgroundThread = new Thread(NestedType.BackgroundThreadCallback)
         {
             IsBackground = true
         };
 
-        backgroundThread.Start(backgroundCancellationSource.Token);
+        backgroundThread.Start((backgroundCancellationSource.Token, threadStarted));
+        threadStarted.Wait(TestContext.Current.CancellationToken);
 
         using var loggerProvider = new CapturingLoggerProvider();
         using var loggerFactory = new LoggerFactory([loggerProvider]);
         ILogger<EventPipeThreadDumper> logger = loggerFactory.CreateLogger<EventPipeThreadDumper>();
 
-        var optionsMonitor = new TestOptionsMonitor<ThreadDumpEndpointOptions>();
+        // Use a longer collection window to provide enough sample opportunities on a loaded CI runner.
+        var optionsMonitor = TestOptionsMonitor.Create(new ThreadDumpEndpointOptions { Duration = 100 });
         var dumper = new EventPipeThreadDumper(optionsMonitor, logger);
 
         IList<ThreadInfo> threads = await dumper.DumpThreadsAsync(TestContext.Current.CancellationToken);
@@ -87,11 +90,16 @@ private static class NestedType
     {
         public static void BackgroundThreadCallback(object? argument)
         {
-            var cancellationToken = (CancellationToken)argument!;
+            (CancellationToken cancellationToken, ManualResetEventSlim threadReady) = ((CancellationToken, ManualResetEventSlim))argument!;
+
+            threadReady.Set();
 
             while (!cancellationToken.IsCancellationRequested)
             {
-                Thread.Sleep(TimeSpan.FromMilliseconds(50));
+                // Only actively-running threads are shown in the thread dump, so we need to make sure the CPU is in use.
+                // Thread.Sleep(0) yields to allow the EventPipe rundown thread to make progress on .NET 8.
+                Thread.SpinWait(250);
+                Thread.Sleep(0);
             }
         }
     }