Fix broken build netsdk 10.0.200, fix green builds on failure (#1657)

* Fix broken build on .NET SDK v10.0.200

Fixes occurrences of the following errors:
error IDE0370: Suppression is unnecessary (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0370)

* Fix GHA: Overall build was reported Green if jobs have failures

* Test: build failure must abort the job and report outcome Red

* Revert "Test: build failure must abort the job and report outcome Red"

This reverts commit 9ee4528.

* Test: test failure must upload results and report outcome Red

* Revert "Test: test failure must upload results and report outcome Red"

This reverts commit e20a39c.

* Test: report failure must abort the job and report outcome Red

* Revert "Test: report failure must abort the job and report outcome Red"

This reverts commit 5009453.

Author: bart-vmware

.github/workflows/Steeltoe.All.yml

@@ -41,7 +41,6 @@ jobs:
         - os: macos-latest
           skipIntegrationTests: true
     runs-on: ${{ matrix.os }}
-    continue-on-error: true
 
     services:
       eurekaServer:
@@ -91,13 +90,15 @@ jobs:
       run: dotnet build ${{ env.SOLUTION_FILE }} --no-restore --configuration Release --verbosity minimal
 
     - name: Test
+      id: test
       run: dotnet test ${{ env.SOLUTION_FILE }} --filter "${{ matrix.skipIntegrationTests == true && 'Category!=MemoryDumps&Category!=Integration' || 'Category!=MemoryDumps' }}" ${{ env.COMMON_TEST_ARGS }}
 
     - name: Test (memory dumps)
+      id: test-memory-dumps
       run: dotnet test src/Management/test/Endpoint.Test --filter "Category=MemoryDumps" ${{ env.COMMON_TEST_ARGS }}
 
     - name: Upload crash/hang dumps (on failure)
-      if: ${{ failure() }}
+      if: ${{ !cancelled() && (steps.test.outcome == 'failure' || steps.test-memory-dumps.outcome == 'failure') }}
       uses: actions/upload-artifact@v5
       with:
         name: FailedTestOutput-${{ matrix.os }}
@@ -107,7 +108,7 @@ jobs:
         if-no-files-found: ignore
 
     - name: Report test results
-      if: ${{ !cancelled() }}
+      if: ${{ !cancelled() && (steps.test.outcome != 'skipped' || steps.test-memory-dumps.outcome != 'skipped') }}
       uses: dorny/test-reporter@v2
       with:
         name: ${{ matrix.os }} test results

.github/workflows/component-shared-workflow.yml

@@ -81,14 +81,16 @@ jobs:
       run: dotnet build ${{ env.SOLUTION_FILE }} --no-restore --configuration Release --verbosity minimal
 
     - name: Test
+      id: test
       run: dotnet test ${{ env.SOLUTION_FILE }} --filter "Category!=MemoryDumps" ${{ env.COMMON_TEST_ARGS }}
 
     - name: Test (memory dumps)
+      id: test-memory-dumps
       if: ${{ inputs.component == 'Management' }}
       run: dotnet test src/Management/test/Endpoint.Test --filter "Category=MemoryDumps" ${{ env.COMMON_TEST_ARGS }}
 
     - name: Upload crash/hang dumps (on failure)
-      if: ${{ failure() }}
+      if: ${{ !cancelled() && (steps.test.outcome == 'failure' || steps.test-memory-dumps.outcome == 'failure') }}
       uses: actions/upload-artifact@v5
       with:
         name: FailedTestOutput-${{ inputs.OS }}-latest
@@ -98,7 +100,7 @@ jobs:
         if-no-files-found: ignore
 
     - name: Report test results
-      if: ${{ !cancelled() }}
+      if: ${{ !cancelled() && (steps.test.outcome != 'skipped' || steps.test-memory-dumps.outcome != 'skipped') }}
       uses: dorny/test-reporter@v2
       with:
         name: ${{ inputs.OS }}-latest test results

src/Connectors/test/Connectors.Test/CosmosDb/CosmosDbHealthContributorTest.cs

@@ -105,7 +105,7 @@ public async Task Canceled_Throws()
         cosmosClientMock.Setup(client => client.ReadAccountAsync()).Returns(async () =>
         {
             await Task.Delay(3.Seconds(), TestContext.Current.CancellationToken);
-            return null!;
+            return null;
         });
 
         await using ServiceProvider serviceProvider = CreateServiceProvider(serviceName, connectionString, cosmosClientMock.Object);

src/Discovery/test/Eureka.Test/PostConfigureEurekaInstanceOptionsTest.cs

@@ -329,7 +329,7 @@ public async Task Adds_random_number_to_instance_ID_when_ports_are_zero()
         EurekaInstanceOptions instanceOptions = optionsMonitor.CurrentValue;
 
         instanceOptions.InstanceId.Should().NotBeNull();
-        string[] parts = instanceOptions.InstanceId!.Split(':');
+        string[] parts = instanceOptions.InstanceId.Split(':');
         parts.Should().HaveCount(3);
 
         int.TryParse(parts[2], CultureInfo.InvariantCulture, out int number).Should().BeTrue();