Update to ReSharper v2026.1 (#1681)

bart-vmware · web-flow · commit 4594c30a66fb · 2026-04-22T16:34:56.000+02:00
* Update to R# v2026.1.0.1

* Fix R# warning: Member can be private

* Fix R# warning: Type can be internal

* Fix R# warning: Type is never used

* Fix R# warning: Method return value is never used

* Fix R# warning: Captured variable is disposed in the outer scope

* Fix R# warning: Convert into method group

* Fix R# warning: Use nameof

* Fix R# warning: Type is never instantiated

* Fix R# warning: Short-lived HttpClient

* Fix R# warning: Missing doc-comment on public type

* Fix R# warning: auto-property is never used

* Fix CA1859: Use concrete types when possible for improved performance

* Cleanup sandbox types
diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
@@ -3,7 +3,7 @@
   "isRoot": true,
   "tools": {
     "jetbrains.resharper.globaltools": {
-      "version": "2025.3.3",
+      "version": "2026.1.0.1",
       "commands": [
         "jb"
       ],
diff --git a/src/Common/src/Hosting/HostBuilderWrapper.cs b/src/Common/src/Hosting/HostBuilderWrapper.cs
@@ -86,14 +86,14 @@ private static void InvokeDeferredActions<TArgument>(IEnumerable<Action<HostBuil
         }
     }
 
-    public HostBuilderWrapper ConfigureServices(Action<IServiceCollection> configureAction)
+    public void ConfigureServices(Action<IServiceCollection> configureAction)
     {
         ArgumentNullException.ThrowIfNull(configureAction);
 
-        return ConfigureServices((_, services) => configureAction(services));
+        ConfigureServices((_, services) => configureAction(services));
     }
 
-    public HostBuilderWrapper ConfigureServices(Action<HostBuilderContextWrapper, IServiceCollection> configureAction)
+    public void ConfigureServices(Action<HostBuilderContextWrapper, IServiceCollection> configureAction)
     {
         ArgumentNullException.ThrowIfNull(configureAction);
 
@@ -106,18 +106,16 @@ public HostBuilderWrapper ConfigureServices(Action<HostBuilderContextWrapper, IS
         {
             _configureServicesActions.Add(configureAction);
         }
-
-        return this;
     }
 
-    public HostBuilderWrapper ConfigureAppConfiguration(Action<IConfigurationBuilder> configureAction)
+    public void ConfigureAppConfiguration(Action<IConfigurationBuilder> configureAction)
     {
         ArgumentNullException.ThrowIfNull(configureAction);
 
-        return ConfigureAppConfiguration((_, configurationBuilder) => configureAction(configurationBuilder));
+        ConfigureAppConfiguration((_, configurationBuilder) => configureAction(configurationBuilder));
     }
 
-    public HostBuilderWrapper ConfigureAppConfiguration(Action<HostBuilderContextWrapper, IConfigurationBuilder> configureAction)
+    public void ConfigureAppConfiguration(Action<HostBuilderContextWrapper, IConfigurationBuilder> configureAction)
     {
         ArgumentNullException.ThrowIfNull(configureAction);
 
@@ -130,18 +128,16 @@ public HostBuilderWrapper ConfigureAppConfiguration(Action<HostBuilderContextWra
         {
             _configureAppConfigurationActions.Add(configureAction);
         }
-
-        return this;
     }
 
-    public HostBuilderWrapper ConfigureLogging(Action<ILoggingBuilder> configureAction)
+    public void ConfigureLogging(Action<ILoggingBuilder> configureAction)
     {
         ArgumentNullException.ThrowIfNull(configureAction);
 
-        return ConfigureLogging((_, configurationBuilder) => configureAction(configurationBuilder));
+        ConfigureLogging((_, configurationBuilder) => configureAction(configurationBuilder));
     }
 
-    public HostBuilderWrapper ConfigureLogging(Action<HostBuilderContextWrapper, ILoggingBuilder> configureAction)
+    public void ConfigureLogging(Action<HostBuilderContextWrapper, ILoggingBuilder> configureAction)
     {
         ArgumentNullException.ThrowIfNull(configureAction);
 
@@ -156,11 +152,9 @@ public HostBuilderWrapper ConfigureLogging(Action<HostBuilderContextWrapper, ILo
             _configureServicesActions.Add((contextWrapper, collection) => collection.AddLogging(builder => configureAction(contextWrapper, builder)));
 #pragma warning restore S4792 // Configuring loggers is security-sensitive
         }
-
-        return this;
     }
 
-    public HostBuilderWrapper ConfigureWebHost(Action<IWebHostBuilder> configureAction)
+    public void ConfigureWebHost(Action<IWebHostBuilder> configureAction)
     {
         ArgumentNullException.ThrowIfNull(configureAction);
 
@@ -184,7 +178,5 @@ public HostBuilderWrapper ConfigureWebHost(Action<IWebHostBuilder> configureActi
         {
             throw new NotSupportedException($"Unknown host builder type '{_innerBuilder.GetType()}'.");
         }
-
-        return this;
     }
 }
diff --git a/src/Common/test/Hosting.Test/HostBuilderWrapperTest.cs b/src/Common/test/Hosting.Test/HostBuilderWrapperTest.cs
@@ -29,6 +29,7 @@ public async Task WebApplicationBuilder_Wraps()
         HostBuilderWrapper wrapper = HostBuilderWrapper.Wrap(builder);
         wrapper.ConfigureServices(services => services.AddSingleton<InjectableType>());
         wrapper.ConfigureAppConfiguration(configurationBuilder => configurationBuilder.AddInMemoryCollection(appSettings));
+        // ReSharper disable once AccessToDisposedClosure
         wrapper.ConfigureLogging(loggingBuilder => loggingBuilder.AddProvider(capturingLoggerProvider));
         wrapper.ConfigureWebHost(hostBuilder => hostBuilder.UseUrls("http://*:8888"));
         wrapper.ConfigureServices((contextWrapper, _) => contextWrapper.HostEnvironment.ApplicationName = "TestApp");
@@ -64,6 +65,7 @@ public void HostApplicationBuilder_Wraps()
         HostBuilderWrapper wrapper = HostBuilderWrapper.Wrap(builder);
         wrapper.ConfigureServices(services => services.AddSingleton<InjectableType>());
         wrapper.ConfigureAppConfiguration(configurationBuilder => configurationBuilder.AddInMemoryCollection(appSettings));
+        // ReSharper disable once AccessToDisposedClosure
         wrapper.ConfigureLogging(loggingBuilder => loggingBuilder.AddProvider(capturingLoggerProvider));
         wrapper.ConfigureServices((contextWrapper, _) => contextWrapper.HostEnvironment.ApplicationName = "TestApp");
 
@@ -98,6 +100,7 @@ public void WebHostBuilder_Wraps()
         HostBuilderWrapper wrapper = HostBuilderWrapper.Wrap(builder);
         wrapper.ConfigureServices(services => services.AddSingleton<InjectableType>());
         wrapper.ConfigureAppConfiguration(configurationBuilder => configurationBuilder.AddInMemoryCollection(appSettings));
+        // ReSharper disable once AccessToDisposedClosure
         wrapper.ConfigureLogging(loggingBuilder => loggingBuilder.AddProvider(capturingLoggerProvider));
         wrapper.ConfigureWebHost(hostBuilder => hostBuilder.UseUrls("http://*:8888"));
         wrapper.ConfigureServices((contextWrapper, _) => contextWrapper.HostEnvironment.ApplicationName = "TestApp");
@@ -135,6 +138,7 @@ public void GenericHostBuilder_Wraps()
         HostBuilderWrapper wrapper = HostBuilderWrapper.Wrap(builder);
         wrapper.ConfigureServices(services => services.AddSingleton<InjectableType>());
         wrapper.ConfigureAppConfiguration(configurationBuilder => configurationBuilder.AddInMemoryCollection(appSettings));
+        // ReSharper disable once AccessToDisposedClosure
         wrapper.ConfigureLogging(loggingBuilder => loggingBuilder.AddProvider(capturingLoggerProvider));
         wrapper.ConfigureWebHost(hostBuilder => hostBuilder.UseUrls("http://*:8888"));
         wrapper.ConfigureServices((contextWrapper, _) => contextWrapper.HostEnvironment.ApplicationName = "TestApp");
diff --git a/src/Common/test/Logging.Test/BootstrapperLoggerFactoryTest.cs b/src/Common/test/Logging.Test/BootstrapperLoggerFactoryTest.cs
@@ -20,6 +20,7 @@ public async Task Upgrades_existing_loggers()
         var bootstrapLoggerFactory = BootstrapLoggerFactory.CreateEmpty(loggingBuilder =>
         {
             loggingBuilder.SetMinimumLevel(LogLevel.Trace);
+            // ReSharper disable once AccessToDisposedClosure
             loggingBuilder.AddProvider(capturingLoggerProvider);
         });
 
diff --git a/src/Common/test/TestResources/EmptyDisposable.cs b/src/Common/test/TestResources/EmptyDisposable.cs
@@ -7,7 +7,7 @@ namespace Steeltoe.Common.TestResources;
 /// <summary>
 /// Implements <see cref="IDisposable" /> without doing anything.
 /// </summary>
-public sealed class EmptyDisposable : IDisposable
+internal sealed class EmptyDisposable : IDisposable
 {
     public static IDisposable Instance { get; } = new EmptyDisposable();
 
diff --git a/src/Common/test/TestResources/IO/Sandbox.cs b/src/Common/test/TestResources/IO/Sandbox.cs
@@ -29,30 +29,13 @@ public Sandbox()
     /// <returns>
     /// The physical path.
     /// </returns>
-    public string ResolvePath(string path)
+    private string ResolvePath(string path)
     {
         ArgumentNullException.ThrowIfNull(path);
 
         return Path.Combine(FullPath, path);
     }
 
-    /// <summary>
-    /// Creates a directory at the specified path within the sandbox.
-    /// </summary>
-    /// <param name="path">
-    /// The directory path.
-    /// </param>
-    /// <returns>
-    /// The physical path of the created directory.
-    /// </returns>
-    public string CreateDirectory(string path)
-    {
-        ArgumentNullException.ThrowIfNull(path);
-
-        DirectoryInfo directoryInfo = Directory.CreateDirectory(ResolvePath(path));
-        return directoryInfo.FullName;
-    }
-
     /// <summary>
     /// Creates a file at the specified path within the sandbox.
     /// </summary>
diff --git a/src/Common/test/TestResources/IO/TempDirectory.cs b/src/Common/test/TestResources/IO/TempDirectory.cs
@@ -9,21 +9,13 @@ namespace Steeltoe.Common.TestResources.IO;
 /// </summary>
 public class TempDirectory : TempPath
 {
-    /// <summary>
-    /// Initializes a new instance of the <see cref="TempDirectory" /> class.
-    /// </summary>
-    public TempDirectory()
-        : base(string.Empty)
-    {
-    }
-
     /// <summary>
     /// Initializes a new instance of the <see cref="TempDirectory" /> class.
     /// </summary>
     /// <param name="prefix">
     /// Directory name prefix.
     /// </param>
-    public TempDirectory(string prefix)
+    protected TempDirectory(string prefix)
         : base(prefix)
     {
     }
diff --git a/src/Common/test/TestResources/IO/TempFile.cs b/src/Common/test/TestResources/IO/TempFile.cs
@@ -17,17 +17,6 @@ public TempFile()
     {
     }
 
-    /// <summary>
-    /// Initializes a new instance of the <see cref="TempFile" /> class.
-    /// </summary>
-    /// <param name="prefix">
-    /// File name prefix.
-    /// </param>
-    public TempFile(string prefix)
-        : base(prefix)
-    {
-    }
-
     /// <summary>
     /// Creates the temporary file.
     /// </summary>
diff --git a/src/Configuration/src/ConfigServer/ConfigServerConfigurationProvider.cs b/src/Configuration/src/ConfigServer/ConfigServerConfigurationProvider.cs
@@ -375,7 +375,7 @@ public override void Load()
         return await DoLoadAsync(optionsSnapshot, updateDictionary, cancellationToken);
     }
 
-    internal async Task<ConfigEnvironment?> DoLoadAsync(ConfigServerClientOptions optionsSnapshot, bool updateDictionary, CancellationToken cancellationToken)
+    private async Task<ConfigEnvironment?> DoLoadAsync(ConfigServerClientOptions optionsSnapshot, bool updateDictionary, CancellationToken cancellationToken)
     {
         LogFetchingRemoteConfiguration();
 
diff --git a/src/Configuration/test/ConfigServer.Test/ConfigServerConfigurationProviderTest.Loading.cs b/src/Configuration/test/ConfigServer.Test/ConfigServerConfigurationProviderTest.Loading.cs
@@ -787,7 +787,7 @@ await TestFailureTracer.CaptureAsync(async tracer =>
 
             using var provider = new ConfigServerConfigurationProvider(options, null, null, () => handler, tracer.LoggerFactory);
 
-            Action action = () => provider.Load();
+            Action action = provider.Load;
 
             action.Should().ThrowExactly<ConfigServerException>();
 
diff --git a/src/Configuration/test/ConfigServer.Test/HttpRequestInfo.cs b/src/Configuration/test/ConfigServer.Test/HttpRequestInfo.cs
diff --git a/src/Configuration/test/Kubernetes.ServiceBindings.Test/KubernetesServiceBindingConfigurationProviderTest.cs b/src/Configuration/test/Kubernetes.ServiceBindings.Test/KubernetesServiceBindingConfigurationProviderTest.cs
@@ -123,7 +123,7 @@ private static string GetEmptyK8SResourcesDirectory()
 
     private sealed class TestPostProcessor : IConfigurationPostProcessor
     {
-        public bool PostProcessorCalled { get; set; }
+        public bool PostProcessorCalled { get; private set; }
 
         public void PostProcessConfiguration(PostProcessorConfigurationProvider provider, IDictionary<string, string?> configurationData)
         {
diff --git a/src/Discovery/src/Eureka/EurekaDiscoveryClient.cs b/src/Discovery/src/Eureka/EurekaDiscoveryClient.cs
@@ -161,7 +161,7 @@ public EurekaDiscoveryClient(EurekaApplicationInfoManager appInfoManager, Eureka
         return Applications.GetRegisteredApplication(appName);
     }
 
-    internal IReadOnlyList<InstanceInfo> GetInstancesByVipAddress(string vipAddress)
+    private ReadOnlyCollection<InstanceInfo> GetInstancesByVipAddress(string vipAddress)
     {
         ArgumentException.ThrowIfNullOrWhiteSpace(vipAddress);
 
@@ -576,7 +576,7 @@ public Task<IList<IServiceInstance>> GetInstancesAsync(string serviceId, Cancell
     {
         ArgumentException.ThrowIfNullOrWhiteSpace(serviceId);
 
-        IReadOnlyList<InstanceInfo> instances = GetInstancesByVipAddress(serviceId);
+        ReadOnlyCollection<InstanceInfo> instances = GetInstancesByVipAddress(serviceId);
         IServiceInstance[] serviceInstances = instances.Select(instance => new EurekaServiceInstance(instance)).Cast<IServiceInstance>().ToArray();
 
         if (_logger.IsEnabled(LogLevel.Debug))
diff --git a/src/Discovery/test/Eureka.Test/Transport/EurekaClientTest.cs b/src/Discovery/test/Eureka.Test/Transport/EurekaClientTest.cs
@@ -13,6 +13,8 @@
 using Steeltoe.Discovery.Eureka.Configuration;
 using Steeltoe.Discovery.Eureka.Transport;
 
+// ReSharper disable AccessToDisposedClosure
+
 namespace Steeltoe.Discovery.Eureka.Test.Transport;
 
 public sealed class EurekaClientTest
diff --git a/src/Management/test/Endpoint.Test/Actuators/CloudFoundry/CloudFoundrySecurityMiddlewareTest.cs b/src/Management/test/Endpoint.Test/Actuators/CloudFoundry/CloudFoundrySecurityMiddlewareTest.cs
@@ -337,6 +337,7 @@ public async Task RedactsHttpHeaders()
         WebApplicationBuilder builder = TestWebApplicationBuilderFactory.Create();
         builder.Configuration.AddInMemoryCollection(appSettings);
         builder.Configuration.AddCloudFoundry();
+        // ReSharper disable once AccessToDisposedClosure
         builder.Services.AddLogging(options => options.SetMinimumLevel(LogLevel.Trace).AddProvider(capturingLoggerProvider));
         builder.Services.AddCloudFoundryActuator();
         await using WebApplication app = builder.Build();
@@ -378,7 +379,9 @@ public async Task Returns_expected_response_on_permission_check(string scenario,
         host.Services.GetRequiredService<HttpClientHandlerFactory>().Using(CloudControllerPermissionsMock.GetHttpMessageHandler());
         await host.StartAsync(TestContext.Current.CancellationToken);
 
+        // ReSharper disable once ShortLivedHttpClient
         using var client = new HttpClient();
+
         var authenticationRequest = new HttpRequestMessage(HttpMethod.Get, new Uri("http://localhost:5000/cloudfoundryapplication"));
         authenticationRequest.Headers.Authorization = new AuthenticationHeaderValue("Bearer", MockAccessToken);
         var authorizationRequest = new HttpRequestMessage(HttpMethod.Get, new Uri("http://localhost:5000/cloudfoundryapplication/info"));
diff --git a/src/Management/test/Endpoint.Test/Actuators/Health/Availability/ApplicationAvailabilityTest.cs b/src/Management/test/Endpoint.Test/Actuators/Health/Availability/ApplicationAvailabilityTest.cs
@@ -20,9 +20,9 @@ public void TracksAndReturnsState()
     {
         var availability = new ApplicationAvailability(NullLogger<ApplicationAvailability>.Instance);
 
-        availability.SetAvailabilityState("Test", LivenessState.Broken, GetType().Name);
-        availability.SetAvailabilityState(ApplicationAvailability.LivenessKey, LivenessState.Correct, GetType().Name);
-        availability.SetAvailabilityState(ApplicationAvailability.ReadinessKey, ReadinessState.AcceptingTraffic, GetType().Name);
+        availability.SetAvailabilityState("Test", LivenessState.Broken, nameof(ApplicationAvailabilityTest));
+        availability.SetAvailabilityState(ApplicationAvailability.LivenessKey, LivenessState.Correct, nameof(ApplicationAvailabilityTest));
+        availability.SetAvailabilityState(ApplicationAvailability.ReadinessKey, ReadinessState.AcceptingTraffic, nameof(ApplicationAvailabilityTest));
 
         availability.GetAvailabilityState("Test").Should().Be(LivenessState.Broken);
         availability.GetLivenessState().Should().Be(LivenessState.Correct);
diff --git a/src/Management/test/Endpoint.Test/Actuators/Health/TestContributors/ComplexDetailsContributor.cs b/src/Management/test/Endpoint.Test/Actuators/Health/TestContributors/ComplexDetailsContributor.cs
@@ -39,6 +39,7 @@ internal sealed class ComplexDetailsContributor : IHealthContributor
 
     private sealed class TestHealthDetails
     {
+        // ReSharper disable UnusedAutoPropertyAccessor.Local
         [JsonPropertyName("testString")]
         public string TestString { get; set; } = "test-string";
 
@@ -69,5 +70,6 @@ private sealed class TestHealthDetails
             ["Two"] = 2,
             ["Three"] = 3
         };
+        // ReSharper restore UnusedAutoPropertyAccessor.Local
     }
 }
diff --git a/src/Management/test/Endpoint.Test/Actuators/HttpExchanges/DiagnosticObserverHttpExchangeRecorderTest.cs b/src/Management/test/Endpoint.Test/Actuators/HttpExchanges/DiagnosticObserverHttpExchangeRecorderTest.cs
@@ -52,6 +52,7 @@ public async Task Records_http_requests()
         host.MapGet("/hello", () => "Hello World!");
         await host.StartAsync(TestContext.Current.CancellationToken);
 
+        // ReSharper disable once ShortLivedHttpClient
         using var httpClient = new HttpClient();
 
         HttpResponseMessage helloResponse =
diff --git a/src/Management/test/Tasks.Test/TaskHostExtensionsTest.cs b/src/Management/test/Tasks.Test/TaskHostExtensionsTest.cs
@@ -199,6 +199,7 @@ public async Task WebApplication_LogsErrorOnUnknownTask()
         WebApplicationBuilder builder = TestWebApplicationBuilderFactory.Create(args);
 
         using var capturingLoggerProvider = new CapturingLoggerProvider(category => category.StartsWith("Steeltoe.", StringComparison.Ordinal));
+        // ReSharper disable once AccessToDisposedClosure
         builder.Services.AddLogging(options => options.AddProvider(capturingLoggerProvider));
 
         WebApplication app = builder.Build();
@@ -338,6 +339,7 @@ public async Task RunAsync(CancellationToken cancellationToken)
         }
     }
 
+    // ReSharper disable once ClassNeverInstantiated.Local
     private sealed class ThrowingApplicationTask : IApplicationTask
     {
         public Task RunAsync(CancellationToken cancellationToken)
diff --git a/src/Steeltoe.All.sln.DotSettings b/src/Steeltoe.All.sln.DotSettings
diff --git a/src/Tools/test/ConfigurationSchemaGenerator.Tests/GeneratorTests.cs b/src/Tools/test/ConfigurationSchemaGenerator.Tests/GeneratorTests.cs

Original file line number	Diff line number	Diff line change
`@@ -86,14 +86,14 @@ private static void InvokeDeferredActions<TArgument>(IEnumerable<Action<HostBuil`
`86`	`86`	`}`
`87`	`87`	`}`
`88`	`88`
`89`		`- public HostBuilderWrapper ConfigureServices(Action<IServiceCollection> configureAction)`
	`89`	`+ public void ConfigureServices(Action<IServiceCollection> configureAction)`
`90`	`90`	`{`
`91`	`91`	`ArgumentNullException.ThrowIfNull(configureAction);`
`92`	`92`
`93`		`- return ConfigureServices((_, services) => configureAction(services));`
	`93`	`+ ConfigureServices((_, services) => configureAction(services));`
`94`	`94`	`}`
`95`	`95`
`96`		`- public HostBuilderWrapper ConfigureServices(Action<HostBuilderContextWrapper, IServiceCollection> configureAction)`
	`96`	`+ public void ConfigureServices(Action<HostBuilderContextWrapper, IServiceCollection> configureAction)`
`97`	`97`	`{`
`98`	`98`	`ArgumentNullException.ThrowIfNull(configureAction);`
`99`	`99`
`@@ -106,18 +106,16 @@ public HostBuilderWrapper ConfigureServices(Action<HostBuilderContextWrapper, IS`
`106`	`106`	`{`
`107`	`107`	`_configureServicesActions.Add(configureAction);`
`108`	`108`	`}`
`109`		`-`
`110`		`- return this;`
`111`	`109`	`}`
`112`	`110`
`113`		`- public HostBuilderWrapper ConfigureAppConfiguration(Action<IConfigurationBuilder> configureAction)`
	`111`	`+ public void ConfigureAppConfiguration(Action<IConfigurationBuilder> configureAction)`
`114`	`112`	`{`
`115`	`113`	`ArgumentNullException.ThrowIfNull(configureAction);`
`116`	`114`
`117`		`- return ConfigureAppConfiguration((_, configurationBuilder) => configureAction(configurationBuilder));`
	`115`	`+ ConfigureAppConfiguration((_, configurationBuilder) => configureAction(configurationBuilder));`
`118`	`116`	`}`
`119`	`117`
`120`		`- public HostBuilderWrapper ConfigureAppConfiguration(Action<HostBuilderContextWrapper, IConfigurationBuilder> configureAction)`
	`118`	`+ public void ConfigureAppConfiguration(Action<HostBuilderContextWrapper, IConfigurationBuilder> configureAction)`
`121`	`119`	`{`
`122`	`120`	`ArgumentNullException.ThrowIfNull(configureAction);`
`123`	`121`
`@@ -130,18 +128,16 @@ public HostBuilderWrapper ConfigureAppConfiguration(Action<HostBuilderContextWra`
`130`	`128`	`{`
`131`	`129`	`_configureAppConfigurationActions.Add(configureAction);`
`132`	`130`	`}`
`133`		`-`
`134`		`- return this;`
`135`	`131`	`}`
`136`	`132`
`137`		`- public HostBuilderWrapper ConfigureLogging(Action<ILoggingBuilder> configureAction)`
	`133`	`+ public void ConfigureLogging(Action<ILoggingBuilder> configureAction)`
`138`	`134`	`{`
`139`	`135`	`ArgumentNullException.ThrowIfNull(configureAction);`
`140`	`136`
`141`		`- return ConfigureLogging((_, configurationBuilder) => configureAction(configurationBuilder));`
	`137`	`+ ConfigureLogging((_, configurationBuilder) => configureAction(configurationBuilder));`
`142`	`138`	`}`
`143`	`139`
`144`		`- public HostBuilderWrapper ConfigureLogging(Action<HostBuilderContextWrapper, ILoggingBuilder> configureAction)`
	`140`	`+ public void ConfigureLogging(Action<HostBuilderContextWrapper, ILoggingBuilder> configureAction)`
`145`	`141`	`{`
`146`	`142`	`ArgumentNullException.ThrowIfNull(configureAction);`
`147`	`143`
`@@ -156,11 +152,9 @@ public HostBuilderWrapper ConfigureLogging(Action<HostBuilderContextWrapper, ILo`
`156`	`152`	`_configureServicesActions.Add((contextWrapper, collection) => collection.AddLogging(builder => configureAction(contextWrapper, builder)));`
`157`	`153`	`#pragma warning restore S4792 // Configuring loggers is security-sensitive`
`158`	`154`	`}`
`159`		`-`
`160`		`- return this;`
`161`	`155`	`}`
`162`	`156`
`163`		`- public HostBuilderWrapper ConfigureWebHost(Action<IWebHostBuilder> configureAction)`
	`157`	`+ public void ConfigureWebHost(Action<IWebHostBuilder> configureAction)`
`164`	`158`	`{`
`165`	`159`	`ArgumentNullException.ThrowIfNull(configureAction);`
`166`	`160`
`@@ -184,7 +178,5 @@ public HostBuilderWrapper ConfigureWebHost(Action<IWebHostBuilder> configureActi`
`184`	`178`	`{`
`185`	`179`	`throw new NotSupportedException($"Unknown host builder type '{_innerBuilder.GetType()}'.");`
`186`	`180`	`}`
`187`		`-`
`188`		`- return this;`
`189`	`181`	`}`
`190`	`182`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@ public async Task Upgrades_existing_loggers()`
`20`	`20`	`var bootstrapLoggerFactory = BootstrapLoggerFactory.CreateEmpty(loggingBuilder =>`
`21`	`21`	`{`
`22`	`22`	`loggingBuilder.SetMinimumLevel(LogLevel.Trace);`
	`23`	`+ // ReSharper disable once AccessToDisposedClosure`
`23`	`24`	`loggingBuilder.AddProvider(capturingLoggerProvider);`
`24`	`25`	`});`
`25`	`26`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ namespace Steeltoe.Common.TestResources;`
`7`	`7`	`/// <summary>`
`8`	`8`	`/// Implements <see cref="IDisposable" /> without doing anything.`
`9`	`9`	`/// </summary>`
`10`		`-public sealed class EmptyDisposable : IDisposable`
	`10`	`+internal sealed class EmptyDisposable : IDisposable`
`11`	`11`	`{`
`12`	`12`	`public static IDisposable Instance { get; } = new EmptyDisposable();`
`13`	`13`
Original file line number	Diff line number	Diff line change
`@@ -375,7 +375,7 @@ public override void Load()`
`375`	`375`	`return await DoLoadAsync(optionsSnapshot, updateDictionary, cancellationToken);`
`376`	`376`	`}`
`377`	`377`
`378`		`- internal async Task<ConfigEnvironment?> DoLoadAsync(ConfigServerClientOptions optionsSnapshot, bool updateDictionary, CancellationToken cancellationToken)`
	`378`	`+ private async Task<ConfigEnvironment?> DoLoadAsync(ConfigServerClientOptions optionsSnapshot, bool updateDictionary, CancellationToken cancellationToken)`
`379`	`379`	`{`
`380`	`380`	`LogFetchingRemoteConfiguration();`
`381`	`381`