Skip to content

Commit 3e1cb39

Browse files
authored
Fix broken documentation in Steeltoe 3.x (#1654)
1 parent 8612abd commit 3e1cb39

4 files changed

Lines changed: 41 additions & 26 deletions

File tree

src/Common/src/Common.Http/LoadBalancer/LoadBalancerDelegatingHandler.cs

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,10 @@ public class LoadBalancerDelegatingHandler : DelegatingHandler
2020
private readonly ILoadBalancer _loadBalancer;
2121

2222
/// <summary>
23-
/// Initializes a new instance of the <see cref="LoadBalancerDelegatingHandler"/> class. <para />
23+
/// Initializes a new instance of the <see cref="LoadBalancerDelegatingHandler"/> class.
24+
/// <para>
2425
/// For use with <see cref="IHttpClientBuilder"/>
26+
/// </para>
2527
/// </summary>
2628
/// <param name="loadBalancer">Load balancer to use</param>
2729
public LoadBalancerDelegatingHandler(ILoadBalancer loadBalancer)
@@ -30,8 +32,10 @@ public LoadBalancerDelegatingHandler(ILoadBalancer loadBalancer)
3032
}
3133

3234
/// <summary>
33-
/// Initializes a new instance of the <see cref="LoadBalancerDelegatingHandler"/> class. <para />
35+
/// Initializes a new instance of the <see cref="LoadBalancerDelegatingHandler"/> class.
36+
/// <para>
3437
/// For use with <see cref="IHttpClientBuilder"/>
38+
/// </para>
3539
/// </summary>
3640
/// <param name="loadBalancer">Load balancer to use</param>
3741
/// <param name="logger">For logging</param>
@@ -42,7 +46,9 @@ public LoadBalancerDelegatingHandler(ILoadBalancer loadBalancer, ILogger logger)
4246
}
4347

4448
/// <inheritdoc />
45-
protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
49+
protected override async Task<HttpResponseMessage> SendAsync(
50+
HttpRequestMessage request,
51+
CancellationToken cancellationToken)
4652
{
4753
// record the original request
4854
var originalUri = request.RequestUri;
@@ -70,7 +76,8 @@ protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage
7076
request.RequestUri = originalUri;
7177

7278
// track stats
73-
await _loadBalancer.UpdateStatsAsync(originalUri, resolvedUri, DateTime.UtcNow - startTime, exception).ConfigureAwait(false);
79+
await _loadBalancer.UpdateStatsAsync(originalUri, resolvedUri, DateTime.UtcNow - startTime, exception)
80+
.ConfigureAwait(false);
7481
}
7582
}
7683
}

src/Common/src/Common.Http/LoadBalancer/LoadBalancerHttpClientHandler.cs

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,10 @@ public class LoadBalancerHttpClientHandler : HttpClientHandler
1919
private readonly ILoadBalancer _loadBalancer;
2020

2121
/// <summary>
22-
/// Initializes a new instance of the <see cref="LoadBalancerHttpClientHandler"/> class. <para />
22+
/// Initializes a new instance of the <see cref="LoadBalancerHttpClientHandler"/> class.
23+
/// <para>
2324
/// For use with <see cref="HttpClient"/> without <see cref="IHttpClientFactory"/>
25+
/// </para>
2426
/// </summary>
2527
/// <param name="loadBalancer">Load balancer to use</param>
2628
public LoadBalancerHttpClientHandler(ILoadBalancer loadBalancer)
@@ -29,8 +31,10 @@ public LoadBalancerHttpClientHandler(ILoadBalancer loadBalancer)
2931
}
3032

3133
/// <summary>
32-
/// Initializes a new instance of the <see cref="LoadBalancerHttpClientHandler"/> class. <para />
34+
/// Initializes a new instance of the <see cref="LoadBalancerHttpClientHandler"/> class.
35+
/// <para>
3336
/// For use with <see cref="HttpClient"/> without <see cref="IHttpClientFactory"/>
37+
/// </para>
3438
/// </summary>
3539
/// <param name="loadBalancer">Load balancer to use</param>
3640
/// <param name="logger">For logging</param>
@@ -41,7 +45,9 @@ public LoadBalancerHttpClientHandler(ILoadBalancer loadBalancer, ILogger logger)
4145
}
4246

4347
/// <inheritdoc />
44-
protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
48+
protected override async Task<HttpResponseMessage> SendAsync(
49+
HttpRequestMessage request,
50+
CancellationToken cancellationToken)
4551
{
4652
// record the original request
4753
var originalUri = request.RequestUri;
@@ -69,7 +75,8 @@ protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage
6975
request.RequestUri = originalUri;
7076

7177
// track stats
72-
await _loadBalancer.UpdateStatsAsync(originalUri, resolvedUri, DateTime.UtcNow - startTime, exception).ConfigureAwait(false);
78+
await _loadBalancer.UpdateStatsAsync(originalUri, resolvedUri, DateTime.UtcNow - startTime, exception)
79+
.ConfigureAwait(false);
7380
}
7481
}
7582
}

src/Discovery/src/ClientBase/SimpleClients/ConfigurationDiscoveryClientBuilderExtensions.cs

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,15 @@ public static class ConfigurationDiscoveryClientBuilderExtensions
1111
/// </summary>
1212
/// <param name="clientBuilder">this</param>
1313
/// <remarks>
14-
/// Build your list of service instances under the configuration prefix discovery:services<para></para>
15-
/// For example:
16-
/// "discovery": {
17-
/// "services": [
18-
/// { "serviceId": "CartService", "host": "knownhost1", "port": 443, "isSecure": true },
19-
/// { "serviceId": "CartService", "host": "knownhost2", "port": 443, "isSecure": true },
20-
/// ]
21-
/// }
14+
/// Build your list of service instances under the configuration prefix <c>discovery:services</c>, for example:
15+
/// <code><![CDATA[
16+
/// "discovery": {
17+
/// "services": [
18+
/// { "serviceId": "CartService", "host": "knownhost1", "port": 443, "isSecure": true },
19+
/// { "serviceId": "CartService", "host": "knownhost2", "port": 443, "isSecure": true },
20+
/// ]
21+
/// }
22+
/// ]]></code>
2223
/// </remarks>
2324
public static DiscoveryClientBuilder UseConfiguredInstances(this DiscoveryClientBuilder clientBuilder)
2425
{

src/Discovery/src/Eureka/IEurekaInstanceConfig.cs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -35,27 +35,27 @@ public interface IEurekaInstanceConfig
3535
bool IsInstanceEnabledOnInit { get; set; }
3636

3737
/// <summary>
38-
/// Gets or sets the <code>non-secure</code> port on which the instance should receive traffic.
38+
/// Gets or sets the <c>non-secure</c> port on which the instance should receive traffic.
3939
/// Configuration property: eureka:instance:port
4040
/// </summary>
4141
int NonSecurePort { get; set; }
4242

4343
/// <summary>
44-
/// Gets or sets the <code>Secure port</code> on which the instance should receive traffic.
44+
/// Gets or sets the <c>Secure port</c> on which the instance should receive traffic.
4545
/// Configuration property: eureka:instance:securePort
4646
/// </summary>
4747
int SecurePort { get; set; }
4848

4949
/// <summary>
50-
/// Gets or sets a value indicating whether indicates whether the <code>non-secure</code> port should be enabled for traffic or not.
51-
/// Set true if the <code>non-secure</code> port is enabled, false otherwise.
50+
/// Gets or sets a value indicating whether indicates whether the <c>non-secure</c> port should be enabled for traffic or not.
51+
/// Set true if the <c>non-secure</c> port is enabled, false otherwise.
5252
/// Configuration property: eureka:instance:nonSecurePortEnabled
5353
/// </summary>
5454
bool IsNonSecurePortEnabled { get; set; }
5555

5656
/// <summary>
57-
/// Gets or sets a value indicating whether indicates whether the <code>secure</code> port should be enabled for traffic or not.
58-
/// Set true if the <code>secure</code> port is enabled, false otherwise.
57+
/// Gets or sets a value indicating whether indicates whether the <c>secure</c> port should be enabled for traffic or not.
58+
/// Set true if the <c>secure</c> port is enabled, false otherwise.
5959
/// Configuration property: eureka:instance:securePortEnabled
6060
/// </summary>
6161
bool SecurePortEnabled { get; set; }
@@ -104,7 +104,7 @@ public interface IEurekaInstanceConfig
104104
string SecureVirtualHostName { get; set; }
105105

106106
/// <summary>
107-
/// Gets or sets the <code>AWS autoscaling group name</code> associated with this instance. This information is
107+
/// Gets or sets the <c>AWS autoscaling group name</c> associated with this instance. This information is
108108
/// specifically used in an AWS environment to automatically put an instance out of service after the instance is
109109
/// launched and it has been disabled for traffic..
110110
/// Configuration property: eureka:instance:asgName
@@ -136,7 +136,7 @@ public interface IEurekaInstanceConfig
136136
/// <see cref="SecurePort"/> and <see cref="NonSecurePort"/>.
137137
///
138138
/// It is normally used for informational purposes for other services to findabout the status of this instance.
139-
/// Users can provide a simple <code>HTML</code> indicating what is the current status of the instance.
139+
/// Users can provide a simple <c>HTML</c> page indicating what is the current status of the instance.
140140
/// Configuration property: eureka:instance:statusPageUrlPath
141141
/// </summary>
142142
string StatusPageUrlPath { get; set; }
@@ -147,7 +147,7 @@ public interface IEurekaInstanceConfig
147147
/// users can provide the full URL. If the full URL is provided it takes precedence.
148148
///
149149
/// It is normally used for informational purposes for other services tofind about the status of this instance.
150-
/// Users can provide a simple<code>HTML</code> indicating what is the current status of the instance.
150+
/// Users can provide a simple <c>HTML</c> page indicating what is the current status of the instance.
151151
/// The full URL should follow the format http://${eureka.hostname}:7001/ where the value ${eureka.hostname} is
152152
/// replaced at runtime.
153153
/// Configuration property: eureka:instance:statusPageUrl
@@ -170,7 +170,7 @@ public interface IEurekaInstanceConfig
170170
/// provide the full URL. If the full URL is provided it takes precedence.
171171
///
172172
/// It is normally used for informational purposes for other services tofind about the status of this instance.
173-
/// Users can provide a simple<code>HTML</code> indicating what is the current status of the instance.
173+
/// Users can provide a simple <c>HTML</c> page indicating what is the current status of the instance.
174174
/// The full URL should follow the format http://${eureka.hostname}:7001/ where the value ${eureka.hostname} is
175175
/// replaced at runtime.
176176
/// Configuration property: eureka:instance:homePageUrl

0 commit comments

Comments
 (0)