Fix Hystrix Dashboard→Skunkworks, GemFire page links, TAS SSO→Single Sign-On, restore Metric Registrar link, always post PR comment

Co-authored-by: TimHess <3947063+TimHess@users.noreply.github.com>

Author: Copilot

.github/workflows/check-links.yml

@@ -50,8 +50,8 @@ jobs:
           fail: true
           jobSummary: true
 
-      - name: Comment on PR with broken links
-        if: failure() && github.event_name == 'pull_request'
+      - name: Comment on PR with link check results
+        if: always() && github.event_name == 'pull_request'
         uses: mshick/add-pr-comment@v2
         with:
           message-id: broken-links-check

docs/docs/v2/circuitbreaker/hystrix.md

@@ -8,7 +8,7 @@ Each Hystrix command also has the ability to create a timeout for any calls that
 
 Each command has a built-in configurable circuit breaker that stops all requests to failing back-end dependencies when the error percentage passes a threshold. The circuit remains open (broken) for a configurable period of time, and all requests are then sent to the fallback mechanism until the circuit is closed (connected) again.
 
-Hystrix also provides a means to measure command successes, failures, timeouts, short-circuits, and thread rejections. Statistics are gathered for all of these and can optionally be reported to a [Hystrix Dashboard](https://github.com/Netflix/Hystrix/wiki) for monitoring in real-time.
+Hystrix also provides a means to measure command successes, failures, timeouts, short-circuits, and thread rejections. Statistics are gathered for all of these and can optionally be reported to a [Hystrix Dashboard](https://github.com/Netflix-Skunkworks/hystrix-dashboard) for monitoring in real-time.
 
 The remaining sections of this chapter describe these features. Also, you should understand that Steeltoe's Hystrix implementation follows the Netflix implementation closely. As a result, its worthwhile to review the [Netflix documentation](https://github.com/Netflix/Hystrix/wiki) in addition to this documentation.  Pay particular attention to the [How it Works](https://github.com/Netflix/Hystrix/wiki/How-it-Works) section as it provides a [Flow Chart](https://github.com/Netflix/Hystrix/wiki/How-it-Works#Flow) explaining how a command executes and how the default [Circuit Breaker](https://github.com/Netflix/Hystrix/wiki/How-it-Works#CircuitBreaker) transitions between CLOSED, OPEN and HALF-OPEN states.  It also provides details on how the [Bulkhead pattern](https://learn.microsoft.com/azure/architecture/patterns/bulkhead) is implemented using isolation techniques employing [Threads and Thread Pools](https://github.com/Netflix/Hystrix/wiki/How-it-Works#isolation).
 
@@ -26,7 +26,7 @@ You should also have a good understanding of how the [ASP.NET Core Startup class
 
 In addition to the information below, review the [Netflix Hystrix Wiki](https://github.com/Netflix/Hystrix/wiki). The Steeltoe Hystrix framework implementation aligns closely with the Netflix implementation. Consequently, the Wiki information applies directly to Steeltoe.
 
-If you plan to use the Hystrix Dashboard, you should also spend time understanding the [Netflix Hystrix Dashboard](https://github.com/Netflix/Hystrix/wiki) information on the wiki.
+If you plan to use the Hystrix Dashboard, you should also spend time understanding the [Netflix Hystrix Dashboard](https://github.com/Netflix-Skunkworks/hystrix-dashboard) information on the wiki.
 
 To use the Steeltoe framework:
 
@@ -61,7 +61,7 @@ To add this type of NuGet to your project add something like the following `Pack
 </ItemGroup>
 ```
 
-The second type of NuGet that you need to consider pertains to Hystrix metrics. If you are developing an ASP.NET Core application and plan on using Hystrix metrics and the [Netflix Hystrix Dashboard](https://github.com/Netflix/Hystrix/wiki) then you need to also include the `Steeltoe.CircuitBreaker.Hystrix.MetricsEventsCore` package in your application.
+The second type of NuGet that you need to consider pertains to Hystrix metrics. If you are developing an ASP.NET Core application and plan on using Hystrix metrics and the [Netflix Hystrix Dashboard](https://github.com/Netflix-Skunkworks/hystrix-dashboard) then you need to also include the `Steeltoe.CircuitBreaker.Hystrix.MetricsEventsCore` package in your application.
 
 To do this include the following `PackageReference` in your application:
 
@@ -788,7 +788,7 @@ As HystrixCommands run, they generate metrics and status information on outcomes
 
 With Steeltoe, you can currently choose from two dashboards.
 
-The first is the [Netflix Hystrix Dashboard](https://github.com/Netflix/Hystrix/wiki). This dashboard is appropriate when you are not running your application on Cloud Foundry -- for example, when you are developing and testing your application locally on your desktop.
+The first is the [Netflix Hystrix Dashboard](https://github.com/Netflix-Skunkworks/hystrix-dashboard). This dashboard is appropriate when you are not running your application on Cloud Foundry -- for example, when you are developing and testing your application locally on your desktop.
 
 The second is the Spring Cloud Services Hystrix Dashboard. This dashboard was part of the Spring Cloud Services v2 offering and was made available to applications through the normal service instance binding mechanisms on Cloud Foundry.
 

docs/docs/v2/connectors/gemfire.md

@@ -4,7 +4,7 @@
 
 [VMware Tanzu GemFire](https://www.vmware.com/products/app-platform/tanzu-data-intelligence/gemfire) is VMware's distribution of [Apache Geode](https://geode.apache.org/). This connector was built for using GemFire in an application using the [GemFire Native Client](https://techdocs.broadcom.com/us/en/vmware-tanzu/data-solutions/tanzu-gemfire-native-client/10-4/gf-nc/dotnet-about-client-users-guide.html) on Cloud Foundry. It has not been extensively tested under other deployment configurations, but will be best-effort supported for other situations as well.
 
->WARNING: The GemFire Native Client currently only supports 64 bit applications running on Windows. See [GemFire Native Client System Requirements](https://techdocs.broadcom.com/us/en/vmware-tanzu/data-solutions/tanzu-gemfire-native-client/10-4/gf-nc/dotnet-about-client-users-guide.html) for more.
+>WARNING: The GemFire Native Client currently only supports 64 bit applications running on Windows. See [GemFire Native Client System Requirements](https://techdocs.broadcom.com/us/en/vmware-tanzu/data-solutions/tanzu-gemfire-native-client/10-4/gf-nc/dotnet-system_requirements.html) for more.
 
 ## Usage
 
@@ -46,7 +46,7 @@ For example, if you want to set the log-level and connection timeout, use the fo
 }
 ```
 
-Refer to the [GemFire documentation](https://techdocs.broadcom.com/us/en/vmware-tanzu/data-solutions/tanzu-gemfire-native-client/10-4/gf-nc/dotnet-about-client-users-guide.html) for a more complete list of settings to configure.
+Refer to the [GemFire documentation](https://techdocs.broadcom.com/us/en/vmware-tanzu/data-solutions/tanzu-gemfire-native-client/10-4/gf-nc/dotnet-configuring-sysprops.html) for a more complete list of settings to configure.
 
 ### Cloud Foundry
 
@@ -67,7 +67,7 @@ cf bind-service myApp myPCCService
 cf restage myApp
 ```
 
-If your application fails to [programmatically create regions](https://techdocs.broadcom.com/us/en/vmware-tanzu/data-solutions/tanzu-gemfire-native-client/10-4/gf-nc/dotnet-about-client-users-guide.html), use the [gfsh CLI](https://techdocs.broadcom.com/us/en/vmware-tanzu/data-solutions/tanzu-gemfire/10-1/gf/tools_modules-gfsh-chapter_overview.html) to create it. You will need the gfsh url and the cluster operator credentials provided in the service binding:
+If your application fails to [programmatically create regions](https://techdocs.broadcom.com/us/en/vmware-tanzu/data-solutions/tanzu-gemfire-native-client/10-4/gf-nc/dotnet-regions.html), use the [gfsh CLI](https://techdocs.broadcom.com/us/en/vmware-tanzu/data-solutions/tanzu-gemfire/10-1/gf/tools_modules-gfsh-chapter_overview.html) to create it. You will need the gfsh url and the cluster operator credentials provided in the service binding:
 
 ```json
 "p-cloudcache": [{

docs/docs/v2/security/jwt-authentication-in-asp.NET-WCF.md

@@ -1,6 +1,6 @@
 # Resource Protection using JWT in ASP.NET Core
 
-This provider lets you control access to REST resources by using JWT tokens issued by Cloud Foundry Security services (such as [UAA Server](https://github.com/cloudfoundry/uaa) or [TAS Single-Sign-on](https://techdocs.broadcom.com/us/en/vmware-tanzu/platform/single-sign-on/1-16/sso/index.html)) in ASP.NET Core, ASP.NET WebAPI and WCF.
+This provider lets you control access to REST resources by using JWT tokens issued by Cloud Foundry Security services (such as [UAA Server](https://github.com/cloudfoundry/uaa) or [Single Sign-On](https://techdocs.broadcom.com/us/en/vmware-tanzu/platform/single-sign-on/1-16/sso/index.html)) in ASP.NET Core, ASP.NET WebAPI and WCF.
 
 Other Steeltoe sample applications can help you understand how to use this tool, including:
 
@@ -57,7 +57,7 @@ The Steeltoe sample is set up to read from `appsettings.json`.
 
 ### Cloud Foundry
 
-As mentioned earlier. you can use a couple of OAuth2 services (such as UAA Server or TAS SSO) on Cloud Foundry. Rather than explaining how to create and bind OAuth2 services to your app here, we recommend that you read the documentation provided by each of the service providers.
+As mentioned earlier. you can use a couple of OAuth2 services (such as UAA Server or Single Sign-On) on Cloud Foundry. Rather than explaining how to create and bind OAuth2 services to your app here, we recommend that you read the documentation provided by each of the service providers.
 
 Regardless of which provider you choose, once the service is bound to your application, the settings are available in `VCAP_SERVICES`.
 

docs/docs/v2/security/jwt-authentication-in-asp.NET-WebAPI.md

@@ -1,6 +1,6 @@
 # Resource Protection using JWT in ASP.NET WebAPI
 
-This provider lets you control access to REST resources by using JWT tokens issued by Cloud Foundry Security services (such as [UAA Server](https://github.com/cloudfoundry/uaa) or [TAS Single-Sign-on](https://techdocs.broadcom.com/us/en/vmware-tanzu/platform/single-sign-on/1-16/sso/index.html)) in ASP.NET Core, ASP.NET WebAPI and WCF.
+This provider lets you control access to REST resources by using JWT tokens issued by Cloud Foundry Security services (such as [UAA Server](https://github.com/cloudfoundry/uaa) or [Single Sign-On](https://techdocs.broadcom.com/us/en/vmware-tanzu/platform/single-sign-on/1-16/sso/index.html)) in ASP.NET Core, ASP.NET WebAPI and WCF.
 
 Other Steeltoe sample applications can help you understand how to use this tool, including:
 
@@ -61,13 +61,13 @@ The Steeltoe sample is set up to read from `appsettings.json`.
 
 ### Cloud Foundry
 
-As mentioned earlier, there are two auth services (UAA Server and TAS SSO) on Cloud Foundry. Rather than explaining how to create and bind those services to your app here, we recommend that you read the documentation provided by each of the service providers.
+As mentioned earlier, there are two auth services (UAA Server and Single Sign-On) on Cloud Foundry. Rather than explaining how to create and bind those services to your app here, we recommend that you read the documentation provided by each of the service providers.
 
 Regardless of which provider you choose, once the service is bound to your application, the settings are available in `VCAP_SERVICES`.
 
 #### Add Cloud Foundry JwtAuthentication
 
-In order to configure the Cloud Foundry OWIN JWT provider in your application, you will need an [OWIN Startup class](https://learn.microsoft.com/aspnet/aspnet/overview/owin-and-katana/owin-startup-class-detection) if you do not already have one, along with an `IConfigurationRoot` that includes a service binding for UAA or TAS SSO.
+In order to configure the Cloud Foundry OWIN JWT provider in your application, you will need an [OWIN Startup class](https://learn.microsoft.com/aspnet/aspnet/overview/owin-and-katana/owin-startup-class-detection) if you do not already have one, along with an `IConfigurationRoot` that includes a service binding for UAA or Single Sign-On.
 
 ```csharp
 using Owin;

docs/docs/v2/security/jwt-authentication-in-asp.NET-core.md

@@ -1,6 +1,6 @@
 # Resource Protection using JWT in ASP.NET Core
 
-This provider lets you control access to REST resources by using JWT tokens issued by Cloud Foundry Security services (such as [UAA Server](https://github.com/cloudfoundry/uaa) or [TAS Single-Sign-on](https://techdocs.broadcom.com/us/en/vmware-tanzu/platform/single-sign-on/1-16/sso/index.html)) in ASP.NET Core, ASP.NET WebAPI and WCF.
+This provider lets you control access to REST resources by using JWT tokens issued by Cloud Foundry Security services (such as [UAA Server](https://github.com/cloudfoundry/uaa) or [Single Sign-On](https://techdocs.broadcom.com/us/en/vmware-tanzu/platform/single-sign-on/1-16/sso/index.html)) in ASP.NET Core, ASP.NET WebAPI and WCF.
 
 Other Steeltoe sample applications can help you understand how to use this tool, including:
 
@@ -68,7 +68,7 @@ The samples and most templates are already set up to read from `appsettings.json
 
 ### Cloud Foundry
 
-As mentioned earlier. you can use a couple of OAuth2 services (such as UAA Server or TAS SSO) on Cloud Foundry. Rather than explaining how to create and bind OAuth2 services to your app here, we recommend that you read the documentation provided by each of the service providers.
+As mentioned earlier. you can use a couple of OAuth2 services (such as UAA Server or Single Sign-On) on Cloud Foundry. Rather than explaining how to create and bind OAuth2 services to your app here, we recommend that you read the documentation provided by each of the service providers.
 
 Regardless of which provider you choose, once the service is bound to your application, the settings are available in `VCAP_SERVICES`.
 

docs/docs/v2/security/sso-oauth2.md

@@ -1,6 +1,6 @@
 # Single Sign-on with OAuth2
 
-Single Sign-on with OAuth 2.0 enables you to leverage existing credentials configured in a [UAA Server](https://github.com/cloudfoundry/uaa) or [TAS Single-Sign-on service](https://techdocs.broadcom.com/us/en/vmware-tanzu/platform/single-sign-on/1-16/sso/index.html) for authentication and authorization in ASP.NET Core applications. Single signon functionality for ASP.NET 4.x applications is available with the OpenID Connect provider.
+Single Sign-on with OAuth 2.0 enables you to leverage existing credentials configured in a [UAA Server](https://github.com/cloudfoundry/uaa) or [Single Sign-On](https://techdocs.broadcom.com/us/en/vmware-tanzu/platform/single-sign-on/1-16/sso/index.html) for authentication and authorization in ASP.NET Core applications. Single signon functionality for ASP.NET 4.x applications is available with the OpenID Connect provider.
 
 In addition to the Quick Start, you can use other Steeltoe sample applications to help you understand how to use this provider, including:
 
@@ -73,7 +73,7 @@ The Steeltoe OAuth2 security provider options are based on [`Microsoft.AspNetCor
 
 ### Cloud Foundry
 
-As mentioned earlier, there are two OAuth-compatible services available on Cloud Foundry. We recommend you read the offical documentation ([UAA Server](https://github.com/cloudfoundry/uaa) and [TAS SSO](https://techdocs.broadcom.com/us/en/vmware-tanzu/platform/single-sign-on/1-16/sso/index.html)) or follow the instructions included in the samples for [UAA Server](https://github.com/SteeltoeOSS/Samples/blob/2.x/Security/src/AspDotNetCore/CloudFoundrySingleSignon/README.md) and [TAS SSO](https://github.com/SteeltoeOSS/Samples/blob/2.x/Security/src/AspDotNetCore/CloudFoundrySingleSignon/README-SSO.md) to quickly learn how to create and bind OAuth2 services.
+As mentioned earlier, there are two OAuth-compatible services available on Cloud Foundry. We recommend you read the offical documentation ([UAA Server](https://github.com/cloudfoundry/uaa) and [Single Sign-On](https://techdocs.broadcom.com/us/en/vmware-tanzu/platform/single-sign-on/1-16/sso/index.html)) or follow the instructions included in the samples for [UAA Server](https://github.com/SteeltoeOSS/Samples/blob/2.x/Security/src/AspDotNetCore/CloudFoundrySingleSignon/README.md) and [Single Sign-On](https://github.com/SteeltoeOSS/Samples/blob/2.x/Security/src/AspDotNetCore/CloudFoundrySingleSignon/README-SSO.md) to quickly learn how to create and bind OAuth2 services.
 
 Regardless of which provider you choose, once the service is bound to your application, the settings are available in `VCAP_SERVICES`.
 

docs/docs/v2/security/sso-open-id.md

@@ -1,6 +1,6 @@
 # Single Sign-on with OpenID Connect
 
-Single Sign-on with OpenID Connect enables you to leverage existing credentials configured in a [UAA Server](https://github.com/cloudfoundry/uaa) or [TAS Single-Sign-on service](https://techdocs.broadcom.com/us/en/vmware-tanzu/platform/single-sign-on/1-16/sso/index.html) for authentication and authorization in ASP.NET 4.x (via OWIN middleware) and ASP.NET Core applications.
+Single Sign-on with OpenID Connect enables you to leverage existing credentials configured in a [UAA Server](https://github.com/cloudfoundry/uaa) or [Single Sign-On](https://techdocs.broadcom.com/us/en/vmware-tanzu/platform/single-sign-on/1-16/sso/index.html) for authentication and authorization in ASP.NET 4.x (via OWIN middleware) and ASP.NET Core applications.
 
 ## Usage
 
@@ -79,7 +79,7 @@ This full list of settings can also be configured, though `AuthDomain`, `ClientI
 
 #### Cloud Foundry
 
-As mentioned earlier, there are two ways to use OAuth2 services on Cloud Foundry. We recommend you read the offical documentation ([UAA Server](https://github.com/cloudfoundry/uaa) and [TAS SSO](https://techdocs.broadcom.com/us/en/vmware-tanzu/platform/single-sign-on/1-16/sso/index.html)) or follow the instructions included in the samples for [UAA Server](https://github.com/SteeltoeOSS/Samples/blob/2.x/Security/src/AspDotNet4/CloudFoundrySingleSignon/README.md) and [TAS SSO](https://github.com/SteeltoeOSS/Samples/blob/2.x/Security/src/AspDotNet4/CloudFoundrySingleSignon/README-SSO.md) to quickly learn how to create and bind OAuth2 services.
+As mentioned earlier, there are two ways to use OAuth2 services on Cloud Foundry. We recommend you read the offical documentation ([UAA Server](https://github.com/cloudfoundry/uaa) and [Single Sign-On](https://techdocs.broadcom.com/us/en/vmware-tanzu/platform/single-sign-on/1-16/sso/index.html)) or follow the instructions included in the samples for [UAA Server](https://github.com/SteeltoeOSS/Samples/blob/2.x/Security/src/AspDotNet4/CloudFoundrySingleSignon/README.md) and [Single Sign-On](https://github.com/SteeltoeOSS/Samples/blob/2.x/Security/src/AspDotNet4/CloudFoundrySingleSignon/README-SSO.md) to quickly learn how to create and bind OAuth2 services.
 
 Regardless of which provider you choose, once the service is bound to your application, the settings are available in `VCAP_SERVICES`.
 
@@ -120,7 +120,7 @@ namespace CloudFoundrySingleSignon
 }
 ```
 
-The `app.UseCloudFoundryOpenIdConnect` method call adds an authentication middleware that has been configured to work with UAA or TAS SSO to the OWIN Request pipeline.
+The `app.UseCloudFoundryOpenIdConnect` method call adds an authentication middleware that has been configured to work with UAA or Single Sign-On to the OWIN Request pipeline.
 
 >TIP: This code is commonly refactored into a separate class (for example `Startup.Auth.cs`), particularly when there is additional configuration on the OWIN pipeline.