Commit f71d1b1
Both CDP backends launched Chrome with --remote-debugging-port but no
--user-data-dir. On a machine that already has Chrome open (normal on a
desktop), the new invocation forwards to the running instance on the default
profile instead of starting its own headless renderer: the CDP endpoint comes
up and trivial Runtime.evaluate works, but Page.navigate never commits and
Page.captureScreenshot hangs forever — every URL fails with done=0 after a
~180s timeout. This is the second of the two root causes in #54 (the first,
picking a non-page CDP target, was fixed in #56). It's masked on Linux/CI
because the bundled headless_shell launches fresh with no competing instance.
Give each worker an isolated, throwaway profile via tempfile.mkdtemp, pass it
as --user-data-dir, and remove it on teardown (including the connect-failure
path in the turbo backend). A unique profile per worker also prevents parallel
workers from colliding on one profile.
Also document cross-platform Chrome resolution in the README (headless_shell is
linux-x64 only; Windows/macOS use auto-detected system Chrome or CHROME_PATH).
Verified on Windows 11 with system Chrome 149: pixelshot https://example.com now
returns done=1 failed=0 with a valid tile (was a ~180s failure); temp profiles
are cleaned up; existing render/chrome tests pass.
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 5756fe7 commit f71d1b1
3 files changed
Lines changed: 43 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
233 | 240 | | |
234 | 241 | | |
235 | 242 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
27 | 28 | | |
28 | 29 | | |
| 30 | + | |
29 | 31 | | |
30 | 32 | | |
31 | 33 | | |
| |||
314 | 316 | | |
315 | 317 | | |
316 | 318 | | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
317 | 324 | | |
318 | 325 | | |
319 | 326 | | |
320 | 327 | | |
321 | | - | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
322 | 334 | | |
323 | 335 | | |
324 | 336 | | |
| |||
388 | 400 | | |
389 | 401 | | |
390 | 402 | | |
| 403 | + | |
391 | 404 | | |
392 | 405 | | |
393 | 406 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
28 | 29 | | |
29 | 30 | | |
30 | 31 | | |
| 32 | + | |
31 | 33 | | |
32 | 34 | | |
33 | 35 | | |
| |||
115 | 117 | | |
116 | 118 | | |
117 | 119 | | |
118 | | - | |
| 120 | + | |
119 | 121 | | |
120 | 122 | | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
121 | 128 | | |
122 | 129 | | |
123 | | - | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
124 | 136 | | |
125 | 137 | | |
126 | 138 | | |
| |||
142 | 154 | | |
143 | 155 | | |
144 | 156 | | |
145 | | - | |
| 157 | + | |
146 | 158 | | |
147 | 159 | | |
148 | 160 | | |
| 161 | + | |
149 | 162 | | |
150 | 163 | | |
151 | 164 | | |
152 | 165 | | |
153 | 166 | | |
154 | 167 | | |
155 | | - | |
| 168 | + | |
156 | 169 | | |
157 | 170 | | |
| 171 | + | |
158 | 172 | | |
159 | 173 | | |
160 | 174 | | |
| |||
238 | 252 | | |
239 | 253 | | |
240 | 254 | | |
| 255 | + | |
| 256 | + | |
241 | 257 | | |
242 | 258 | | |
243 | 259 | | |
| |||
328 | 344 | | |
329 | 345 | | |
330 | 346 | | |
331 | | - | |
332 | | - | |
| 347 | + | |
| 348 | + | |
333 | 349 | | |
334 | 350 | | |
335 | 351 | | |
| |||
0 commit comments