Use MySQL offset instead of weird between logic

Author: ZachyFoxx

build.gradle

@@ -8,7 +8,7 @@ plugins {
 }
 
 group = "com.dumbdogdiner"
-version = "3.1.0"
+version = "3.1.1"
 
 repositories {
     mavenCentral()

src/main/java/com/dumbdogdiner/stickycommands/commands/Sell.java

@@ -141,8 +141,8 @@ ExitCode handleLog(Player sender, Arguments a) {
             return ExitCode.EXIT_INVALID_SYNTAX.setMessage(locale.translate("invalid-syntax", variables));
 
         // I hate and love this.
-        Integer page = a.get("page") == null ? 1
-                : (NumberUtil.isNumeric(a.get("page")) ? Integer.parseInt(a.get("page")) : 1);
+        Integer page = a.get("page") == null ? 0
+                : (NumberUtil.isNumeric(a.get("page")) ? Integer.parseInt(a.get("page")) : 0);
         Database database = StickyCommands.getInstance().getDatabase();
         var salesList = database.getSaleLog(page);
 

src/main/java/com/dumbdogdiner/stickycommands/utils/Database.java

@@ -242,16 +242,9 @@ public TreeMap<String, String> getUserData(@NotNull String username) {
      */
     public List<Sale> getSaleLog(Integer page) {
         try {
-            // I can't select `DESC id` before I do my `BETWEEN` query...
-            // So, we just select everything at the bottom first!
-            // This ensures that all latest sales are at the top of the list
-            final var TOTAL = getSaleLogSize();
-            final var MAX = TOTAL - (page == 1 ? 0 : (page * 8)); // If the page is 1, we don't want to subtract 8...
-            final var MIN = MAX - 7;
-
-            PreparedStatement getSales = connection.prepareStatement("SELECT * FROM " + withPrefix("sales") + " WHERE id BETWEEN ? AND ? ORDER BY id DESC");
-            getSales.setInt(1, MIN);
-            getSales.setInt(2, MAX);
+            final var OFFSET = page * 8;
+            PreparedStatement getSales = connection.prepareStatement("SELECT * FROM " + withPrefix("sales") + " ORDER BY id DESC LIMIT 8 OFFSET ?");
+            getSales.setInt(1, OFFSET);
             ResultSet rs = getSales.executeQuery();
             ArrayList<Sale> sales = new ArrayList<Sale>();
             while (rs.next()) {