feat(manifest): configure facts options in the setup wizard

`socket manifest setup` now reflects Socket facts as the default for the gradle
and sbt generators and lets you configure the facts-only options it previously
couldn't: --include-configs, --exclude-configs, and --ignore-unresolved. These
are prompted only when facts generation is selected (not --pom), and the sbt
pom output questions (stdout/outfile) now only appear when pom is chosen.
Refreshes the stale "generate pom.xml (default)" wording left over from the
facts-by-default switch.

Author: jfblaa

src/commands/manifest/setup-manifest-config.mts

@@ -61,22 +61,24 @@ export async function setupManifestConfig(
     {
       name: 'Gradle'.padEnd(30, ' '),
       value: 'gradle',
-      description: 'Generate pom.xml files through gradle',
+      description: 'Generate a Socket facts file or pom.xml through gradle',
     },
     {
       name: 'Kotlin (gradle)'.padEnd(30, ' '),
       value: 'gradle',
-      description: 'Generate pom.xml files (for Kotlin) through gradle',
+      description:
+        'Generate a Socket facts file or pom.xml (for Kotlin) through gradle',
     },
     {
       name: 'Scala (gradle)'.padEnd(30, ' '),
       value: 'gradle',
-      description: 'Generate pom.xml files (for Scala) through gradle',
+      description:
+        'Generate a Socket facts file or pom.xml (for Scala) through gradle',
     },
     {
       name: 'Scala (sbt)'.padEnd(30, ' '),
       value: 'sbt',
-      description: 'Generate pom.xml files through sbt',
+      description: 'Generate a Socket facts file or pom.xml through sbt',
     },
   ]
 
@@ -292,6 +294,15 @@ async function setupGradle(
     delete config.facts
   }
 
+  // The config filters and --ignore-unresolved only apply to facts generation
+  // (the default); skip them when pom generation (--pom) is selected.
+  if (config.facts !== false) {
+    const factsOptions = await setupFactsOptions(config)
+    if (!factsOptions.ok || factsOptions.data.canceled) {
+      return factsOptions
+    }
+  }
+
   const verbose = await askForVerboseFlag(config.verbose)
   if (verbose === undefined) {
     return canceledByUser()
@@ -341,9 +352,10 @@ async function setupSbt(
     delete config.facts
   }
 
-  // --facts emits a .socket.facts.json instead of pom.xml files, so the pom
-  // output questions (stdout/outfile) don't apply when it is enabled.
-  if (config.facts !== true) {
+  // Socket facts is the default. The pom output questions (stdout/outfile)
+  // only apply when pom generation (--pom) is explicitly selected; otherwise
+  // ask the facts-only options.
+  if (config.facts === false) {
     const stdout = await askForStdout(config.stdout)
     if (stdout === undefined) {
       return canceledByUser()
@@ -370,6 +382,11 @@ async function setupSbt(
         }
       }
     }
+  } else {
+    const factsOptions = await setupFactsOptions(config)
+    if (!factsOptions.ok || factsOptions.data.canceled) {
+      return factsOptions
+    }
   }
 
   const verbose = await askForVerboseFlag(config.verbose)
@@ -504,21 +521,48 @@ async function askForVerboseFlag(
 
 async function askForFactsFlag(
   current: boolean | undefined,
+): Promise<string | undefined> {
+  return await select({
+    message: '(--facts / --pom) Which manifest should this generate?',
+    choices: [
+      {
+        name: 'Socket facts (default)',
+        value: 'yes',
+        description:
+          'Generate a .socket.facts.json file describing the resolved dependency graph',
+      },
+      {
+        name: 'pom.xml',
+        value: 'no',
+        description: 'Generate pom.xml manifest files instead (the --pom path)',
+      },
+      {
+        name: '(leave default)',
+        value: '',
+        description: 'Do not store a setting; uses the default (Socket facts)',
+      },
+    ],
+    default: current === true ? 'yes' : current === false ? 'no' : '',
+  })
+}
+
+async function askForIgnoreUnresolvedFlag(
+  current: boolean | undefined,
 ): Promise<string | undefined> {
   return await select({
     message:
-      '(--facts) Emit a Socket facts JSON file instead of generating pom.xml?',
+      '(--ignore-unresolved) Warn on unresolved dependencies instead of failing?',
     choices: [
       {
         name: 'no',
         value: 'no',
-        description: 'Generate pom.xml files (default behavior)',
+        description: 'Fail the run when a declared dependency cannot resolve',
       },
       {
         name: 'yes',
         value: 'yes',
         description:
-          'Generate a .socket.facts.json file describing the resolved dependency graph',
+          'Warn and continue; unresolved dependencies are omitted from the facts file',
       },
       {
         name: '(leave default)',
@@ -530,6 +574,55 @@ async function askForFactsFlag(
   })
 }
 
+// Prompts for the facts-only options shared by gradle and sbt: the config
+// include/exclude filters and --ignore-unresolved. Mutates `config` in place.
+async function setupFactsOptions(config: {
+  excludeConfigs?: string | undefined
+  ignoreUnresolved?: boolean | undefined
+  includeConfigs?: string | undefined
+}): Promise<CResult<{ canceled: boolean }>> {
+  const includeConfigs = await input({
+    message:
+      '(--include-configs) Comma-separated config-name globs to resolve (blank = all configurations)',
+    default: config.includeConfigs || '',
+    required: false,
+  })
+  if (includeConfigs === undefined) {
+    return canceledByUser()
+  } else if (includeConfigs) {
+    config.includeConfigs = includeConfigs
+  } else {
+    delete config.includeConfigs
+  }
+
+  const excludeConfigs = await input({
+    message:
+      '(--exclude-configs) Comma-separated config-name globs to skip (blank = none)',
+    default: config.excludeConfigs || '',
+    required: false,
+  })
+  if (excludeConfigs === undefined) {
+    return canceledByUser()
+  } else if (excludeConfigs) {
+    config.excludeConfigs = excludeConfigs
+  } else {
+    delete config.excludeConfigs
+  }
+
+  const ignoreUnresolved = await askForIgnoreUnresolvedFlag(
+    config.ignoreUnresolved,
+  )
+  if (ignoreUnresolved === undefined) {
+    return canceledByUser()
+  } else if (ignoreUnresolved === 'yes' || ignoreUnresolved === 'no') {
+    config.ignoreUnresolved = ignoreUnresolved === 'yes'
+  } else {
+    delete config.ignoreUnresolved
+  }
+
+  return notCanceled()
+}
+
 function canceledByUser(): CResult<{ canceled: boolean }> {
   logger.log('')
   logger.info('User canceled')